* [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs
@ 2022-06-14 17:53 Jeff Brasen
2022-07-07 18:14 ` Jeff Brasen
2022-07-19 1:43 ` 回复: " gaoliming
0 siblings, 2 replies; 7+ messages in thread
From: Jeff Brasen @ 2022-06-14 17:53 UTC (permalink / raw)
To: devel; +Cc: jian.j.wang, gaoliming, zhichao.gao, ray.ni, Jeff Brasen
Add support for getting disk info from UFS devices.
Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
---
MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c | 3 ++-
MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
index fac33b9ee9..87b82f299f 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
+++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
@@ -195,7 +195,8 @@ BmGetDescriptionFromDiskInfo (
BmEliminateExtraSpaces (Description);
}
- } else if (CompareGuid (&DiskInfo->Interface, &gEfiDiskInfoScsiInterfaceGuid)) {
+ } else if (CompareGuid (&DiskInfo->Interface, &gEfiDiskInfoScsiInterfaceGuid) ||
+ CompareGuid (&DiskInfo->Interface, &gEfiDiskInfoUfsInterfaceGuid)) {
BufferSize = sizeof (EFI_SCSI_INQUIRY_DATA);
Status = DiskInfo->Inquiry (
DiskInfo,
diff --git a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
index fe05d5f1cc..2fc0a80a4e 100644
--- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
+++ b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
@@ -85,6 +85,7 @@
gEfiDiskInfoIdeInterfaceGuid ## SOMETIMES_CONSUMES ## GUID
gEfiDiskInfoScsiInterfaceGuid ## SOMETIMES_CONSUMES ## GUID
gEfiDiskInfoSdMmcInterfaceGuid ## SOMETIMES_CONSUMES ## GUID
+ gEfiDiskInfoUfsInterfaceGuid ## SOMETIMES_CONSUMES ## GUID
[Protocols]
gEfiPciRootBridgeIoProtocolGuid ## CONSUMES
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs
2022-06-14 17:53 [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs Jeff Brasen
@ 2022-07-07 18:14 ` Jeff Brasen
2022-07-18 8:13 ` [edk2-devel] " Gao, Zhichao
2022-07-19 1:43 ` 回复: " gaoliming
1 sibling, 1 reply; 7+ messages in thread
From: Jeff Brasen @ 2022-07-07 18:14 UTC (permalink / raw)
To: devel@edk2.groups.io
Cc: jian.j.wang@intel.com, gaoliming@byosoft.com.cn,
zhichao.gao@intel.com, ray.ni@intel.com
Just following up on my outstanding edk2 patches to check on status/review feedback.
Thanks,
Jeff
> -----Original Message-----
> From: Jeff Brasen <jbrasen@nvidia.com>
> Sent: Tuesday, June 14, 2022 11:54 AM
> To: devel@edk2.groups.io
> Cc: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> zhichao.gao@intel.com; ray.ni@intel.com; Jeff Brasen
> <jbrasen@nvidia.com>
> Subject: [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info
> support for Ufs
>
> Add support for getting disk info from UFS devices.
>
> Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> ---
> MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c | 3 ++-
> MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git
> a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> index fac33b9ee9..87b82f299f 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> @@ -195,7 +195,8 @@ BmGetDescriptionFromDiskInfo (
>
>
> BmEliminateExtraSpaces (Description);
>
> }
>
> - } else if (CompareGuid (&DiskInfo->Interface,
> &gEfiDiskInfoScsiInterfaceGuid)) {
>
> + } else if (CompareGuid (&DiskInfo->Interface,
> &gEfiDiskInfoScsiInterfaceGuid) ||
>
> + CompareGuid (&DiskInfo->Interface,
> &gEfiDiskInfoUfsInterfaceGuid)) {
>
> BufferSize = sizeof (EFI_SCSI_INQUIRY_DATA);
>
> Status = DiskInfo->Inquiry (
>
> DiskInfo,
>
> diff --git
> a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> index fe05d5f1cc..2fc0a80a4e 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> +++
> b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> @@ -85,6 +85,7 @@
> gEfiDiskInfoIdeInterfaceGuid ## SOMETIMES_CONSUMES ## GUID
>
> gEfiDiskInfoScsiInterfaceGuid ## SOMETIMES_CONSUMES ## GUID
>
> gEfiDiskInfoSdMmcInterfaceGuid ## SOMETIMES_CONSUMES ##
> GUID
>
> + gEfiDiskInfoUfsInterfaceGuid ## SOMETIMES_CONSUMES ##
> GUID
>
>
>
> [Protocols]
>
> gEfiPciRootBridgeIoProtocolGuid ## CONSUMES
>
> --
> 2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs
2022-07-07 18:14 ` Jeff Brasen
@ 2022-07-18 8:13 ` Gao, Zhichao
0 siblings, 0 replies; 7+ messages in thread
From: Gao, Zhichao @ 2022-07-18 8:13 UTC (permalink / raw)
To: devel@edk2.groups.io, jbrasen@nvidia.com
Cc: Wang, Jian J, Gao, Liming, Ni, Ray
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
Thanks,
Zhichao
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Jeff
> Brasen via groups.io
> Sent: Friday, July 8, 2022 2:15 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>; Gao, Zhichao <zhichao.gao@intel.com>; Ni,
> Ray <ray.ni@intel.com>
> Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib:
> Add Disk Info support for Ufs
>
> Just following up on my outstanding edk2 patches to check on status/review
> feedback.
>
> Thanks,
> Jeff
>
> > -----Original Message-----
> > From: Jeff Brasen <jbrasen@nvidia.com>
> > Sent: Tuesday, June 14, 2022 11:54 AM
> > To: devel@edk2.groups.io
> > Cc: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> > zhichao.gao@intel.com; ray.ni@intel.com; Jeff Brasen
> > <jbrasen@nvidia.com>
> > Subject: [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info
> > support for Ufs
> >
> > Add support for getting disk info from UFS devices.
> >
> > Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> > ---
> > MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c | 3
> ++-
> > MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1
> +
> > 2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > index fac33b9ee9..87b82f299f 100644
> > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > @@ -195,7 +195,8 @@ BmGetDescriptionFromDiskInfo (
> >
> >
> > BmEliminateExtraSpaces (Description);
> >
> > }
> >
> > - } else if (CompareGuid (&DiskInfo->Interface,
> > &gEfiDiskInfoScsiInterfaceGuid)) {
> >
> > + } else if (CompareGuid (&DiskInfo->Interface,
> > &gEfiDiskInfoScsiInterfaceGuid) ||
> >
> > + CompareGuid (&DiskInfo->Interface,
> > &gEfiDiskInfoUfsInterfaceGuid)) {
> >
> > BufferSize = sizeof (EFI_SCSI_INQUIRY_DATA);
> >
> > Status = DiskInfo->Inquiry (
> >
> > DiskInfo,
> >
> > diff --git
> > a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > index fe05d5f1cc..2fc0a80a4e 100644
> > ---
> a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > +++
> > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > @@ -85,6 +85,7 @@
> > gEfiDiskInfoIdeInterfaceGuid ## SOMETIMES_CONSUMES ##
> GUID
> >
> > gEfiDiskInfoScsiInterfaceGuid ## SOMETIMES_CONSUMES ##
> GUID
> >
> > gEfiDiskInfoSdMmcInterfaceGuid ## SOMETIMES_CONSUMES ##
> > GUID
> >
> > + gEfiDiskInfoUfsInterfaceGuid ## SOMETIMES_CONSUMES ##
> > GUID
> >
> >
> >
> > [Protocols]
> >
> > gEfiPciRootBridgeIoProtocolGuid ## CONSUMES
> >
> > --
> > 2.25.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* 回复: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs
2022-06-14 17:53 [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs Jeff Brasen
2022-07-07 18:14 ` Jeff Brasen
@ 2022-07-19 1:43 ` gaoliming
2022-07-19 15:14 ` Jeff Brasen
1 sibling, 1 reply; 7+ messages in thread
From: gaoliming @ 2022-07-19 1:43 UTC (permalink / raw)
To: devel, jbrasen; +Cc: jian.j.wang, zhichao.gao, ray.ni
Jeff:
I want to confirm why UFS apply the same rule to SCSI. Does UFS follows
SCSI spec?
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Jeff Brasen
> via groups.io
> 发送时间: 2022年6月15日 1:54
> 收件人: devel@edk2.groups.io
> 抄送: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> zhichao.gao@intel.com; ray.ni@intel.com; Jeff Brasen <jbrasen@nvidia.com>
> 主题: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk
> Info support for Ufs
>
> Add support for getting disk info from UFS devices.
>
> Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> ---
> MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c | 3
> ++-
> MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git
> a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> index fac33b9ee9..87b82f299f 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> @@ -195,7 +195,8 @@ BmGetDescriptionFromDiskInfo (
>
>
> BmEliminateExtraSpaces (Description);
>
> }
>
> - } else if (CompareGuid (&DiskInfo->Interface,
> &gEfiDiskInfoScsiInterfaceGuid)) {
>
> + } else if (CompareGuid (&DiskInfo->Interface,
> &gEfiDiskInfoScsiInterfaceGuid) ||
>
> + CompareGuid (&DiskInfo->Interface,
> &gEfiDiskInfoUfsInterfaceGuid)) {
>
> BufferSize = sizeof (EFI_SCSI_INQUIRY_DATA);
>
> Status = DiskInfo->Inquiry (
>
> DiskInfo,
>
> diff --git
> a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> index fe05d5f1cc..2fc0a80a4e 100644
> --- a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> +++ b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> @@ -85,6 +85,7 @@
> gEfiDiskInfoIdeInterfaceGuid ##
> SOMETIMES_CONSUMES ## GUID
>
> gEfiDiskInfoScsiInterfaceGuid ##
> SOMETIMES_CONSUMES ## GUID
>
> gEfiDiskInfoSdMmcInterfaceGuid ##
> SOMETIMES_CONSUMES ## GUID
>
> + gEfiDiskInfoUfsInterfaceGuid ##
> SOMETIMES_CONSUMES ## GUID
>
>
>
> [Protocols]
>
> gEfiPciRootBridgeIoProtocolGuid ## CONSUMES
>
> --
> 2.25.1
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs
2022-07-19 1:43 ` 回复: " gaoliming
@ 2022-07-19 15:14 ` Jeff Brasen
2022-10-06 14:23 ` Jeff Brasen
0 siblings, 1 reply; 7+ messages in thread
From: Jeff Brasen @ 2022-07-19 15:14 UTC (permalink / raw)
To: gaoliming, devel@edk2.groups.io
Cc: jian.j.wang@intel.com, zhichao.gao@intel.com, ray.ni@intel.com
Yes, Universal Flash Storage is based on the SCSI architectural model and installs gEfiExtScsiPassThruProtocolGuid to function.
Thanks,
Jeff
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Monday, July 18, 2022 7:44 PM
> To: devel@edk2.groups.io; Jeff Brasen <jbrasen@nvidia.com>
> Cc: jian.j.wang@intel.com; zhichao.gao@intel.com; ray.ni@intel.com
> Subject: 回复: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib:
> Add Disk Info support for Ufs
>
> External email: Use caution opening links or attachments
>
>
> Jeff:
> I want to confirm why UFS apply the same rule to SCSI. Does UFS follows
> SCSI spec?
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Jeff Brasen
> via
> > groups.io
> > 发送时间: 2022年6月15日 1:54
> > 收件人: devel@edk2.groups.io
> > 抄送: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> > zhichao.gao@intel.com; ray.ni@intel.com; Jeff Brasen
> > <jbrasen@nvidia.com>
> > 主题: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add
> Disk
> > Info support for Ufs
> >
> > Add support for getting disk info from UFS devices.
> >
> > Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> > ---
> > MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c | 3
> > ++-
> > MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf | 1
> +
> > 2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git
> > a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > index fac33b9ee9..87b82f299f 100644
> > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > @@ -195,7 +195,8 @@ BmGetDescriptionFromDiskInfo (
> >
> >
> > BmEliminateExtraSpaces (Description);
> >
> > }
> >
> > - } else if (CompareGuid (&DiskInfo->Interface,
> > &gEfiDiskInfoScsiInterfaceGuid)) {
> >
> > + } else if (CompareGuid (&DiskInfo->Interface,
> > &gEfiDiskInfoScsiInterfaceGuid) ||
> >
> > + CompareGuid (&DiskInfo->Interface,
> > &gEfiDiskInfoUfsInterfaceGuid)) {
> >
> > BufferSize = sizeof (EFI_SCSI_INQUIRY_DATA);
> >
> > Status = DiskInfo->Inquiry (
> >
> > DiskInfo,
> >
> > diff --git
> > a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > index fe05d5f1cc..2fc0a80a4e 100644
> > ---
> a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > +++
> b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > @@ -85,6 +85,7 @@
> > gEfiDiskInfoIdeInterfaceGuid ##
> > SOMETIMES_CONSUMES ## GUID
> >
> > gEfiDiskInfoScsiInterfaceGuid ##
> > SOMETIMES_CONSUMES ## GUID
> >
> > gEfiDiskInfoSdMmcInterfaceGuid ##
> > SOMETIMES_CONSUMES ## GUID
> >
> > + gEfiDiskInfoUfsInterfaceGuid ##
> > SOMETIMES_CONSUMES ## GUID
> >
> >
> >
> > [Protocols]
> >
> > gEfiPciRootBridgeIoProtocolGuid ## CONSUMES
> >
> > --
> > 2.25.1
> >
> >
> >
> >
> >
> >
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs
2022-07-19 15:14 ` Jeff Brasen
@ 2022-10-06 14:23 ` Jeff Brasen
2022-10-06 14:38 ` Ard Biesheuvel
0 siblings, 1 reply; 7+ messages in thread
From: Jeff Brasen @ 2022-10-06 14:23 UTC (permalink / raw)
To: gaoliming, devel@edk2.groups.io
Cc: jian.j.wang@intel.com, zhichao.gao@intel.com, ray.ni@intel.com
Any additional thoughts on this patch?
> -----Original Message-----
> From: Jeff Brasen
> Sent: Tuesday, July 19, 2022 9:14 AM
> To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> Cc: jian.j.wang@intel.com; zhichao.gao@intel.com; ray.ni@intel.com
> Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib:
> Add Disk Info support for Ufs
>
> Yes, Universal Flash Storage is based on the SCSI architectural model and
> installs gEfiExtScsiPassThruProtocolGuid to function.
>
> Thanks,
> Jeff
>
> > -----Original Message-----
> > From: gaoliming <gaoliming@byosoft.com.cn>
> > Sent: Monday, July 18, 2022 7:44 PM
> > To: devel@edk2.groups.io; Jeff Brasen <jbrasen@nvidia.com>
> > Cc: jian.j.wang@intel.com; zhichao.gao@intel.com; ray.ni@intel.com
> > Subject: 回复: [edk2-devel] [PATCH]
> MdeModulePkg/UefiBootManagerLib:
> > Add Disk Info support for Ufs
> >
> > External email: Use caution opening links or attachments
> >
> >
> > Jeff:
> > I want to confirm why UFS apply the same rule to SCSI. Does UFS
> > follows SCSI spec?
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Jeff
> Brasen
> > via
> > > groups.io
> > > 发送时间: 2022年6月15日 1:54
> > > 收件人: devel@edk2.groups.io
> > > 抄送: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> > > zhichao.gao@intel.com; ray.ni@intel.com; Jeff Brasen
> > > <jbrasen@nvidia.com>
> > > 主题: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add
> > Disk
> > > Info support for Ufs
> > >
> > > Add support for getting disk info from UFS devices.
> > >
> > > Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> > > ---
> > > MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c | 3
> > > ++-
> > > MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf |
> 1
> > +
> > > 2 files changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git
> > > a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > > b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > > index fac33b9ee9..87b82f299f 100644
> > > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > > +++
> b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > > @@ -195,7 +195,8 @@ BmGetDescriptionFromDiskInfo (
> > >
> > >
> > > BmEliminateExtraSpaces (Description);
> > >
> > > }
> > >
> > > - } else if (CompareGuid (&DiskInfo->Interface,
> > > &gEfiDiskInfoScsiInterfaceGuid)) {
> > >
> > > + } else if (CompareGuid (&DiskInfo->Interface,
> > > &gEfiDiskInfoScsiInterfaceGuid) ||
> > >
> > > + CompareGuid (&DiskInfo->Interface,
> > > &gEfiDiskInfoUfsInterfaceGuid)) {
> > >
> > > BufferSize = sizeof (EFI_SCSI_INQUIRY_DATA);
> > >
> > > Status = DiskInfo->Inquiry (
> > >
> > > DiskInfo,
> > >
> > > diff --git
> > > a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > > index fe05d5f1cc..2fc0a80a4e 100644
> > > ---
> > a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > > +++
> > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > > @@ -85,6 +85,7 @@
> > > gEfiDiskInfoIdeInterfaceGuid ##
> > > SOMETIMES_CONSUMES ## GUID
> > >
> > > gEfiDiskInfoScsiInterfaceGuid ##
> > > SOMETIMES_CONSUMES ## GUID
> > >
> > > gEfiDiskInfoSdMmcInterfaceGuid ##
> > > SOMETIMES_CONSUMES ## GUID
> > >
> > > + gEfiDiskInfoUfsInterfaceGuid ##
> > > SOMETIMES_CONSUMES ## GUID
> > >
> > >
> > >
> > > [Protocols]
> > >
> > > gEfiPciRootBridgeIoProtocolGuid ## CONSUMES
> > >
> > > --
> > > 2.25.1
> > >
> > >
> > >
> > >
> > >
> > >
> >
> >
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs
2022-10-06 14:23 ` Jeff Brasen
@ 2022-10-06 14:38 ` Ard Biesheuvel
0 siblings, 0 replies; 7+ messages in thread
From: Ard Biesheuvel @ 2022-10-06 14:38 UTC (permalink / raw)
To: devel, jbrasen
Cc: gaoliming, jian.j.wang@intel.com, zhichao.gao@intel.com,
ray.ni@intel.com
On Thu, 6 Oct 2022 at 16:23, Jeff Brasen via groups.io
<jbrasen=nvidia.com@groups.io> wrote:
>
> Any additional thoughts on this patch?
>
If you resend it using a mail client that doesn't corrupt all the
whitespace, I can merge it for you (with Zhichao's ack).
> > -----Original Message-----
> > From: Jeff Brasen
> > Sent: Tuesday, July 19, 2022 9:14 AM
> > To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> > Cc: jian.j.wang@intel.com; zhichao.gao@intel.com; ray.ni@intel.com
> > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib:
> > Add Disk Info support for Ufs
> >
> > Yes, Universal Flash Storage is based on the SCSI architectural model and
> > installs gEfiExtScsiPassThruProtocolGuid to function.
> >
> > Thanks,
> > Jeff
> >
> > > -----Original Message-----
> > > From: gaoliming <gaoliming@byosoft.com.cn>
> > > Sent: Monday, July 18, 2022 7:44 PM
> > > To: devel@edk2.groups.io; Jeff Brasen <jbrasen@nvidia.com>
> > > Cc: jian.j.wang@intel.com; zhichao.gao@intel.com; ray.ni@intel.com
> > > Subject: 回复: [edk2-devel] [PATCH]
> > MdeModulePkg/UefiBootManagerLib:
> > > Add Disk Info support for Ufs
> > >
> > > External email: Use caution opening links or attachments
> > >
> > >
> > > Jeff:
> > > I want to confirm why UFS apply the same rule to SCSI. Does UFS
> > > follows SCSI spec?
> > >
> > > Thanks
> > > Liming
> > > > -----邮件原件-----
> > > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Jeff
> > Brasen
> > > via
> > > > groups.io
> > > > 发送时间: 2022年6月15日 1:54
> > > > 收件人: devel@edk2.groups.io
> > > > 抄送: jian.j.wang@intel.com; gaoliming@byosoft.com.cn;
> > > > zhichao.gao@intel.com; ray.ni@intel.com; Jeff Brasen
> > > > <jbrasen@nvidia.com>
> > > > 主题: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Add
> > > Disk
> > > > Info support for Ufs
> > > >
> > > > Add support for getting disk info from UFS devices.
> > > >
> > > > Signed-off-by: Jeff Brasen <jbrasen@nvidia.com>
> > > > ---
> > > > MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c | 3
> > > > ++-
> > > > MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf |
> > 1
> > > +
> > > > 2 files changed, 3 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git
> > > > a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > > > b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > > > index fac33b9ee9..87b82f299f 100644
> > > > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > > > +++
> > b/MdeModulePkg/Library/UefiBootManagerLib/BmBootDescription.c
> > > > @@ -195,7 +195,8 @@ BmGetDescriptionFromDiskInfo (
> > > >
> > > >
> > > > BmEliminateExtraSpaces (Description);
> > > >
> > > > }
> > > >
> > > > - } else if (CompareGuid (&DiskInfo->Interface,
> > > > &gEfiDiskInfoScsiInterfaceGuid)) {
> > > >
> > > > + } else if (CompareGuid (&DiskInfo->Interface,
> > > > &gEfiDiskInfoScsiInterfaceGuid) ||
> > > >
> > > > + CompareGuid (&DiskInfo->Interface,
> > > > &gEfiDiskInfoUfsInterfaceGuid)) {
> > > >
> > > > BufferSize = sizeof (EFI_SCSI_INQUIRY_DATA);
> > > >
> > > > Status = DiskInfo->Inquiry (
> > > >
> > > > DiskInfo,
> > > >
> > > > diff --git
> > > > a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > > > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > > > index fe05d5f1cc..2fc0a80a4e 100644
> > > > ---
> > > a/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > > > +++
> > > b/MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> > > > @@ -85,6 +85,7 @@
> > > > gEfiDiskInfoIdeInterfaceGuid ##
> > > > SOMETIMES_CONSUMES ## GUID
> > > >
> > > > gEfiDiskInfoScsiInterfaceGuid ##
> > > > SOMETIMES_CONSUMES ## GUID
> > > >
> > > > gEfiDiskInfoSdMmcInterfaceGuid ##
> > > > SOMETIMES_CONSUMES ## GUID
> > > >
> > > > + gEfiDiskInfoUfsInterfaceGuid ##
> > > > SOMETIMES_CONSUMES ## GUID
> > > >
> > > >
> > > >
> > > > [Protocols]
> > > >
> > > > gEfiPciRootBridgeIoProtocolGuid ## CONSUMES
> > > >
> > > > --
> > > > 2.25.1
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
> > >
> > >
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-10-06 14:39 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-14 17:53 [PATCH] MdeModulePkg/UefiBootManagerLib: Add Disk Info support for Ufs Jeff Brasen
2022-07-07 18:14 ` Jeff Brasen
2022-07-18 8:13 ` [edk2-devel] " Gao, Zhichao
2022-07-19 1:43 ` 回复: " gaoliming
2022-07-19 15:14 ` Jeff Brasen
2022-10-06 14:23 ` Jeff Brasen
2022-10-06 14:38 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox