From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 739AD740060 for ; Fri, 22 Sep 2023 14:24:25 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=dq6wihoi57ybhXgZofRr4sEyH9YxCzFFcsAvLskfVL8=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695392664; v=1; b=MpC6DFSGV8R6KLOZnu6VpOjOUAa3bjiA3vWBAUvWiQWboZV2YbTe/jQEQPktwEuvkuL7QDM7 tlzGH4Ne/9teUzUircl2lu8kIkHUk6qJK41h7rsH0TDfZliqSppN4hS7Db2pWU3Mit75Sqs5Qyf mJCaGgluJhayY1l8JfSWlFAU= X-Received: by 127.0.0.2 with SMTP id YjCTYY7687511xbVe3UXSPdh; Fri, 22 Sep 2023 07:24:24 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.61]) by mx.groups.io with SMTP id smtpd.web10.22557.1695392663464992645 for ; Fri, 22 Sep 2023 07:24:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=e+OUKfPljVOhJ50xykxX3dei6YpC3k+yAvhaRHNdSdTmgaMD40lMmhYiRmj0dL1u9tnbXBv3o7Pcs/tLvrmnWK4/FKiVJMBxKLuup3r4Rc+6ktt7oWfxpDwMvSm4l2OBWiG5S3+AnGoXsCBDFOSSEfiQoBAogEuEsNDPftiDDjLx7/Vw9fLrLsT+8mEZkB+971JZoW/TU0oDkzM5fixrgd/f7uig4l2/3Lz5fVNfiAE25xISvs3UJcP436xsnBHHWKg42BNJuhNMb7OpGdt69fAYqj6kqRp5GCCj35QLJKKqnSUmBSDrgvOuYVeLtMWfoKXFtbmuw0pUcSjDL66CXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bHrfmEW8NgAkZIhmK+VC4IgefX5UP+Um/yFYRmN5790=; b=NVzHxObopb+Lr2O/+RZURtLF0wCMDHYxwHH0BHrrPENtt3nZt8yGwtmKOv90XjDcX+g9O2oAGlIj23PvYpeD44WLawMlQbxJAgsMQ+0TGo9ZuwYqftwDiUrjtSG8QkQbJLkq+J34vLT5ehYaqUS4D94t9TqGF3iYio0ZQfbmwDWGIHgGK5BYUenY3767oAlVnSRDQALnstDrijlKUQyCD6mFwNU7Wn/Tpii3BVURKzlcexCt4Q2fJEEXmdgqaRZ+t9OEc6hPxP1NeYq6pvgKMK4MFFpN2GYuj3vOET7KXusT86b/feZrG+Hqu0jkBGTWugCJnVrUphq76LMwAqdv4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none X-Received: from DS7PR12MB5789.namprd12.prod.outlook.com (2603:10b6:8:74::21) by SA1PR12MB6776.namprd12.prod.outlook.com (2603:10b6:806:25b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.20; Fri, 22 Sep 2023 14:24:20 +0000 X-Received: from DS7PR12MB5789.namprd12.prod.outlook.com ([fe80::639c:a3f3:9403:ed05]) by DS7PR12MB5789.namprd12.prod.outlook.com ([fe80::639c:a3f3:9403:ed05%4]) with mapi id 15.20.6813.017; Fri, 22 Sep 2023 14:24:19 +0000 From: "Jeff Brasen via groups.io" To: "pierre.gondois@arm.com" , "devel@edk2.groups.io" CC: Sami Mujawar , Leif Lindholm Subject: Re: [edk2-devel] [PATCH 1/1] DynamicTablesPkg/AmlLib: Define an enum for IsaRanges Thread-Topic: [PATCH 1/1] DynamicTablesPkg/AmlLib: Define an enum for IsaRanges Thread-Index: AQHZ7V+nGBfPnIj9CUGXWH1DDK2pD7Am5gfQ Date: Fri, 22 Sep 2023 14:24:19 +0000 Message-ID: References: <20230922141817.1651629-1-pierre.gondois@arm.com> In-Reply-To: <20230922141817.1651629-1-pierre.gondois@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: DS7PR12MB5789:EE_|SA1PR12MB6776:EE_ x-ms-office365-filtering-correlation-id: cb98c5e3-b698-4683-fc75-08dbbb779c21 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: UK4/5ndMXT1uuEM4s91An8WQZr32vPnX966oURCPZgPXoF55pSGomHS+wB5XTf8+2knUM+/n4HC9kOXzhdPbXH3EEKp9QuTgTaagxBDuIgu9wT/y3l320yBDUkZAv25l6DLeJ6MGqUgofFHQ/m9gnjmEZMc0doAWaSOROQ2jkKW1PA4A7w+g4YHVZMbm51Z7m23lMrfATWPvS2Uu8MMBHum/gpcnNA5HzgQz/zZB+tl452p/fn/nX/oqqDv6Ze5ki7BNz534afMd2KUpknh+BlG5gl68d9wcPOAi4HUP9h/UPvJEoFREAd5HkELYeaVMbiWbPNyTgDoQhgI7quyRezRiYeDNq+s2Ho9Xdy7q4Yn5LzSNPMQvoDbU0xkOXEL5VPts8dopiS0BAjYSAba9sxm0gzh4DCz/ip+tenjy2i3ETv/O3vUGOwRjlI1Jk3jxwWemVQTT44ZG+lzOzKWHpDrYj9JA9ofLvzqdry9oD1kDvByJlv2/oiojZWPc7TgcGM6vRyYa8p6WBCe7+RGu8TOsaDyxNtu12CtVax7M/PlaqtxqSGUztBINhpkq7z36KF20QPL3RoW0ko8vTSZXLR8iA1usLf/0KtVrJ/U1AIsSW7MNVsTG6EocdJrTGGkV x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vsf8U+93fX3t7RPibr0yBxZ34W9+5nc8BCT084MyTJM5mt4Qu5UgjIPfcODP?= =?us-ascii?Q?Iq8HolGGFeW1DYFwFif6DXuQcH7CKk5jw68jEpFjb+7fOwk1IsgRSSZO3701?= =?us-ascii?Q?P6WcFPNoWNeRxLna3fs0QxL2P2lFKAQOkzmr5SiNhQICKN+FZi5dFKHvAXH4?= =?us-ascii?Q?Xhy0N4zzzJHnUaWB/DAD4b9J0GmXPgBPNF+lQnu3LryJJjFTpnRQIshyBY59?= =?us-ascii?Q?QdEIKFc4NYru3MrJJeYV5kl4PHOGRAKX/2cgkl9Qgnv1CLaxV2KZpgPzxbcT?= =?us-ascii?Q?tOZhr2Szqi6mRf2yvtdWk06ofY0ymjjsAuzM6nWyOwEBcBWHgUuqEZ8y9gPY?= =?us-ascii?Q?zLkhf9chMugKoNhlmvOdfxAAaQWdGJuo0viEMoXSqNHiuNSwV0D8DN4Cyf/Z?= =?us-ascii?Q?7PCd0VlehXXhQe45/PX1bsdhuUJXn3z42BB9FIxwLdu6uNhCOLxob8hby74u?= =?us-ascii?Q?p0iuujlLndcZRwDUPrCdz562VCZ/tyCAC2wz6Nx/3RucLqC7xYxvBhMcZmpW?= =?us-ascii?Q?gSBxPjVyN9EamCVSJdMGEd51xq4AZvGiCDwWRrDXHpcshwus6W2cDcwyYv6H?= =?us-ascii?Q?i17W7lweuDUwBleyfFiR20keM7BL5TsPTQJqq7tJyI4rGV6R68ZtlHKGcEiy?= =?us-ascii?Q?Guu3fQXehQioGyMDcZH6NAXMplBsLeSMDembs/4icQGAMkjQvx3KQwt/ZqXd?= =?us-ascii?Q?uh/FFTQxfIv6q0FLew0g/7SHbvlooaXTpovKOPn28boRQNL3bAOljPyTxkfp?= =?us-ascii?Q?9MD5Cl/5y3oZ8CPPLUwgtU5z1v6TnXHqj4fZ9075teYtcYJo4V/M+DkgLGsd?= =?us-ascii?Q?CZW26jYOQDICUKmI4FO/pxNCeIF22JfJDc4Z8O1/f7XvPEjEhj+v/RJb0v2b?= =?us-ascii?Q?QCODf/dV6V2xtJLEYXY8FpiEwbyVDSORTrWOxkpGJ+WdKg+OeKfoHWPnAZQF?= =?us-ascii?Q?njjraknAyS5/lTCpWI2f8PStdyENZlQsOPiBWaBfhXc/7hie1f1FDqloUwPj?= =?us-ascii?Q?6bwLmgGYxeBYSRpjRZANht6E4wEcTPafkdwS9tgsgRWTRuLczNyxB6qQTCqC?= =?us-ascii?Q?TkN5cQ1Bpm666p4jEzGOXRWLLEbW9vFOHH6tAmLX0j0aqxG6G3sTw27+kYb1?= =?us-ascii?Q?FqSVm3i1tQ1qUJrGTuX/AuhSjeymHpf7ON8hxrRgLRD1ZJIhdssa76O8e8YZ?= =?us-ascii?Q?yCexxioAtFpyagxxSYnyeQl0zMLzddX0k76f0DIvK3jFoqIY43giRka6K3ia?= =?us-ascii?Q?3cKBSGOn0p6Fbtx8t/EFMTGA7DcuoAVNK6FTbWEK2wEWKnk80bcDTwCZPSla?= =?us-ascii?Q?5I3Csgv4oD6/x+O7+f4Xv394N+EdKuJwRIq4INNPatp8R89wcKCgHf51nZjZ?= =?us-ascii?Q?7cqsw72qwvJeT7xdQN4sPpDcbWu0lQe+NqQluJAyXiFZvrUfJWJGLVS9nBbO?= =?us-ascii?Q?ULCfCW9puX6lbeK4s66zevS9OmVSGIaAXi5tVy092UtT4yvu9g6v7+4sZs9U?= =?us-ascii?Q?GnZ4+IHkpRm2Yvka9TbG7iGEZqDE3+eY3yYoTxbNMYjBMfBkaa4U16nVRDgZ?= =?us-ascii?Q?k1x5zFXNGB2sbP38yVeW7BN9+Wl8bQvoI85GLIaD?= MIME-Version: 1.0 X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DS7PR12MB5789.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cb98c5e3-b698-4683-fc75-08dbbb779c21 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2023 14:24:19.7973 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DyTiZ0ik6EBKHmwNmBWqzmtkMD+Ph8joxCIah4Efwx7uTtfGoURus1BfVjHnnzw1qpXLVRTjBk26Rzy0LzEWAA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6776 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jbrasen@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Rj1EPp1G11IEAsKNimyzbbFIx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=MpC6DFSG; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Jeff Brasen > -----Original Message----- > From: pierre.gondois@arm.com > Sent: Friday, September 22, 2023 8:18 AM > To: devel@edk2.groups.io > Cc: Sami Mujawar ; Leif Lindholm > ; Jeff Brasen > Subject: [PATCH 1/1] DynamicTablesPkg/AmlLib: Define an enum for > IsaRanges >=20 > External email: Use caution opening links or attachments >=20 >=20 > From: Pierre Gondois >=20 > The IsaRange parameter in: > - AmlCodeGenRdDWordIo() > - AmlCodeGenRdQWordIo() > is an hard-coded value. Define an enum for IsarRanges and use it. >=20 > Suggested-by: Leif Lindholm > Signed-off-by: Pierre Gondois > --- > .../Include/Library/AmlLib/AmlLib.h | 28 +++++++++++-------- > .../AcpiSsdtPcieLibArm/SsdtPcieGenerator.c | 2 +- > .../AmlLib/CodeGen/AmlResourceDataCodeGen.c | 28 +++++++------------ > 3 files changed, 27 insertions(+), 31 deletions(-) >=20 > diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > index 8e24cecdd77b..ce81f5876681 100644 > --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h > @@ -59,6 +59,18 @@ typedef void *AML_DATA_NODE_HANDLE; >=20 > #endif // AML_HANDLE >=20 > +/** Enum for ISA Ranges. > + > + See ACPI 6.4 spec, s19.6.34 for more. > +*/ > +typedef enum { > + EAmlIsaRangeReserved =3D 0, ///< Reserved. > + EAmlIsaRangeNonIsaOnly, ///< NonIsaOnly. > + EAmlIsaRangeIsaOnly, ///< IsaOnly. > + EAmlIsaRangeEntireRange, ///< EntireRange. > + EAmlIsaRangeMax, ///< Max. > +} EAML_ISA_RANGE; > + > /** Parse the definition block. >=20 > The function parses the whole AML blob. It starts with the ACPI DSDT/S= SDT > @@ -471,11 +483,7 @@ AmlUpdateRdQWord ( > @param [in] IsMinFixed Minimum address is fixed. > @param [in] IsMaxFixed Maximum address is fixed. > @param [in] IsPosDecode Decode parameter > - @param [in] IsaRanges Possible values are: > - 0-Reserved > - 1-NonISAOnly > - 2-ISAOnly > - 3-EntireRange > + @param [in] IsaRanges Isa Range. > @param [in] AddressGranularity Address granularity. > @param [in] AddressMinimum Minimum address. > @param [in] AddressMaximum Maximum address. > @@ -505,7 +513,7 @@ AmlCodeGenRdDWordIo ( > IN BOOLEAN IsMinFixed, > IN BOOLEAN IsMaxFixed, > IN BOOLEAN IsPosDecode, > - IN UINT8 IsaRanges, > + IN EAML_ISA_RANGE IsaRanges, > IN UINT32 AddressGranularity, > IN UINT32 AddressMinimum, > IN UINT32 AddressMaximum, > @@ -702,11 +710,7 @@ AmlCodeGenRdWordBusNumber ( > @param [in] IsMinFixed Minimum address is fixed. > @param [in] IsMaxFixed Maximum address is fixed. > @param [in] IsPosDecode Decode parameter > - @param [in] IsaRanges Possible values are: > - 0-Reserved > - 1-NonISAOnly > - 2-ISAOnly > - 3-EntireRange > + @param [in] IsaRanges Isa Range. > @param [in] AddressGranularity Address granularity. > @param [in] AddressMinimum Minimum address. > @param [in] AddressMaximum Maximum address. > @@ -736,7 +740,7 @@ AmlCodeGenRdQWordIo ( > IN BOOLEAN IsMinFixed, > IN BOOLEAN IsMaxFixed, > IN BOOLEAN IsPosDecode, > - IN UINT8 IsaRanges, > + IN EAML_ISA_RANGE IsaRanges, > IN UINT64 AddressGranularity, > IN UINT64 AddressMinimum, > IN UINT64 AddressMaximum, > diff --git > a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenera > tor.c > b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenera > tor.c > index 9ddaddc198fa..87b426ccfe07 100644 > --- > a/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGenera > tor.c > +++ > b/DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtPcieLibArm/SsdtPcieGener > +++ ator.c > @@ -545,7 +545,7 @@ GeneratePciCrs ( > TRUE, > TRUE, > IsPosDecode, > - 3, > + EAmlIsaRangeEntireRange, > 0, > AddrMapInfo->PciAddress, > AddrMapInfo->PciAddress + AddrMapInfo->AddressSize - = 1, diff -- > git > a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataC > odeGen.c > b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataC > odeGen.c > index 9c6700b9e08c..707e8182b4c0 100644 > --- > a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataC > odeGen.c > +++ > b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataC > ode > +++ Gen.c > @@ -121,13 +121,13 @@ STATIC > UINT8 > EFIAPI > RdIoRangeSpecificFlags ( > - IN UINT8 IsaRanges, > - IN BOOLEAN IsDenseTranslation, > - IN BOOLEAN IsTypeStatic > + IN EAML_ISA_RANGE IsaRanges, > + IN BOOLEAN IsDenseTranslation, > + IN BOOLEAN IsTypeStatic > ) > { > // Only check type specific parameters. > - if (IsaRanges > 3) { > + if (IsaRanges >=3D EAmlIsaRangeMax) { > ASSERT (0); > return MAX_UINT8; > } > @@ -440,20 +440,16 @@ AmlCodeGenRdDWordSpace ( > @param [in] IsMinFixed Minimum address is fixed. > @param [in] IsMaxFixed Maximum address is fixed. > @param [in] IsPosDecode Decode parameter > - @param [in] IsaRanges Possible values are: > - 0-Reserved > - 1-NonISAOnly > - 2-ISAOnly > - 3-EntireRange > + @param [in] IsaRanges Isa Range. > @param [in] AddressGranularity Address granularity. > @param [in] AddressMinimum Minimum address. > @param [in] AddressMaximum Maximum address. > @param [in] AddressTranslation Address translation. > @param [in] RangeLength Range length. > @param [in] ResourceSourceIndex Resource Source index. > - Unused. Must be 0. > + Not supported. Must be 0. > @param [in] ResourceSource Resource Source. > - Unused. Must be NULL. > + Not supported. Must be NULL. > @param [in] IsDenseTranslation TranslationDensity parameter. > @param [in] IsTypeStatic TranslationType parameter. > @param [in] NameOpNode NameOp object node defining a named > object. > @@ -474,7 +470,7 @@ AmlCodeGenRdDWordIo ( > IN BOOLEAN IsMinFixed, > IN BOOLEAN IsMaxFixed, > IN BOOLEAN IsPosDecode, > - IN UINT8 IsaRanges, > + IN EAML_ISA_RANGE IsaRanges, > IN UINT32 AddressGranularity, > IN UINT32 AddressMinimum, > IN UINT32 AddressMaximum, > @@ -1031,11 +1027,7 @@ AmlCodeGenRdQWordSpace ( > @param [in] IsMinFixed Minimum address is fixed. > @param [in] IsMaxFixed Maximum address is fixed. > @param [in] IsPosDecode Decode parameter > - @param [in] IsaRanges Possible values are: > - 0-Reserved > - 1-NonISAOnly > - 2-ISAOnly > - 3-EntireRange > + @param [in] IsaRanges Isa Range. > @param [in] AddressGranularity Address granularity. > @param [in] AddressMinimum Minimum address. > @param [in] AddressMaximum Maximum address. > @@ -1065,7 +1057,7 @@ AmlCodeGenRdQWordIo ( > IN BOOLEAN IsMinFixed, > IN BOOLEAN IsMaxFixed, > IN BOOLEAN IsPosDecode, > - IN UINT8 IsaRanges, > + IN EAML_ISA_RANGE IsaRanges, > IN UINT64 AddressGranularity, > IN UINT64 AddressMinimum, > IN UINT64 AddressMaximum, > -- > 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108992): https://edk2.groups.io/g/devel/message/108992 Mute This Topic: https://groups.io/mt/101521874/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-