From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from loongson.cn (loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web10.32513.1669012811358645895 for ; Sun, 20 Nov 2022 22:40:11 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: loongson.cn, ip: 114.242.206.163, mailfrom: lichao@loongson.cn) Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8AxzNhIHXtj3gwJAA--.25088S3; Mon, 21 Nov 2022 14:40:09 +0800 (CST) Received: from lichao-PC (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Dxr+BEHXtj43gXAA--.61693S2; Mon, 21 Nov 2022 14:40:04 +0800 (CST) Date: Mon, 21 Nov 2022 14:40:04 +0800 From: "Chao Li" To: "=?utf-8?Q?devel=40edk2.groups.io?=" , "=?utf-8?Q?lichao=40loongson.cn?=" Cc: "=?utf-8?Q?=22_devel=40edk2.groups.io_=22?=" , "=?utf-8?Q?=22_qiandongyan=40loongson.cn_=22?=" , Jian J Wang , Liming Gao , Ray Ni , Bo Zhu Message-ID: In-Reply-To: <17285D6A96D40CE0.20144@groups.io> References: <17285D6A96D40CE0.20144@groups.io> Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Disable PciDegrade support for LoongArch64 X-Mailer: Mailspring MIME-Version: 1.0 X-CM-TRANSID: AQAAf8Dxr+BEHXtj43gXAA--.61693S2 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQARCGN6GOUGEQAFsu X-Coremail-Antispam: 1Uk129KBjvJXoW7tFWUWFWUKF1UKr4kuryUKFg_yoW8tryxpw sIy343A34rtw1qkFW8GryUXr4F9a95WFZaqan8tw1j9F4DC3ZayasIkwn5KayxZ3W0q3WD Xry5Aw48X3Wj9rJanT9S1TB71UUUUUDqnTZGkaVYY2UrUUUUj1kv1TuYvTs0mT0YCTnIWj v05I8CrVAYj202j2C_Jr0_Gr1l5I8CrVAaz4v26cxKscIFY7kG0wAqx4xG64xvF2IEw4CE 5I8CrVC2j2Wl5I8CrVAKz4kIr2xC04v26r4j6ryUYxn0WfASr-VFAUDa7-sFnT9fnUUIcS sGvfJTRUUUbkkYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20xva j40_Wr0E3s1l1IIY67AEw4v_JrI_Jryl8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2 x7M28EF7xvwVC0I7IYx2IY67AKxVWUCVW8JwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVWU JVW8JwA2z4x0Y4vEx4A2jsIE14v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r 4UJVWxJr1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27wAq x4xG67k08I80eVWUJVW8JwAqx4xG62kEwI0EY4vaYxAvb48xMc02F40EFcxC0VAKzVAqx4 xG6I80ewAqx4xG64kEw2xG04xIwI0_Gr0_Xr1lYx0E2Ix0cI8IcVAFwI0_Jrv_JF1lYx0E x4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCjr7 xvwVCIw2I0I7xG6c02F41l42xK82IYc2Ij64vIr41l4I8I3I0E4IkC6x0Yz7v_Jr0_Gr1l x2IqxVAqx4xG67AKxVWUGVWUWwC20s026x8GjcxK67AKxVWUGVWUWwC2zVAF1VAY17CE14 v26r1q6r43MIIYrxkI7VAKI48JMIIF0xvE2Ix0cI8IcVAFwI0_Jr0_JF4lIxAIcVC0I7IY x2IY6xkF7I0E14v26r1j6r4UMIIF0xvE42xK8VAvwI8IcIk0rVWUJVWUCwCI42IY6I8E87 Iv67AKxVWUJVW8JwCI42IY6I8E87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZF pf9x07jodgAUUUUU= Content-Type: multipart/alternative; boundary="637b1d44_45f987fb_2a03" --637b1d44_45f987fb_2a03 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hi Liming, Jian and Ray, Please help to review this change, thanks! Thanks, Chao -------- On 11=E6=9C=88 17 2022, at 7:59 =E6=99=9A=E4=B8=8A, "Chao Li" wrote: > Reviewed-by: Chao Li > > > Thanks, > Chao > -------- > > On 11=E6=9C=88 17 2022, at 4:47 =E4=B8=8B=E5=8D=88, "Dongyan Qian" wrote: > > LoongArch64: Pcie devices that come with OPROM may require large Mem Sp= ace, > > and downgrading all 64 Bit Bars may result in insufficient space. > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4157 > > Cc: Jian J Wang > > Cc: Liming Gao > > Cc: Ray Ni > > Cc: Chao Li > > Signed-off-by: Dongyan Qian > > Co-authored-by: Bo Zhu > > --- > > MdeModulePkg/MdeModulePkg.dec | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.= dec > > index 58e6ab0048..be5e829ca9 100644 > > --- a/MdeModulePkg/MdeModulePkg.dec > > +++ b/MdeModulePkg/MdeModulePkg.dec > > @@ -917,7 +917,7 @@ > > # @Prompt Enable process non-reset capsule image at runtime. > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdSupportProcessCapsuleAtRuntime|FALSE|= BOOLEAN|0x00010079 > > > > > > -[PcdsFeatureFlag.IA32, PcdsFeatureFlag.ARM, PcdsFeatureFlag.AARCH64] > > +[PcdsFeatureFlag.IA32, PcdsFeatureFlag.ARM, PcdsFeatureFlag.AARCH64, P= cdsFeatureFlag.LOONGARCH64] > > gEfiMdeModulePkgTokenSpaceGuid.PcdPciDegradeResourceForOptionRom|FALSE|= BOOLEAN|0x0001003a > > > > > > [PcdsFeatureFlag.IA32, PcdsFeatureFlag.X64] > > -- > > 2.36.1.windows.1 > > > > > > > > - - - - - - > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#96470): https://edk2.groups.io/g/devel/message/9647= 0 > > Mute This Topic: https://groups.io/mt/95087855/6496846 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub [lichao@loongson.cn] > > - - - - - - > > > >=20 --637b1d44_45f987fb_2a03 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline
Hi Liming, Jian and Ray,
Please help to review this change, = thanks!


Thanks,
Chao
--------

On 11=E6=9C=88 17 2022, at= 7:59 =E6=99=9A=E4=B8=8A, "Chao Li" <lichao@loongson.cn> wrote:
=
Reviewed-by: Chao Li <lichao@loongson.cn>

<= div>

Thanks,
Chao
--------

On 11=E6=9C=88 17 2022, at 4:47 =E4=B8= =8B=E5=8D=88, "Dongyan Qian" <qiandongyan@loongson.cn> wrote:
LoongArch64: Pcie devices that come with OPROM may requ= ire large Mem Space,
and downgrading all 64 Bit Bars may result i= n insufficient space.

REF:https://bugzilla.tianocore.org/show= _bug.cgi?id=3D4157

Cc: Jian J Wang <jian.j.wang@intel.com&= gt;
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc:= Ray Ni <ray.ni@intel.com>
Cc: Chao Li <lichao@loongson.= cn>
Signed-off-by: Dongyan Qian <qiandongyan@loongson.cn>= ;
Co-authored-by: Bo Zhu <zhubo@loongson.cn>
---<= /div>
MdeModulePkg/MdeModulePkg.dec | 2 +-
1 file changed, 1 = insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/MdeModu= lePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index 58e6ab0048..be5e8= 29ca9 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/= MdeModulePkg/MdeModulePkg.dec
@@ -917,7 +917,7 @@
# @Pr= ompt Enable process non-reset capsule image at runtime.

gEfiM= deModulePkgTokenSpaceGuid.PcdSupportProcessCapsuleAtRuntime|FALSE|BOOLEAN|0= x00010079



-[PcdsFeatureFlag.IA32, PcdsFeatureFlag.ARM= , PcdsFeatureFlag.AARCH64]

+[PcdsFeatureFlag.IA32, PcdsFeatur= eFlag.ARM, PcdsFeatureFlag.AARCH64, PcdsFeatureFlag.LOONGARCH64]

<= div>gEfiMdeModulePkgTokenSpaceGuid.PcdPciDegradeResourceForOptionRom|FALSE|= BOOLEAN|0x0001003a



[PcdsFeatureFlag.IA32, PcdsFeature= Flag.X64]

--
2.36.1.windows.1



- - - - - -
Groups.io Links: You receive all messages sent to th= is group.
View/Reply Online (#96470): https://edk2.groups.io/g/de= vel/message/96470
Mute This Topic: https://groups.io/mt/95087855/= 6496846
Group Owner: devel+owner@edk2.groups.io
Unsubsc= ribe: https://edk2.groups.io/g/devel/unsub [lichao@loongson.cn]
-= - - - - -
--637b1d44_45f987fb_2a03--