Re: [edk2-devel] [PATCH] MdeModulePkg: Disable PciDegrade support for LoongArch64

Re: [edk2-devel] [PATCH] MdeModulePkg: Disable PciDegrade support for LoongArch64

[Chao Li]

[-- Attachment #1: Type: text/plain, Size: 2093 bytes --]

Hi Liming, Jian and Ray,
Please help to review this change, thanks!

Thanks,
Chao
--------

On 11月 17 2022, at 7:59 晚上, "Chao Li" <lichao@loongson.cn> wrote:
> Reviewed-by: Chao Li <lichao@loongson.cn>
>
>
> Thanks,
> Chao
> --------
>
> On 11月 17 2022, at 4:47 下午, "Dongyan Qian" <qiandongyan@loongson.cn> wrote:
> > LoongArch64: Pcie devices that come with OPROM may require large Mem Space,
> > and downgrading all 64 Bit Bars may result in insufficient space.
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4157
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Chao Li <lichao@loongson.cn>
> > Signed-off-by: Dongyan Qian <qiandongyan@loongson.cn>
> > Co-authored-by: Bo Zhu <zhubo@loongson.cn>
> > ---
> > MdeModulePkg/MdeModulePkg.dec | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
> > index 58e6ab0048..be5e829ca9 100644
> > --- a/MdeModulePkg/MdeModulePkg.dec
> > +++ b/MdeModulePkg/MdeModulePkg.dec
> > @@ -917,7 +917,7 @@
> > # @Prompt Enable process non-reset capsule image at runtime.
> >
> > gEfiMdeModulePkgTokenSpaceGuid.PcdSupportProcessCapsuleAtRuntime|FALSE|BOOLEAN|0x00010079
> >
> >
> > -[PcdsFeatureFlag.IA32, PcdsFeatureFlag.ARM, PcdsFeatureFlag.AARCH64]
> > +[PcdsFeatureFlag.IA32, PcdsFeatureFlag.ARM, PcdsFeatureFlag.AARCH64, PcdsFeatureFlag.LOONGARCH64]
> > gEfiMdeModulePkgTokenSpaceGuid.PcdPciDegradeResourceForOptionRom|FALSE|BOOLEAN|0x0001003a
> >
> >
> > [PcdsFeatureFlag.IA32, PcdsFeatureFlag.X64]
> > --
> > 2.36.1.windows.1
> >
> >
> >
> > - - - - - -
> > Groups.io Links: You receive all messages sent to this group.
> > View/Reply Online (#96470): https://edk2.groups.io/g/devel/message/96470
> > Mute This Topic: https://groups.io/mt/95087855/6496846
> > Group Owner: devel+owner@edk2.groups.io
> > Unsubscribe: https://edk2.groups.io/g/devel/unsub [lichao@loongson.cn]
> > - - - - - -
> >
>
> 

[-- Attachment #2: Type: text/html, Size: 2852 bytes --]

回复: [edk2-devel] [PATCH] MdeModulePkg: Disable PciDegrade support for LoongArch64

[gaoliming]

[-- Attachment #1: Type: text/plain, Size: 2924 bytes --]

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

 

发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Chao Li
发送时间: 2022年11月21日 14:40
收件人: devel@edk2.groups.io; lichao@loongson.cn
抄送: " devel@edk2.groups.io " <devel@edk2.groups.io>; " qiandongyan@loongson.cn " <qiandongyan@loongson.cn>; Jian J Wang <jian.j.wang@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>; Ray Ni <ray.ni@intel.com>; Bo Zhu <zhubo@loongson.cn>
主题: Re: [edk2-devel] [PATCH] MdeModulePkg: Disable PciDegrade support for LoongArch64

 

Hi Liming, Jian and Ray,

Please help to review this change, thanks!

 


Thanks,
Chao
--------

On 11月 17 2022, at 7:59 晚上, "Chao Li" <lichao@loongson.cn <mailto:lichao@loongson.cn> > wrote:

Reviewed-by: Chao Li <lichao@loongson.cn <mailto:lichao@loongson.cn> >

 

 

Thanks,

Chao

--------

 

On 11月 17 2022, at 4:47 下午, "Dongyan Qian" <qiandongyan@loongson.cn <mailto:qiandongyan@loongson.cn> > wrote:

LoongArch64: Pcie devices that come with OPROM may require large Mem Space,

and downgrading all 64 Bit Bars may result in insufficient space.

 

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4157

 

Cc: Jian J Wang <jian.j.wang@intel.com <mailto:jian.j.wang@intel.com> >

Cc: Liming Gao <gaoliming@byosoft.com.cn <mailto:gaoliming@byosoft.com.cn> >

Cc: Ray Ni <ray.ni@intel.com <mailto:ray.ni@intel.com> >

Cc: Chao Li <lichao@loongson.cn <mailto:lichao@loongson.cn> >

Signed-off-by: Dongyan Qian <qiandongyan@loongson.cn <mailto:qiandongyan@loongson.cn> >

Co-authored-by: Bo Zhu <zhubo@loongson.cn <mailto:zhubo@loongson.cn> >

---

MdeModulePkg/MdeModulePkg.dec | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

 

diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec

index 58e6ab0048..be5e829ca9 100644

--- a/MdeModulePkg/MdeModulePkg.dec

+++ b/MdeModulePkg/MdeModulePkg.dec

@@ -917,7 +917,7 @@

# @Prompt Enable process non-reset capsule image at runtime.

 

gEfiMdeModulePkgTokenSpaceGuid.PcdSupportProcessCapsuleAtRuntime|FALSE|BOOLEAN|0x00010079





-[PcdsFeatureFlag.IA32, PcdsFeatureFlag.ARM, PcdsFeatureFlag.AARCH64]

 

+[PcdsFeatureFlag.IA32, PcdsFeatureFlag.ARM, PcdsFeatureFlag.AARCH64, PcdsFeatureFlag.LOONGARCH64]

 

gEfiMdeModulePkgTokenSpaceGuid.PcdPciDegradeResourceForOptionRom|FALSE|BOOLEAN|0x0001003a





[PcdsFeatureFlag.IA32, PcdsFeatureFlag.X64]

 

--

2.36.1.windows.1





- - - - - -

Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#96470): https://edk2.groups.io/g/devel/message/96470

Mute This Topic: https://groups.io/mt/95087855/6496846

Group Owner: devel+owner@edk2.groups.io <mailto:devel+owner@edk2.groups.io> 

Unsubscribe: https://edk2.groups.io/g/devel/unsub [lichao@loongson.cn]

- - - - - -




[-- Attachment #2: Type: text/html, Size: 10469 bytes --]

[PATCH] MdeModulePkg: Disable PciDegrade support for LoongArch64

[Dongyan Qian]

LoongArch64: Pcie devices that come with OPROM may require large Mem Space,
and downgrading all 64 Bit Bars may result in insufficient space.

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4157

Cc: Jian J Wang <jian.j.wang@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Chao Li <lichao@loongson.cn>
Signed-off-by: Dongyan Qian <qiandongyan@loongson.cn>
Co-authored-by: Bo Zhu <zhubo@loongson.cn>
---
 MdeModulePkg/MdeModulePkg.dec | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index 58e6ab0048..be5e829ca9 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -917,7 +917,7 @@
   # @Prompt Enable process non-reset capsule image at runtime.
   gEfiMdeModulePkgTokenSpaceGuid.PcdSupportProcessCapsuleAtRuntime|FALSE|BOOLEAN|0x00010079
 
-[PcdsFeatureFlag.IA32, PcdsFeatureFlag.ARM, PcdsFeatureFlag.AARCH64]
+[PcdsFeatureFlag.IA32, PcdsFeatureFlag.ARM, PcdsFeatureFlag.AARCH64, PcdsFeatureFlag.LOONGARCH64]
   gEfiMdeModulePkgTokenSpaceGuid.PcdPciDegradeResourceForOptionRom|FALSE|BOOLEAN|0x0001003a
 
 [PcdsFeatureFlag.IA32, PcdsFeatureFlag.X64]
-- 
2.36.1.windows.1

Re: [edk2-devel] [PATCH] MdeModulePkg: Disable PciDegrade support for LoongArch64

[Chao Li]

[-- Attachment #1: Type: text/plain, Size: 1815 bytes --]

Reviewed-by: Chao Li <lichao@loongson.cn>

Thanks,
Chao
--------

On 11月 17 2022, at 4:47 下午, "Dongyan Qian" <qiandongyan@loongson.cn> wrote:
> LoongArch64: Pcie devices that come with OPROM may require large Mem Space,
> and downgrading all 64 Bit Bars may result in insufficient space.
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4157
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Chao Li <lichao@loongson.cn>
> Signed-off-by: Dongyan Qian <qiandongyan@loongson.cn>
> Co-authored-by: Bo Zhu <zhubo@loongson.cn>
> ---
> MdeModulePkg/MdeModulePkg.dec | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
> index 58e6ab0048..be5e829ca9 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -917,7 +917,7 @@
> # @Prompt Enable process non-reset capsule image at runtime.
>
> gEfiMdeModulePkgTokenSpaceGuid.PcdSupportProcessCapsuleAtRuntime|FALSE|BOOLEAN|0x00010079
>
>
> -[PcdsFeatureFlag.IA32, PcdsFeatureFlag.ARM, PcdsFeatureFlag.AARCH64]
> +[PcdsFeatureFlag.IA32, PcdsFeatureFlag.ARM, PcdsFeatureFlag.AARCH64, PcdsFeatureFlag.LOONGARCH64]
> gEfiMdeModulePkgTokenSpaceGuid.PcdPciDegradeResourceForOptionRom|FALSE|BOOLEAN|0x0001003a
>
>
> [PcdsFeatureFlag.IA32, PcdsFeatureFlag.X64]
> --
> 2.36.1.windows.1
>
>
>
> - - - - - -
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#96470): https://edk2.groups.io/g/devel/message/96470
> Mute This Topic: https://groups.io/mt/95087855/6496846
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [lichao@loongson.cn]
> - - - - - -
>


[-- Attachment #2: Type: text/html, Size: 2318 bytes --]