Re: [edk2-devel] [PATCH v4 2/3] Platform/ARM: Juno: Generate _PSD objects

["Sami Mujawar" <sami.mujawar@arm.com>]

Hi Pierre,

Please see my response inline marked [SAMI].

Regards,

Sami Mujawar

On 25/01/2024, 12:48, "Pierre Gondois" <pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>> wrote:


Hello Sami,


On 1/25/24 12:31, Sami Mujawar wrote:
> Hi Pierre,
> 
> Thank you for this patch.
> I just have a minor suggestion marked inline as [SAMI].
> Otherwise, this patch looks good to me.
> With that addressed,
> Reviewed-by: Sami Mujawar <sami.mujawar@arm.com <mailto:sami.mujawar@arm.com>>
> 
> Regards,
> 
> Sami Mujawar
> 
> On 12/12/2023, 09:31, "Pierre.Gondois@arm.com <mailto:Pierre.Gondois@arm.com> <mailto:Pierre.Gondois@arm.com <mailto:Pierre.Gondois@arm.com>>" <Pierre.Gondois@arm.com <mailto:Pierre.Gondois@arm.com> <mailto:Pierre.Gondois@arm.com <mailto:Pierre.Gondois@arm.com>>> wrote:
> 
> 
> From: Pierre Gondois <pierre.gondois@arm.com <mailto:pierre.gondois@arm.com> <mailto:pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>>>
> 
> 
> The SsdtCpuTopologyGenerator can generate _PSD objects.
> Add _PSD information and handling to the Configuration Manager
> to generate them.
> 
> 
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com <mailto:pierre.gondois@arm.com> <mailto:pierre.gondois@arm.com <mailto:pierre.gondois@arm.com>>>
> ---
> .../ConfigurationManager.c | 98 +++++++++++++++++--
> .../ConfigurationManager.h | 24 ++++-
> 2 files changed, 113 insertions(+), 9 deletions(-)
> 
> 


[snip]


> @@ -283,6 +300,9 @@ typedef struct PlatformRepositoryInfo {
> // Cores Low Power Idle state references (LPI)
> CM_ARM_OBJ_REF CoresLpiRef[CORES_LPI_STATE_COUNT];
> 
> 
> + // Power domains
> [SAMI] The comment could also say that this information is dynamically populated by the configuration manager.


I think the _PSD info is statically defined, only the _CPC information
is dynamically populated.
[SAMI] My mistake, please disregard this.
No change needed in that case.
My r-b stands as it is.
[/SAMI]


> + CM_ARM_PSD_INFO PsdInfo[PSD_DOMAIN_COUNT];
> +
> /// Juno Board Revision
> UINT32 JunoRevision;
> } EDKII_PLATFORM_REPOSITORY_INFO;
> --
> 2.25.1
> 
> 
> 
> 
> 




Regards,
Pierre





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114406): https://edk2.groups.io/g/devel/message/114406
Mute This Topic: https://groups.io/mt/103127067/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-