public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Andrew Fish <afish@apple.com>
To: Jordan Justen <jordan.l.justen@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	edk2-devel-01 <edk2-devel@lists.01.org>,
	Mike Kinney <michael.d.kinney@intel.com>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	Laszlo Ersek <lersek@redhat.com>,
	"Gao, Liming" <liming.gao@intel.com>
Subject: Re: [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files
Date: Fri, 21 Oct 2016 13:20:49 -0700	[thread overview]
Message-ID: <E4DB9757-BFD0-4CA8-AE7F-6A4EC8D8D0B1@apple.com> (raw)
In-Reply-To: <147707992484.13791.10042868456965197315@jljusten-ivb>


> On Oct 21, 2016, at 12:58 PM, Jordan Justen <jordan.l.justen@intel.com> wrote:
> 
> On 2016-10-21 12:37:21, Ard Biesheuvel wrote:
>> I don't remember seeing any discussion regarding
>> DISABLE_NEW_DEPRECATED_INTERFACES on the list, so I am a bit surprised
>> seeing these bugs being filed and assigned.
>> 
> 
> I agree.
> 
> Also, the terminology seems confusing. 'new deprecated' seems like a
> contradiction. I guess it means 'newly deprecated', but that seems
> like a term that is quickly going to become obsolete. Soon there will
> be old deprecated items that are disabled with this switch.
> DISABLE_DEPRECATED_INTERFACES sounds better.
> 
> But, shouldn't we have platforms opt-in to using the deprecated
> interfaces rather than adding DISABLE_NEW_DEPRECATED_INTERFACES to the
> build command line for every EDK II platform?
> 
> Not using deprecated items should be the default for EDK II platforms.
> If a platform has to opt-in to the deprecated content in their .dsc,
> then it is obvious that they are relying on deprecated functionality.
> 
> So, I guess I'd propose adding ENABLE_DEPRECATED_INTERFACES instead.
> 

Jordan,

I think it depends on your point of view. If you have a platform that works and you update the edk2 revision you would expect it to still work. Thus the option is to DISABLE_DEPRECATED_INTERFACES as that maintains backward compatibility. 

I think it makes total sense to turn on DISABLE_DEPRECATED_INTERFACES on all the open source edk2 platform as soon as possible so all the open source code is following current best practices.

Not to mention it would probably be a really good idea to give all the downstream folks a long lead time about the plan of making a non backward compatible change. 

Thanks,

Andrew Fish


> -Jordan
> 
>> Before making any such changes, I would like a strong commitment from
>> other package owners that deprecating an interface brings along with
>> it the responsibility to update all existing callers, otherwise
>> setting this define will only result in more breakage, and ARM has
>> seen its share of inadvertent breakage in the past when changes to
>> core code were made without taking other architectures into account.
>> 
>> On 21 October 2016 at 02:21,  <bugzilla-daemon@bugzilla.tianocore.org> wrote:
>>> https://bugzilla.tianocore.org/show_bug.cgi?id=164
>>> 
>>> yonghong.zhu@intel.com changed:
>>> 
>>>           What    |Removed                     |Added
>>> ----------------------------------------------------------------------------
>>>           Priority|Lowest                      |Normal
>>>             Status|UNCONFIRMED                 |CONFIRMED
>>>           Assignee|michael.d.kinney@intel.com  |ard.biesheuvel@linaro.org
>>>     Ever confirmed|0                           |1
>>>     Release(s) the|                            |EDK II Trunk
>>>     issues must be|                            |
>>>              fixed|                            |
>>> 
>>> --- Comment #1 from yonghong.zhu@intel.com ---
>>> Assign to Package owner.
>>> 
>>> --
>>> You are receiving this mail because:
>>> You are the assignee for the bug.
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org <mailto:edk2-devel@lists.01.org>
>> https://lists.01.org/mailman/listinfo/edk2-devel <https://lists.01.org/mailman/listinfo/edk2-devel>


  parent reply	other threads:[~2016-10-21 20:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-164-63@https.bugzilla.tianocore.org/>
     [not found] ` <bug-164-63-L8k0GFC2io@https.bugzilla.tianocore.org/>
2016-10-21 19:37   ` [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files Ard Biesheuvel
2016-10-21 19:41     ` Michael Zimmermann
2016-10-21 19:58     ` Jordan Justen
2016-10-21 20:14       ` Laszlo Ersek
2016-10-21 20:19         ` Ard Biesheuvel
2016-10-21 20:40           ` Laszlo Ersek
2016-10-21 20:57             ` Ard Biesheuvel
2016-10-21 20:20       ` Andrew Fish [this message]
2016-10-21 20:39         ` Jordan Justen
2016-10-21 20:54           ` Andrew Fish
2016-10-21 20:55             ` Andrew Fish
2016-10-21 21:02           ` Laszlo Ersek
2016-10-21 22:10             ` Jordan Justen
2016-10-21 22:31               ` Laszlo Ersek
2016-10-21 23:13                 ` Yao, Jiewen
2016-10-23 14:28                   ` Mudusuru, Giri P

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E4DB9757-BFD0-4CA8-AE7F-6A4EC8D8D0B1@apple.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox