From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in22.apple.com (mail-out22.apple.com [17.171.2.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 03B8F1A1E28 for ; Fri, 21 Oct 2016 13:20:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1477081254; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-reply-to:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=CqaieI5JUKFfV+lDwLDEddhZ7hg3MTR9LMH4/2U0OFI=; b=aAtxCk5nBjF/0sNrNF4d20e/aF+XThDErNQ8wxlkwDFZLfbVTHagFxPqRj2jtD4j SiPZz588nJNa74ofbNzG3EOhBekDRABmrckqPKEp/xp6S4wPGXM0QnjSCRfpZkgH QQe+ZeFy4aox0URDUALXBy9c490hsckB7cQSqfIBFdqlyUHV96LITHG3ss/DD286 CgWehDFvua+AUKpccOfOg/ruswl1tDuNhQdE/Y8/Pq8BQZgTFNKUU+UupI1pRxqA ffIkTQti96Ap3SZyYoC7wHw2k5mzu2wKCoTEon879e9LpGLNKf7Sxsdun8FjJXxn LwsnGXvhJX/joQnIYWqS0A==; Received: from relay25.apple.com (relay25.apple.com [17.171.128.106]) by mail-in22.apple.com (Apple Secure Mail Relay) with SMTP id 4C.39.07187.5A87A085; Fri, 21 Oct 2016 16:20:53 -0400 (EDT) X-AuditID: 11ab0216-f2ffb70000001c13-2b-580a78a5c056 Received: from ma1-mmpp-sz10.apple.com (ma1-mmpp-sz10.apple.com [17.171.128.150]) by relay25.apple.com (Apple SCV relay) with SMTP id 43.FE.24919.4A87A085; Fri, 21 Oct 2016 16:20:52 -0400 (EDT) MIME-version: 1.0 Received: from [17.168.156.82] by ma1-mmpp-sz10.apple.com (Oracle Communications Messaging Server 8.0.1.1.0 64bit (built Jun 15 2016)) with ESMTPSA id <0OFE00L34Z6PL280@ma1-mmpp-sz10.apple.com>; Fri, 21 Oct 2016 13:20:52 -0700 (PDT) Sender: afish@apple.com From: Andrew Fish Message-id: Date: Fri, 21 Oct 2016 13:20:49 -0700 In-reply-to: <147707992484.13791.10042868456965197315@jljusten-ivb> Cc: Ard Biesheuvel , edk2-devel-01 , Mike Kinney , Leif Lindholm , Laszlo Ersek , "Gao, Liming" To: Jordan Justen References: <147707992484.13791.10042868456965197315@jljusten-ivb> X-Mailer: Apple Mail (2.3226) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJLMWRmVeSWpSXmKPExsUiuLohS3dZBVeEwVIDi/8fdjNa7Dl0lNli x7V+FotPu/ewWCw7toPFYsW9DewWHR3/mBzYPRbvecnkcefaHjaP7tn/WDze77vKFsASxWWT kpqTWZZapG+XwJWxY/NKloL3OxkrvpycxtbAOGURYxcjB4eEgInEouOyXYxcHEICBxkleudM AopzgsWvXu1ghkgcZpR40PSOCSTBKyAo8WPyPRYQm1kgTOJH7zs2iKJ3jBJLrhwC6xYWEJd4 d2YTM4jNJqAssWL+B3aIZhuJg13rmSFqCiS+bXgFNpRFQFViwZGLYL2cAs4Ss7/NAdvMLPCb UeL+pLlgDSICuhJ9y/+wwG27/2gXM8QPshKzf3mBxCUE7rNJPLy4j3UCo9AsJNfOQnIthK0l 8f1RK1CcA8iWlzh4XhYirCnx7N4ndghbW+LJuwusCxjZVjEK5yZm5uhm5hkZ6SUWFOSk6iXn 525iBMcVk9gOxnuvDQ8xCnAwKvHwMohxRQixJpYVV+YeYpTmYFES53VYyRYhJJCeWJKanZpa kFoUX1Sak1p8iJGJg1OqgbFoIu+EAtabO4tWhT+e6vt29nPG62xqh0KiL//f4TWHZ2n8GROf 99qPP7y4nG3yr1G33HUry+SlGrklP9iWLGr5sEt1A9exZuNr0jc9v16uFf+1vdGi++KE+wwq k26955l97Y/kvd2ZDWu0Jgod0xbi171yk8vb7NEBzaUnG+YKyblnxr4/W+inxFKckWioxVxU nAgACQKtP4wCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrFLMWRmVeSWpSXmKPExsUiuLphmu6SCq4IgxUt1hb/P+xmtNhz6Ciz xY5r/SwWn3bvYbFYdmwHi8WKexvYLTo6/jE5sHss3vOSyePOtT1sHt2z/7F4vN93lS2AJYrL JiU1J7MstUjfLoErY8fmlSwF73cyVnw5OY2tgXHKIsYuRk4OCQETiatXO5ghbDGJC/fWs3Ux cnEICRxmlHjQ9I4JJMErICjxY/I9FhCbWSBM4kfvO6iid4wSS64cApskLCAu8e7MJrBJbALK Eivmf2CHaLaRONi1nhmipkDi24ZXYENZBFQlFhy5CNbLKeAsMfvbHGaQocwCvxkl7k+aC9Yg IqAr0bf8DwvctvuPdgElOIBulZWY/ctrAqPALCQHzkJyIIStJfH9UStQnAPIlpc4eF4WIqwp 8ezeJ3YIW1viybsLrAsY2VYxChal5iRWGpnqJRYU5KTqJefnbmKExEjWDsbbN80OMQpwMCrx 8FZncUUIsSaWFVfmHmKU4GBWEuGdsoE9Qog3JbGyKrUoP76oNCe1+BCjNAeLkjivWiFQtUB6 YklqdmpqQWoRTJaJg1OqgXHJ8g3V4TfvH1vs+GmjU2/Mh1OL2iQCRRPiGSZqJWr/MOp4L6Xy i2ki5+foU9MWPP/vcyKPfSZn+CqX89Pe7/l/YTGzmuXtvvpldVt3ZFjMOHijI01njfUjlnW2 jx5siwk6O9c+Jd2PYzHf1PWeXl0brrK+T5dgnZ13Tzdn6uk3d423PuLSWy6txFKckWioxVxU nAgAmfzUgI0CAAA= X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2016 20:20:55 -0000 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT > On Oct 21, 2016, at 12:58 PM, Jordan Justen wrote: > > On 2016-10-21 12:37:21, Ard Biesheuvel wrote: >> I don't remember seeing any discussion regarding >> DISABLE_NEW_DEPRECATED_INTERFACES on the list, so I am a bit surprised >> seeing these bugs being filed and assigned. >> > > I agree. > > Also, the terminology seems confusing. 'new deprecated' seems like a > contradiction. I guess it means 'newly deprecated', but that seems > like a term that is quickly going to become obsolete. Soon there will > be old deprecated items that are disabled with this switch. > DISABLE_DEPRECATED_INTERFACES sounds better. > > But, shouldn't we have platforms opt-in to using the deprecated > interfaces rather than adding DISABLE_NEW_DEPRECATED_INTERFACES to the > build command line for every EDK II platform? > > Not using deprecated items should be the default for EDK II platforms. > If a platform has to opt-in to the deprecated content in their .dsc, > then it is obvious that they are relying on deprecated functionality. > > So, I guess I'd propose adding ENABLE_DEPRECATED_INTERFACES instead. > Jordan, I think it depends on your point of view. If you have a platform that works and you update the edk2 revision you would expect it to still work. Thus the option is to DISABLE_DEPRECATED_INTERFACES as that maintains backward compatibility. I think it makes total sense to turn on DISABLE_DEPRECATED_INTERFACES on all the open source edk2 platform as soon as possible so all the open source code is following current best practices. Not to mention it would probably be a really good idea to give all the downstream folks a long lead time about the plan of making a non backward compatible change. Thanks, Andrew Fish > -Jordan > >> Before making any such changes, I would like a strong commitment from >> other package owners that deprecating an interface brings along with >> it the responsibility to update all existing callers, otherwise >> setting this define will only result in more breakage, and ARM has >> seen its share of inadvertent breakage in the past when changes to >> core code were made without taking other architectures into account. >> >> On 21 October 2016 at 02:21, wrote: >>> https://bugzilla.tianocore.org/show_bug.cgi?id=164 >>> >>> yonghong.zhu@intel.com changed: >>> >>> What |Removed |Added >>> ---------------------------------------------------------------------------- >>> Priority|Lowest |Normal >>> Status|UNCONFIRMED |CONFIRMED >>> Assignee|michael.d.kinney@intel.com |ard.biesheuvel@linaro.org >>> Ever confirmed|0 |1 >>> Release(s) the| |EDK II Trunk >>> issues must be| | >>> fixed| | >>> >>> --- Comment #1 from yonghong.zhu@intel.com --- >>> Assign to Package owner. >>> >>> -- >>> You are receiving this mail because: >>> You are the assignee for the bug. >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel