From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 917261A1E2A for ; Fri, 7 Oct 2016 12:08:39 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 07 Oct 2016 12:08:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,456,1473145200"; d="scan'208";a="1041789329" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga001.jf.intel.com with ESMTP; 07 Oct 2016 12:08:39 -0700 Received: from orsmsx159.amr.corp.intel.com (10.22.240.24) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 7 Oct 2016 12:08:38 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.240]) by ORSMSX159.amr.corp.intel.com ([10.22.240.24]) with mapi id 14.03.0248.002; Fri, 7 Oct 2016 12:08:38 -0700 From: "Steele, Kelly" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" Thread-Topic: [Patch 0/2] QuarkSocPkg/QncSmmDispatcher: Fix SMI Handler ASSERTs() Thread-Index: AQHSHzZUxgRyhQrlqkOPjF/5Fxk97KCdXe6Q Date: Fri, 7 Oct 2016 19:08:37 +0000 Message-ID: References: <1475692130-20756-1-git-send-email-michael.d.kinney@intel.com> In-Reply-To: <1475692130-20756-1-git-send-email-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTY1NzAzOWYtMTA5ZC00MGU1LWJkNTctYjEyOTgzZjNiMjlhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjRDVkV0UHdtNHZXMVUrNWg1UDM5UzFXYlNWMUZvdUFoVDhpRHVrUGdoXC9VPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Subject: Re: [Patch 0/2] QuarkSocPkg/QncSmmDispatcher: Fix SMI Handler ASSERTs() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2016 19:08:39 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Kelly Steele > -----Original Message----- > From: Kinney, Michael D > Sent: October 05, 2016 11:29 > To: edk2-devel@lists.01.org > Cc: Steele, Kelly > Subject: [Patch 0/2] QuarkSocPkg/QncSmmDispatcher: Fix SMI Handler > ASSERTs() >=20 > This series fixes the following two issues: >=20 > QuarkSocPkg QncSmmDispatcher passes incorrect context to SMI handler > https://bugzilla.tianocore.org/show_bug.cgi?id=3D136 >=20 > QuarkSockg Use after free in QNCSmmCoreDispatcher > https://bugzilla.tianocore.org/show_bug.cgi?id=3D51 >=20 > These issues can be reproduced using the unit test available in the follo= wing > branch that registers a periodic SMI that is triggered every 8 seconds an= d > unregisters itself after the periodic SMI handler has been triggered 4 ti= mes. >=20 > https://github.com/mdkinney/edk2/tree/Bug51/Reproduce >=20 > Cc: Kelly Steele > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Michael Kinney >=20 > Michael Kinney (2): > QuarkSocPkg/QncSmmDispatcher: Fix context passed to SMI handlers > QuarkSocPkg/QncSmmDispatcher: Fix use after free issue >=20 > .../QncSmmDispatcher/QNC/QNCSmmPeriodicTimer.c | 4 +- > .../Smm/DxeSmm/QncSmmDispatcher/QNCSmm.h | 9 ++-- > .../Smm/DxeSmm/QncSmmDispatcher/QNCSmmCore.c | 51 > +++++++++++++++++----- > 3 files changed, 49 insertions(+), 15 deletions(-) >=20 > -- > 2.6.3.windows.1