public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Steele, Kelly" <kelly.steele@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"'edk2-devel@lists.01.org'" <edk2-devel@lists.01.org>
Subject: Re: [Patch 0/5] QuarkPlatformPkg: Fix BOOT_IN_RECOVERY_MODE issues
Date: Fri, 7 Oct 2016 21:02:44 +0000	[thread overview]
Message-ID: <E6EF8131FBAF5A44BF17D9E2B45E207508BABE12@ORSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <E6EF8131FBAF5A44BF17D9E2B45E207508BABD0C@ORSMSX114.amr.corp.intel.com>

Entire patch reviewed. Looks good to me.

Reviewed-by: Kelly Steele <kelly.steele@intel.com>

> -----Original Message-----
> From: Steele, Kelly
> Sent: October 07, 2016 12:27
> To: Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel@lists.01.org
> Subject: RE: [Patch 0/5] QuarkPlatformPkg: Fix BOOT_IN_RECOVERY_MODE
> issues
> 
> 
> 
> Reviewed-by: Kelly Steele <kelly.steele@intel.com>
> 
> 
> 
> 
> > -----Original Message-----
> > From: Kinney, Michael D
> > Sent: October 06, 2016 12:12
> > To: edk2-devel@lists.01.org
> > Cc: Steele, Kelly <kelly.steele@intel.com>
> > Subject: [Patch 0/5] QuarkPlatformPkg: Fix BOOT_IN_RECOVERY_MODE issues
> >
> > This patch series addresses the following 3 issues in Bugzilla:
> >
> > https://bugzilla.tianocore.org/show_bug.cgi?id=137
> > https://bugzilla.tianocore.org/show_bug.cgi?id=138
> > https://bugzilla.tianocore.org/show_bug.cgi?id=139
> >
> > It also removes a function and library that are no longer used.
> >
> > Cc: Kelly Steele <kelly.steele@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Michael Kinney <michael.d.kinney@intel.com>
> >
> > Michael Kinney (5):
> >   QuarkPlatformPkg/ForceRecovery: Add UEFI application to force recovery
> >   QuarkPlatformPkg/PlatformInit: Fix recovery detection issues
> >   QuarkPlatformPkg/PlatformHelperLib: Remove
> PlatformDebugPortGetChar8()
> >   QuarkPlatformPkg: Add ForceRecovery UEFI application
> >   QuarkPlatformPkg/RecoveryOemHookLib: Remove RecoveryOemHookLib
> >
> >  .../Application/ForceRecovery/ForceRecovery.c      |  53 ++++++++++
> >  .../Application/ForceRecovery/ForceRecovery.inf    |  39 +++++++
> >  .../Include/Library/PlatformHelperLib.h            |  16 +--
> >  .../Include/Library/RecoveryOemHookLib.h           |  45 ---------
> >  .../Library/PlatformHelperLib/PlatformHelperLib.c  |  27 -----
> >  .../Library/RecoveryOemHookLib/CommonHeader.h      |  30 ------
> >  .../RecoveryOemHookLib/RecoveryOemHookLib.c        |  61 -----------
> >  .../RecoveryOemHookLib/RecoveryOemHookLib.inf      |  49 ---------
> >  .../Platform/Pei/PlatformInit/BootMode.c           |  89 ++++++----------
> >  .../Platform/Pei/PlatformInit/CommonHeader.h       |   4 +-
> >  .../Platform/Pei/PlatformInit/MrcWrapper.c         | 112 +--------------------
> >  .../Platform/Pei/PlatformInit/MrcWrapper.h         |  11 +-
> >  .../Platform/Pei/PlatformInit/PlatformEarlyInit.c  |  67 +++++++++++-
> >  .../Pei/PlatformInit/PlatformEarlyInit.inf         |   1 -
> >  QuarkPlatformPkg/Quark.dsc                         |   6 +-
> >  QuarkPlatformPkg/QuarkMin.dsc                      |   1 -
> >  16 files changed, 196 insertions(+), 415 deletions(-)
> >  create mode 100644
> > QuarkPlatformPkg/Application/ForceRecovery/ForceRecovery.c
> >  create mode 100644
> > QuarkPlatformPkg/Application/ForceRecovery/ForceRecovery.inf
> >  delete mode 100644
> > QuarkPlatformPkg/Include/Library/RecoveryOemHookLib.h
> >  delete mode 100644
> > QuarkPlatformPkg/Library/RecoveryOemHookLib/CommonHeader.h
> >  delete mode 100644
> > QuarkPlatformPkg/Library/RecoveryOemHookLib/RecoveryOemHookLib.c
> >  delete mode 100644
> > QuarkPlatformPkg/Library/RecoveryOemHookLib/RecoveryOemHookLib.inf
> >
> > --
> > 2.6.3.windows.1



      reply	other threads:[~2016-10-07 21:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-06 19:12 [Patch 0/5] QuarkPlatformPkg: Fix BOOT_IN_RECOVERY_MODE issues Michael Kinney
2016-10-06 19:12 ` [Patch 1/5] QuarkPlatformPkg/ForceRecovery: Add UEFI application to force recovery Michael Kinney
2016-10-06 19:12 ` [Patch 2/5] QuarkPlatformPkg/PlatformInit: Fix recovery detection issues Michael Kinney
2016-10-06 19:12 ` [Patch 3/5] QuarkPlatformPkg/PlatformHelperLib: Remove PlatformDebugPortGetChar8() Michael Kinney
2016-10-06 19:12 ` [Patch 4/5] QuarkPlatformPkg: Add ForceRecovery UEFI application Michael Kinney
2016-10-06 19:12 ` [Patch 5/5] QuarkPlatformPkg/RecoveryOemHookLib: Remove RecoveryOemHookLib Michael Kinney
2016-10-07 19:26 ` [Patch 0/5] QuarkPlatformPkg: Fix BOOT_IN_RECOVERY_MODE issues Steele, Kelly
2016-10-07 21:02   ` Steele, Kelly [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E6EF8131FBAF5A44BF17D9E2B45E207508BABE12@ORSMSX114.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox