From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 12FA81A1E72 for ; Fri, 7 Oct 2016 14:02:46 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP; 07 Oct 2016 14:02:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,456,1473145200"; d="scan'208";a="17366121" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by fmsmga006.fm.intel.com with ESMTP; 07 Oct 2016 14:02:45 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.240]) by ORSMSX103.amr.corp.intel.com ([169.254.5.152]) with mapi id 14.03.0248.002; Fri, 7 Oct 2016 14:02:45 -0700 From: "Steele, Kelly" To: "Kinney, Michael D" , "'edk2-devel@lists.01.org'" Thread-Topic: [Patch 0/5] QuarkPlatformPkg: Fix BOOT_IN_RECOVERY_MODE issues Thread-Index: AQHSIAb5NKqxi/A3T0yrzCvD2m39baCdYWjwgAAa0eA= Date: Fri, 7 Oct 2016 21:02:44 +0000 Message-ID: References: <1475781125-1472-1-git-send-email-michael.d.kinney@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2NjZDk4NWQtMjQ5Mi00MWQzLWFjNWYtZDk5Y2Q5NTc4Y2I4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkdKTDRQZmdybHRmOWI4cjdTMVAwV3I2bWZMcVluZXRtQmY3d0hKUTJKbnc9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Subject: Re: [Patch 0/5] QuarkPlatformPkg: Fix BOOT_IN_RECOVERY_MODE issues X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Oct 2016 21:02:46 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Entire patch reviewed. Looks good to me. Reviewed-by: Kelly Steele > -----Original Message----- > From: Steele, Kelly > Sent: October 07, 2016 12:27 > To: Kinney, Michael D ; edk2-devel@lists.01.o= rg > Subject: RE: [Patch 0/5] QuarkPlatformPkg: Fix BOOT_IN_RECOVERY_MODE > issues >=20 >=20 >=20 > Reviewed-by: Kelly Steele >=20 >=20 >=20 >=20 > > -----Original Message----- > > From: Kinney, Michael D > > Sent: October 06, 2016 12:12 > > To: edk2-devel@lists.01.org > > Cc: Steele, Kelly > > Subject: [Patch 0/5] QuarkPlatformPkg: Fix BOOT_IN_RECOVERY_MODE issues > > > > This patch series addresses the following 3 issues in Bugzilla: > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D137 > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D138 > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D139 > > > > It also removes a function and library that are no longer used. > > > > Cc: Kelly Steele > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Michael Kinney > > > > Michael Kinney (5): > > QuarkPlatformPkg/ForceRecovery: Add UEFI application to force recover= y > > QuarkPlatformPkg/PlatformInit: Fix recovery detection issues > > QuarkPlatformPkg/PlatformHelperLib: Remove > PlatformDebugPortGetChar8() > > QuarkPlatformPkg: Add ForceRecovery UEFI application > > QuarkPlatformPkg/RecoveryOemHookLib: Remove RecoveryOemHookLib > > > > .../Application/ForceRecovery/ForceRecovery.c | 53 ++++++++++ > > .../Application/ForceRecovery/ForceRecovery.inf | 39 +++++++ > > .../Include/Library/PlatformHelperLib.h | 16 +-- > > .../Include/Library/RecoveryOemHookLib.h | 45 --------- > > .../Library/PlatformHelperLib/PlatformHelperLib.c | 27 ----- > > .../Library/RecoveryOemHookLib/CommonHeader.h | 30 ------ > > .../RecoveryOemHookLib/RecoveryOemHookLib.c | 61 ----------- > > .../RecoveryOemHookLib/RecoveryOemHookLib.inf | 49 --------- > > .../Platform/Pei/PlatformInit/BootMode.c | 89 ++++++-------= --- > > .../Platform/Pei/PlatformInit/CommonHeader.h | 4 +- > > .../Platform/Pei/PlatformInit/MrcWrapper.c | 112 +------------= -------- > > .../Platform/Pei/PlatformInit/MrcWrapper.h | 11 +- > > .../Platform/Pei/PlatformInit/PlatformEarlyInit.c | 67 +++++++++++- > > .../Pei/PlatformInit/PlatformEarlyInit.inf | 1 - > > QuarkPlatformPkg/Quark.dsc | 6 +- > > QuarkPlatformPkg/QuarkMin.dsc | 1 - > > 16 files changed, 196 insertions(+), 415 deletions(-) > > create mode 100644 > > QuarkPlatformPkg/Application/ForceRecovery/ForceRecovery.c > > create mode 100644 > > QuarkPlatformPkg/Application/ForceRecovery/ForceRecovery.inf > > delete mode 100644 > > QuarkPlatformPkg/Include/Library/RecoveryOemHookLib.h > > delete mode 100644 > > QuarkPlatformPkg/Library/RecoveryOemHookLib/CommonHeader.h > > delete mode 100644 > > QuarkPlatformPkg/Library/RecoveryOemHookLib/RecoveryOemHookLib.c > > delete mode 100644 > > QuarkPlatformPkg/Library/RecoveryOemHookLib/RecoveryOemHookLib.inf > > > > -- > > 2.6.3.windows.1