From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.65; helo=mga03.intel.com; envelope-from=kelly.steele@intel.com; receiver=edk2-devel@lists.01.org Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CD6A62202E48F for ; Wed, 14 Mar 2018 08:23:05 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2018 08:29:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,470,1515484800"; d="scan'208";a="34981532" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga003.jf.intel.com with ESMTP; 14 Mar 2018 08:29:28 -0700 Received: from orsmsx151.amr.corp.intel.com (10.22.226.38) by ORSMSX106.amr.corp.intel.com (10.22.225.133) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 14 Mar 2018 08:29:28 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.126]) by ORSMSX151.amr.corp.intel.com ([169.254.7.10]) with mapi id 14.03.0319.002; Wed, 14 Mar 2018 08:29:27 -0700 From: "Steele, Kelly" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: Sean Brogan , "Zhu, Yonghong" , "Gao, Liming" , "Zhang, Chao B" , "Yao, Jiewen" , "Wei, David" , "Guo, Mang" Thread-Topic: [Patch 0/5] Add multi-cert PcdPkcs7CertBufferXdr Thread-Index: AQHTujiZdUeOXPIHTE6EKSWug9xYGqPP3VhQ Date: Wed, 14 Mar 2018 15:29:25 +0000 Message-ID: References: <20180312193017.15156-1-michael.d.kinney@intel.com> In-Reply-To: <20180312193017.15156-1-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjg0YTQ0NjctMGU0Yy00ODcxLThkMmUtMmY1NzUzYTI0OTliIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJrTHl1VGY0MFhkUGs2WGdjeFY5bWU4NUFcL0JGTVwvYjBNTVpaWnNpdFFHbmhzREgwdkpHbTFpSFwvd3BjdXZ1cVcyIn0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Subject: Re: [Patch 0/5] Add multi-cert PcdPkcs7CertBufferXdr X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 15:23:06 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Kelly Steele Thanks, Kelly > -----Original Message----- > From: Kinney, Michael D > Sent: March 12, 2018 12:30 > To: edk2-devel@lists.01.org > Cc: Sean Brogan ; Zhu, Yonghong > ; Gao, Liming ; Zhang, > Chao B ; Yao, Jiewen ; > Steele, Kelly ; Wei, David ; > Guo, Mang ; Kinney, Michael D > > Subject: [Patch 0/5] Add multi-cert PcdPkcs7CertBufferXdr >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D890 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D891 >=20 > * Update BinToPcd to support multiple one or more -i INPUTFILE arguments > * Update BinToPcd to support -x, --xdr flags to encode PCD using the > Variable-Length Opaque Data of RFC 4506 External Data Representation > Standard (XDR). > * Add PcdPkcs7CertBufferXdr that supports one or more PKCS7 certificates > encoded using the Variable-Length Opaque Data format of RFC 4506 > External > Data Representation Standard (XDR). > * Use both PcdPkcs7CertBuffer and PcdPkcs7CertBufferXdr to authenticate > capsules. > * Evaluate both PcdPkcs7CertBuffer and PcdPkcs7CertBufferXdr for the use > of the test key. >=20 > Branch for review: > https://github.com/mdkinney/edk2/tree/Bug_890_891_BinToPcdMultipleIn > putFiles >=20 > Cc: Sean Brogan > Cc: Yonghong Zhu > Cc: Liming Gao > Cc: Chao Zhang > Cc: Jiewen Yao > Cc: Kelly Steele > Cc: David Wei > Cc: Mang Guo > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Michael D Kinney >=20 > Kinney, Michael D (4): > BaseTools/BinToPcd: Add support for multiple binary input files > SecurityPkg: Add PcdPkcs7CertBufferXdr > SecurityPkg/EdkiiSystemCapsuleLib: Use PcdPkcs7CertBufferXdr > QuarkPlatformPkg/PlatformBootManagerLib: Check PcdPkcs7CertBufferXdr >=20 > Michael D Kinney (1): > Vlv2TbltDevicePkg/PlatformBootManagerLib: Check PcdPkcs7CertBufferXdr >=20 > BaseTools/Scripts/BinToPcd.py | 83 ++++++++++++++--= ------ > .../PlatformBootManagerLib/PlatformBootManager.c | 51 ++++++++++++- > .../PlatformBootManagerLib.inf | 3 +- > SecurityPkg/SecurityPkg.dec | 8 +++ > SecurityPkg/SecurityPkg.uni | 6 ++ > .../EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.c | 77 > +++++++++++++++++--- > .../EdkiiSystemCapsuleLib.inf | 3 +- > .../Library/PlatformBdsLib/BdsPlatform.c | 57 ++++++++++++++- > .../Library/PlatformBdsLib/PlatformBdsLib.inf | 22 +++--- > 9 files changed, 258 insertions(+), 52 deletions(-) >=20 > -- > 2.14.2.windows.3