From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=kelly.steele@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A8A86211575ED for ; Wed, 26 Sep 2018 08:58:24 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2018 08:58:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,306,1534834800"; d="scan'208,217";a="236119661" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga004.jf.intel.com with ESMTP; 26 Sep 2018 08:54:04 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.194]) by ORSMSX106.amr.corp.intel.com ([169.254.1.57]) with mapi id 14.03.0319.002; Wed, 26 Sep 2018 08:54:04 -0700 From: "Steele, Kelly" To: "Wei, David" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Shift EEPROM PEI files Thread-Index: AdRR2LT+gTDF1OlIQjudRZKfSrMRtwDzfO3QAAJcQTA= Date: Wed, 26 Sep 2018 15:54:03 +0000 Message-ID: References: <89954A0B46707A448411A627AD4EEE346911E1AB@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <89954A0B46707A448411A627AD4EEE346911E1AB@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGU5ZmFmZDctMjZlOC00YmQ2LWIyM2UtNjU0N2FkZDRjNmY5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYlYyRW1pY2ZTc2UrN055RE9YY08zQlRodU9BcG9aZFwvNlU1TGVOV0lmRk1BVWNxa043WUE2MVlDZURmT1UyZVIifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Shift EEPROM PEI files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Sep 2018 15:58:25 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi David, Yes this PCD information is board specific. That is why it is wrapped in a = board specific define. I would move it into the board specific folder, but = it is FixedAtBuild so it cannot go into the code. Did you want me to add a = PcdsFixedAtBuild.dsc into the board specific folder and include it in the t= op level PcdsFixedAtBuild.dsc? + + !if $(MINNOW3_MODULE_BOARD) =3D=3D TRUE + # + # I2C bus the master EEPROM is hanging on + gPlatformModuleTokenSpaceGuid.PcdEepromBus|0x08 + # 7-bit address of the master EEPROM + gPlatformModuleTokenSpaceGuid.PcdEepromAddress|0x10 + # EEPROM GPIO Whitelist for MB3M (should think about shifting to SkuId= specfic PCD to allow for other platforms). + # +--------------------= ---+-----------------------+-----------------------+-----------------------= +-----------------------+-----------------------+-----------------------+--= ---------------------+-----------------------+-----------------------+-----= ------------------+-----------------------+-----------------------+--------= ---------------+-----------------------+-----------------------+-----------= ------------+-----------------------+-----------------------+--------------= ---------+-----------------------+-----------------------+-----------------= ------+-----------------------+-----------------------+--------------------= ---+-----------------------+-----------------------+-----------------------= +-----------------------+-----------------------+-----------------------+--= ---------------------+-----------------------+-----------------------+-----= ------------------+-----------------------+-----------------------+--------= ---------------+-----------------------+-----------------------+-----------= ------------+-----------------------+-----------------------+--------------= ---------+-----------------------+-----------------------+-----------------= ------+-----------------------+-----------------------+--------------------= ---+-----------------------+-----------------------+-----------------------= +-----------------------+-----------------------+-----------------------+--= ---------------------+-----------------------+-----------------------+-----= ------------------+-----------------------+-----------------------+--------= ---------------+-----------------------+-----------------------+-----------= ------------+-----------------------+-----------------------+--------------= ---------+-----------------------+-----------------------+-----------------= ------+-----------------------+-----------------------+--------------------= ---+-----------------------+-----------------------+-----------------------= +-----------------------+-----------------------+-----------------------+--= ---------------------+-----------------------+-----------------------+-----= ------------------+-----------------------+-----------------------+--------= ---------------+-----------------------+-----------------------+ + # | SW_GPIO_206 = | SW_GPIO_166 | SW_GPIO_167 | SW_GPIO_168 = | SW_GPIO_169 | SW_GPIO_170 | SW_GPIO_171 | = SW_GPIO_172 | SW_GPIO_173 | SW_GPIO_174 | = SW_GPIO_175 | SW_GPIO_176 | SW_GPIO_177 | S= W_GPIO_178 | SW_GPIO_186 | SW_GPIO_183 | SW_S= MB_ALERTB | SW_SMB_CLK | SW_SMB_DATA | NW_GPIO= _193 | NW_GPIO_196 | NW_GPIO_197 | NW_GPIO_19= 8 | NW_GPIO_199 | NW_GPIO_200 | NW_GPIO_203 = | NW_GPIO_204 | NW_PMC_SPI_FS1 | NW_GPIO_84 = | NW_GPIO_84 | NW_GPIO_85 | NW_GPIO_86 | = NW_GPIO_87 | NW_GPIO_88 | NW_GPIO_97 | = NW_GPIO_98 | NW_GPIO_99 | NW_GPIO_100 | N= W_GPIO_103 | NW_GPIO_104 | NW_GPIO_105 | NW_G= PIO_106 | NW_GPIO_109 | NW_GPIO_110 | NW_GPIO= _112 | NW_GPIO_113 | N_GPIO_2 | N_GPIO_3 = | N_GPIO_4 | N_GPIO_6 | N_GPIO_7 = | N_GPIO_13 | N_GPIO_14 | N_GPIO_21 = | N_GPIO_22 | N_GPIO_23 | N_GPIO_24 | = N_GPIO_25 | N_GPIO_26 | N_GPIO_38 | = N_GPIO_39 | N_GPIO_40 | N_GPIO_41 | N= _GPIO_42 | N_GPIO_43 | N_GPIO_46 | N_GP= IO_47 | N_GPIO_48 | N_GPIO_49 | N_GPIO_= 64 | N_GPIO_65 | N_GPIO_66 | N_GPIO_67 = | W_GPIO_126 | W_GPIO_127 | W_GPIO_132 = | W_GPIO_133 | W_GPIO_134 | W_GPIO_135 = | W_GPIO_136 | W_GPIO_137 | W_GPIO_146 | = W_GPIO_147 | W_GPIO_148 | W_GPIO_149 | = W_OSC_CLK_OUT_0 | W_PMU_AC_PRESENT | W_PMU_BATLOW_B | W_P= MU_PLTRST_B | W_PMU_SLP_S3_B | End of array marker | + gPlatformModuleTokenSpaceGuid.PcdGpioWhiteList | {0x08, 0x05, 0xC0, 0x= 00, 0x70, 0x05, 0xC0, 0x00, 0x78, 0x05, 0xC0, 0x00, 0x80, 0x05, 0xC0, 0x00,= 0x88, 0x05, 0xC0, 0x00, 0x90, 0x05, 0xC0, 0x00, 0x98, 0x05, 0xC0, 0x00, 0x= A0, 0x05, 0xC0, 0x00, 0xA8, 0x05, 0xC0, 0x00, 0xB0, 0x05, 0xC0, 0x00, 0xB8,= 0x05, 0xC0, 0x00, 0xC0, 0x05, 0xC0, 0x00, 0xC8, 0x05, 0xC0, 0x00, 0xD0, 0x= 05, 0xC0, 0x00, 0xE0, 0x05, 0xC0, 0x00, 0xF0, 0x05, 0xC0, 0x00, 0xF8, 0x05,= 0xC0, 0x00, 0x00, 0x06, 0xC0, 0x00, 0x08, 0x06, 0xC0, 0x00, 0x30, 0x05, 0x= C4, 0x00, 0x48, 0x05, 0xC4, 0x00, 0x50, 0x05, 0xC4, 0x00, 0x58, 0x05, 0xC4,= 0x00, 0x60, 0x05, 0xC4, 0x00, 0x68, 0x05, 0xC4, 0x00, 0x80, 0x05, 0xC4, 0x= 00, 0x88, 0x05, 0xC4, 0x00, 0x98, 0x05, 0xC4, 0x00, 0x60, 0x06, 0xC4, 0x00,= 0x60, 0x06, 0xC4, 0x00, 0x68, 0x06, 0xC4, 0x00, 0x70, 0x06, 0xC4, 0x00, 0x= 78, 0x06, 0xC4, 0x00, 0x80, 0x06, 0xC4, 0x00, 0xA8, 0x06, 0xC4, 0x00, 0xB0,= 0x06, 0xC4, 0x00, 0xB8, 0x06, 0xC4, 0x00, 0xC0, 0x06, 0xC4, 0x00, 0xD8, 0x= 06, 0xC4, 0x00, 0xE8, 0x06, 0xC4, 0x00, 0xF0, 0x06, 0xC4, 0x00, 0xF8, 0x06,= 0xC4, 0x00, 0x00, 0x07, 0xC4, 0x00, 0x08, 0x07, 0xC4, 0x00, 0x18, 0x07, 0x= C4, 0x00, 0x20, 0x07, 0xC4, 0x00, 0x10, 0x05, 0xC5, 0x00, 0x18, 0x05, 0xC5,= 0x00, 0x20, 0x05, 0xC5, 0x00, 0x30, 0x05, 0xC5, 0x00, 0x38, 0x05, 0xC5, 0x= 00, 0x68, 0x05, 0xC5, 0x00, 0x70, 0x05, 0xC5, 0x00, 0xA8, 0x05, 0xC5, 0x00,= 0xB0, 0x05, 0xC5, 0x00, 0xB8, 0x05, 0xC5, 0x00, 0xC0, 0x05, 0xC5, 0x00, 0x= C8, 0x05, 0xC5, 0x00, 0xD0, 0x05, 0xC5, 0x00, 0x30, 0x06, 0xC5, 0x00, 0x38,= 0x06, 0xC5, 0x00, 0x40, 0x06, 0xC5, 0x00, 0x48, 0x06, 0xC5, 0x00, 0x50, 0x= 06, 0xC5, 0x00, 0x58, 0x06, 0xC5, 0x00, 0x70, 0x06, 0xC5, 0x00, 0x78, 0x06,= 0xC5, 0x00, 0x80, 0x06, 0xC5, 0x00, 0x88, 0x06, 0xC5, 0x00, 0xA0, 0x06, 0x= C5, 0x00, 0xA8, 0x06, 0xC5, 0x00, 0xB0, 0x06, 0xC5, 0x00, 0xB8, 0x06, 0xC5,= 0x00, 0x10, 0x05, 0xC7, 0x00, 0x18, 0x05, 0xC7, 0x00, 0x40, 0x05, 0xC7, 0x= 00, 0x48, 0x05, 0xC7, 0x00, 0x50, 0x05, 0xC7, 0x00, 0x58, 0x05, 0xC7, 0x00,= 0x60, 0x05, 0xC7, 0x00, 0x68, 0x05, 0xC7, 0x00, 0x80, 0x05, 0xC7, 0x00, 0x= 88, 0x05, 0xC7, 0x00, 0x90, 0x05, 0xC7, 0x00, 0x98, 0x05, 0xC7, 0x00, 0xF0,= 0x05, 0xC7, 0x00, 0x18, 0x06, 0xC7, 0x00, 0x20, 0x06, 0xC7, 0x00, 0x28, 0x= 06, 0xC7, 0x00, 0x48, 0x06, 0xC7, 0x00, 0xFF, 0xFF, 0xFF, 0xFF} + !endif Thanks, Kelly From: Wei, David Sent: September 26, 2018 07:53 To: Steele, Kelly ; edk2-devel@lists.01.org Cc: Guo, Mang Subject: RE: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Shift E= EPROM PEI files Hi Kelly, Does this PCD contain board specific value? If it is board specific, could = you rename it to reflect which board is using this PCD? My another concern is: It is a little hard to read the data structure of th= is large PCD array. Is there any reason why we do not define it in C file. = My understanding is that this kind of GPIO information should be under "Boa= rd" folder. + # | SW_GPIO_206 = | SW_GPIO_166 | SW_GPIO_167 | SW_GPIO_168 = | SW_GPIO_169 | SW_GPIO_170 | SW_GPIO_171 | = SW_GPIO_172 | SW_GPIO_173 | SW_GPIO_174 | = SW_GPIO_175 | SW_GPIO_176 | SW_GPIO_177 | S= W_GPIO_178 | SW_GPIO_186 | SW_GPIO_183 | SW_S= MB_ALERTB | SW_SMB_CLK | SW_SMB_DATA | NW_GPIO= _193 | NW_GPIO_196 | NW_GPIO_197 | NW_GPIO_19= 8 | NW_GPIO_199 | NW_GPIO_200 | NW_GPIO_203 = | NW_GPIO_204 | NW_PMC_SPI_FS1 | NW_GPIO_84 = | NW_GPIO_84 | NW_GPIO_85 | NW_GPIO_86 | = NW_GPIO_87 | NW_GPIO_88 | NW_GPIO_97 | = NW_GPIO_98 | NW_GPIO_99 | NW_GPIO_100 | N= W_GPIO_103 | NW_GPIO_104 | NW_GPIO_105 | NW_G= PIO_106 | NW_GPIO_109 | NW_GPIO_110 | NW_GPIO= _112 | NW_GPIO_113 | N_GPIO_2 | N_GPIO_3 = | N_GPIO_4 | N_GPIO_6 | N_GPIO_7 = | N_GPIO_13 | N_GPIO_14 | N_GPIO_21 = | N_GPIO_22 | N_GPIO_23 | N_GPIO_24 | = N_GPIO_25 | N_GPIO_26 | N_GPIO_38 | = N_GPIO_39 | N_GPIO_40 | N_GPIO_41 | N= _GPIO_42 | N_GPIO_43 | N_GPIO_46 | N_GP= IO_47 | N_GPIO_48 | N_GPIO_49 | N_GPIO_= 64 | N_GPIO_65 | N_GPIO_66 | N_GPIO_67 = | W_GPIO_126 | W_GPIO_127 | W_GPIO_132 = | W_GPIO_133 | W_GPIO_134 | W_GPIO_135 = | W_GPIO_136 | W_GPIO_137 | W_GPIO_146 | = W_GPIO_147 | W_GPIO_148 | W_GPIO_149 | = W_OSC_CLK_OUT_0 | W_PMU_AC_PRESENT | W_PMU_BATLOW_B | W_P= MU_PLTRST_B | W_PMU_SLP_S3_B | End of array marker | + gPlatformModuleTokenSpaceGuid.PcdGpioWhiteList | {0x08, 0x05, 0xC0, 0x= 00, 0x70, 0x05, 0xC0, 0x00, 0x78, 0x05, 0xC0, 0x00, 0x80, 0x05, 0xC0, 0x00,= 0x88, 0x05, 0xC0, 0x00, 0x90, 0x05, 0xC0, 0x00, 0x98, 0x05, 0xC0, 0x00, 0x= A0, 0x05, 0xC0, 0x00, 0xA8, 0x05, 0xC0, 0x00, 0xB0, 0x05, 0xC0, 0x00, 0xB8,= 0x05, 0xC0, 0x00, 0xC0, 0x05, 0xC0, 0x00, 0xC8, 0x05, 0xC0, 0x00, 0xD0, 0x= 05, 0xC0, 0x00, 0xE0, 0x05, 0xC0, 0x00, 0xF0, 0x05, 0xC0, 0x00, 0xF8, 0x05,= 0xC0, 0x00, 0x00, 0x06, 0xC0, 0x00, 0x08, 0x06, 0xC0, 0x00, 0x30, 0x05, 0x= C4, 0x00, 0x48, 0x05, 0xC4, 0x00, 0x50, 0x05, 0xC4, 0x00, 0x58, 0x05, 0xC4,= 0x00, 0x60, 0x05, 0xC4, 0x00, 0x68, 0x05, 0xC4, 0x00, 0x80, 0x05, 0xC4, 0x= 00, 0x88, 0x05, 0xC4, 0x00, 0x98, 0x05, 0xC4, 0x00, 0x60, 0x06, 0xC4, 0x00,= 0x60, 0x06, 0xC4, 0x00, 0x68, 0x06, 0xC4, 0x00, 0x70, 0x06, 0xC4, 0x00, 0x= 78, 0x06, 0xC4, 0x00, 0x80, 0x06, 0xC4, 0x00, 0xA8, 0x06, 0xC4, 0x00, 0xB0,= 0x06, 0xC4, 0x00, 0xB8, 0x06, 0xC4, 0x00, 0xC0, 0x06, 0xC4, 0x00, 0xD8, 0x= 06, 0xC4, 0x00, 0xE8, 0x06, 0xC4, 0x00, 0xF0, 0x06, 0xC4, 0x00, 0xF8, 0x06,= 0xC4, 0x00, 0x00, 0x07, 0xC4, 0x00, 0x08, 0x07, 0xC4, 0x00, 0x18, 0x07, 0x= C4, 0x00, 0x20, 0x07, 0xC4, 0x00, 0x10, 0x05, 0xC5, 0x00, 0x18, 0x05, 0xC5,= 0x00, 0x20, 0x05, 0xC5, 0x00, 0x30, 0x05, 0xC5, 0x00, 0x38, 0x05, 0xC5, 0x= 00, 0x68, 0x05, 0xC5, 0x00, 0x70, 0x05, 0xC5, 0x00, 0xA8, 0x05, 0xC5, 0x00,= 0xB0, 0x05, 0xC5, 0x00, 0xB8, 0x05, 0xC5, 0x00, 0xC0, 0x05, 0xC5, 0x00, 0x= C8, 0x05, 0xC5, 0x00, 0xD0, 0x05, 0xC5, 0x00, 0x30, 0x06, 0xC5, 0x00, 0x38,= 0x06, 0xC5, 0x00, 0x40, 0x06, 0xC5, 0x00, 0x48, 0x06, 0xC5, 0x00, 0x50, 0x= 06, 0xC5, 0x00, 0x58, 0x06, 0xC5, 0x00, 0x70, 0x06, 0xC5, 0x00, 0x78, 0x06,= 0xC5, 0x00, 0x80, 0x06, 0xC5, 0x00, 0x88, 0x06, 0xC5, 0x00, 0xA0, 0x06, 0x= C5, 0x00, 0xA8, 0x06, 0xC5, 0x00, 0xB0, 0x06, 0xC5, 0x00, 0xB8, 0x06, 0xC5,= 0x00, 0x10, 0x05, 0xC7, 0x00, 0x18, 0x05, 0xC7, 0x00, 0x40, 0x05, 0xC7, 0x= 00, 0x48, 0x05, 0xC7, 0x00, 0x50, 0x05, 0xC7, 0x00, 0x58, 0x05, 0xC7, 0x00,= 0x60, 0x05, 0xC7, 0x00, 0x68, 0x05, 0xC7, 0x00, 0x80, 0x05, 0xC7, 0x00, 0x= 88, 0x05, 0xC7, 0x00, 0x90, 0x05, 0xC7, 0x00, 0x98, 0x05, 0xC7, 0x00, 0xF0,= 0x05, 0xC7, 0x00, 0x18, 0x06, 0xC7, 0x00, 0x20, 0x06, 0xC7, 0x00, 0x28, 0x= 06, 0xC7, 0x00, 0x48, 0x06, 0xC7, 0x00, 0xFF, 0xFF, 0xFF, 0xFF} + !endif -- I am OK with other part of this patch. Thanks, David Wei Intel SSG/STO/UEFI BIOS From: Steele, Kelly Sent: Saturday, September 22, 2018 2:27 AM To: edk2-devel@lists.01.org Cc: Wei, David >; Guo, Mang= > Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Shift EEPRO= M PEI files >>From 1ae6e8934e17e0a0d20d169551d852cf3e8a1227 Mon Sep 17 00:00:00 2001 From: Kelly Steele > Date: Fri, 21 Sep 2018 11:14:02 -0700 Subject: [PATCH] [edk2-platforms/devel-IntelAtomProcessorE3900] Shift EEPRO= M PEI files Shifted the EEPROM PEI files into their own folders to help organize the code better. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Kelly Steele > --- .../EepromBinary/Docs/HowtoCreateTheEepromBinary.pdf | Bin 307112 -> 0 by= tes .../Eeprom/EepromDataLib/EEPROM/{ =3D> Pei}/HobDataPei.c | 0 .../Features/Eeprom/EepromDataLib/EepromDataLib.inf | 1 + .../Features/Eeprom/EepromDataLib/EepromDataPeiLib.inf | 9 +++++---- ...promDataNullPeiLib.inf =3D> EepromDataPeiNullLib.inf} | 2 +- .../Eeprom/EepromDataLib/FV/{ =3D> Pei}/GetImagePei.c | 0 .../Eeprom/EepromDataLib/Memory/{ =3D> Pei}/HobDataPei.c | 0 .../EepromDataLib/{ =3D> Pei}/MemoryAllocationPei.c | 2 ++ .../PlatformDsc/PcdsFixedAtBuild.dsc | 16 ++++++++++++--= -- 9 files changed, 21 insertions(+), 9 deletions(-) delete mode 100644 Platform/BroxtonPlatformPkg/Common/Features/Eeprom/Eepro= mBinary/Docs/HowtoCreateTheEepromBinary.pdf rename Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataLib/EEP= ROM/{ =3D> Pei}/HobDataPei.c (100%) rename Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataLib/{Ee= promDataNullPeiLib.inf =3D> EepromDataPeiNullLib.inf} (94%) rename Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataLib/FV/= { =3D> Pei}/GetImagePei.c (100%) rename Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataLib/Mem= ory/{ =3D> Pei}/HobDataPei.c (100%) rename Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataLib/{ = =3D> Pei}/MemoryAllocationPei.c (95%) diff --git a/Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromBinar= y/Docs/HowtoCreateTheEepromBinary.pdf b/Platform/BroxtonPlatformPkg/Common/= Features/Eeprom/EepromBinary/Docs/HowtoCreateTheEepromBinary.pdf deleted file mode 100644 index 84f6e594539fb8224493acd57ee41207cf0bee5e..000000000000000000000000000= 0000000000000 GIT binary patch literal 0 # Removed binary content to reduce email length diff --git a/Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataL= ib/EEPROM/HobDataPei.c b/Platform/BroxtonPlatformPkg/Common/Features/Eeprom= /EepromDataLib/EEPROM/Pei/HobDataPei.c similarity index 100% rename from Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataLi= b/EEPROM/HobDataPei.c rename to Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataLib/= EEPROM/Pei/HobDataPei.c diff --git a/Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataL= ib/EepromDataLib.inf b/Platform/BroxtonPlatformPkg/Common/Features/Eeprom/E= epromDataLib/EepromDataLib.inf index 0ce2aaf9a6..a88d8fd1df 100644 --- a/Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataLib/Eepr= omDataLib.inf +++ b/Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataLib/Eepr= omDataLib.inf @@ -34,6 +34,7 @@ DebugLib EepromPlatformLib HobLib + I2cLib MemoryAllocationLib PcdLib PrintLib diff --git a/Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataL= ib/EepromDataPeiLib.inf b/Platform/BroxtonPlatformPkg/Common/Features/Eepro= m/EepromDataLib/EepromDataPeiLib.inf index de14765a7b..9d7462194d 100644 --- a/Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataLib/Eepr= omDataPeiLib.inf +++ b/Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataLib/Eepr= omDataPeiLib.inf @@ -34,6 +34,7 @@ DebugLib EepromPlatformLib HobLib + I2cLib PcdLib PeiServicesLib PrintLib @@ -57,16 +58,16 @@ EepromDataLib.c EepromDataLib.h EepromDataLibConstructor.c - MemoryAllocationPei.c EEPROM/EepromDataEepromLib.c EEPROM/EepromDataEepromLib.h - EEPROM/HobDataPei.c + EEPROM/Pei/HobDataPei.c FV/EepromDataFvLib.c FV/EepromDataFvLib.h - FV/GetImagePei.c + FV/Pei/GetImagePei.c Memory/EepromDataMemoryLib.c Memory/EepromDataMemoryLib.h - Memory/HobDataPei.c + Memory/Pei/HobDataPei.c Null/EepromDataNullLib.c Null/EepromDataNullLib.h + Pei/MemoryAllocationPei.c diff --git a/Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataL= ib/EepromDataNullPeiLib.inf b/Platform/BroxtonPlatformPkg/Common/Features/E= eprom/EepromDataLib/EepromDataPeiNullLib.inf similarity index 94% rename from Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataLi= b/EepromDataNullPeiLib.inf rename to Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataLib/= EepromDataPeiNullLib.inf index 456d75dbb0..48e2b8f5ea 100644 --- a/Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataLib/Eepr= omDataNullPeiLib.inf +++ b/Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataLib/Eepr= omDataPeiNullLib.inf @@ -40,7 +40,7 @@ EepromDataLib.c EepromDataLib.h EepromDataNullLibConstructor.c - MemoryAllocationPei.c Null/EepromDataNullLib.c Null/EepromDataNullLib.h + Pei/MemoryAllocationPei.c diff --git a/Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataL= ib/FV/GetImagePei.c b/Platform/BroxtonPlatformPkg/Common/Features/Eeprom/Ee= promDataLib/FV/Pei/GetImagePei.c similarity index 100% rename from Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataLi= b/FV/GetImagePei.c rename to Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataLib/= FV/Pei/GetImagePei.c diff --git a/Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataL= ib/Memory/HobDataPei.c b/Platform/BroxtonPlatformPkg/Common/Features/Eeprom= /EepromDataLib/Memory/Pei/HobDataPei.c similarity index 100% rename from Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataLi= b/Memory/HobDataPei.c rename to Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataLib/= Memory/Pei/HobDataPei.c diff --git a/Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataL= ib/MemoryAllocationPei.c b/Platform/BroxtonPlatformPkg/Common/Features/Eepr= om/EepromDataLib/Pei/MemoryAllocationPei.c similarity index 95% rename from Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataLi= b/MemoryAllocationPei.c rename to Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataLib/= Pei/MemoryAllocationPei.c index 71abbaed75..76c7ed798e 100644 --- a/Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataLib/Memo= ryAllocationPei.c +++ b/Platform/BroxtonPlatformPkg/Common/Features/Eeprom/EepromDataLib/Pei/= MemoryAllocationPei.c @@ -315,10 +315,12 @@ GetEepromMemoryHob (VOID) // // Create HOB // + if (mEepromDataLibDebugFlag) DisplayStackPointer (__FUNCTION__, __LINE__= ); ZeroMem (&AllocationHeader, sizeof (EEPROM_ALLOCATION_STRUCT)); AllocationHeader.Signature =3D ALLOCATION_HOB_HEADER_SIGNATURE; HeaderPointer =3D BuildGuidDataHob (&gEepromVariableGuid, &AllocationHea= der, MAX_EEPROM_HOB_SIZE); if (mEepromDataLibDebugFlag) DEBUG ((DEBUG_INFO, "%a (#%4d) - HeaderPoin= ter =3D %08x\n", __FUNCTION__, __LINE__, HeaderPointer)); + if (mEepromDataLibDebugFlag) DisplayStackPointer (__FUNCTION__, __LINE__= ); Exit: if (mEepromDataLibDebugFlag) DEBUG ((DEBUG_INFO, "%a (#%4d) - Allocation= Hob @ %08x\n", __FUNCTION__, __LINE__, HeaderPointer)); diff --git a/Platform/BroxtonPlatformPkg/PlatformDsc/PcdsFixedAtBuild.dsc b= /Platform/BroxtonPlatformPkg/PlatformDsc/PcdsFixedAtBuild.dsc index db7cba5f46..1606e04379 100644 --- a/Platform/BroxtonPlatformPkg/PlatformDsc/PcdsFixedAtBuild.dsc +++ b/Platform/BroxtonPlatformPkg/PlatformDsc/PcdsFixedAtBuild.dsc @@ -91,7 +91,15 @@ !else gPlatformModuleTokenSpaceGuid.PcdSerialIoUartNumber|2 !endif - # - # EEPROM GPIO Whitelist - gPlatformModuleTokenSpaceGuid.PcdGpioWhiteList | {0x08, 0x05, 0xC0, 0x00= , 0x78, 0x05, 0xC0, 0x00, 0x80, 0x05, 0xC0, 0x00, 0x88, 0x05, 0xC0, 0x00, 0= x90, 0x05, 0xC0, 0x00, 0xA0, 0x05, 0xC0, 0x00, 0xC8, 0x05, 0xC0, 0x00, 0xD0= , 0x05, 0xC0, 0x00, 0xE0, 0x05, 0xC0, 0x00, 0xF0, 0x05, 0xC0, 0x00, 0xF8, 0= x05, 0xC0, 0x00, 0x30, 0x05, 0xC4, 0x00, 0x48, 0x05, 0xC4, 0x00, 0x50, 0x05= , 0xC4, 0x00, 0x58, 0x05, 0xC4, 0x00, 0x60, 0x05, 0xC4, 0x00, 0x68, 0x05, 0= xC4, 0x00, 0x80, 0x05, 0xC4, 0x00, 0x88, 0x05, 0xC4, 0x00, 0x98, 0x05, 0xC4= , 0x00, 0x60, 0x06, 0xC4, 0x00, 0x60, 0x06, 0xC4, 0x00, 0x68, 0x06, 0xC4, 0= x00, 0x70, 0x06, 0xC4, 0x00, 0x78, 0x06, 0xC4, 0x00, 0x80, 0x06, 0xC4, 0x00= , 0xA8, 0x06, 0xC4, 0x00, 0xB0, 0x06, 0xC4, 0x00, 0xB8, 0x06, 0xC4, 0x00, 0= xC0, 0x06, 0xC4, 0x00, 0xD8, 0x06, 0xC4, 0x00, 0xE8, 0x06, 0xC4, 0x00, 0xF0= , 0x06, 0xC4, 0x00, 0xF8, 0x06, 0xC4, 0x00, 0x00, 0x07, 0xC4, 0x00, 0x08, 0= x07, 0xC4, 0x00, 0x18, 0x07, 0xC4, 0x00, 0x20, 0x07, 0xC4, 0x00, 0x10, 0x05= , 0xC5, 0x00, 0x18, 0x05, 0xC5, 0x00, 0x20, 0x05, 0xC5, 0x00, 0x30, 0x05, 0= xC5, 0x00, 0x38, 0x05, 0xC5, 0x00, 0x68, 0x05, 0xC5, 0x00, 0x70, 0x05, 0xC5= , 0x00, 0xA8, 0x05, 0xC5, 0x00, 0xB0, 0x05, 0xC5, 0x00, 0xB8, 0x05, 0xC5, 0= x00, 0xC0, 0x05, 0xC5, 0x00, 0xC8, 0x05, 0xC5, 0x00, 0xD0, 0x05, 0xC5, 0x00= , 0x30, 0x06, 0xC5, 0x00, 0x38, 0x06, 0xC5, 0x00, 0x40, 0x06, 0xC5, 0x00, 0= x48, 0x06, 0xC5, 0x00, 0x50, 0x06, 0xC5, 0x00, 0x58, 0x06, 0xC5, 0x00, 0x70= , 0x06, 0xC5, 0x00, 0x78, 0x06, 0xC5, 0x00, 0x80, 0x06, 0xC5, 0x00, 0x88, 0= x06, 0xC5, 0x00, 0xA0, 0x06, 0xC5, 0x00, 0xA8, 0x06, 0xC5, 0x00, 0xB0, 0x06= , 0xC5, 0x00, 0xB8, 0x06, 0xC5, 0x00, 0x10, 0x05, 0xC7, 0x00, 0x18, 0x05, 0= xC7, 0x00, 0x40, 0x05, 0xC7, 0x00, 0x48, 0x05, 0xC7, 0x00, 0x50, 0x05, 0xC7= , 0x00, 0x58, 0x05, 0xC7, 0x00, 0x60, 0x05, 0xC7, 0x00, 0x68, 0x05, 0xC7, 0= x00, 0x70, 0x05, 0xC7, 0x00, 0x78, 0x05, 0xC7, 0x00, 0x80, 0x05, 0xC7, 0x00= , 0x88, 0x05, 0xC7, 0x00, 0x90, 0x05, 0xC7, 0x00, 0x98, 0x05, 0xC7, 0x00, 0= xF0, 0x05, 0xC7, 0x00, 0x18, 0x06, 0xC7, 0x00, 0x20, 0x06, 0xC7, 0x00, 0x28= , 0x06, 0xC7, 0x00, 0x48, 0x06, 0xC7, 0x00, 0xFF, 0xFF, 0xFF, 0xFF} - + + !if $(MINNOW3_MODULE_BOARD) =3D=3D TRUE + # + # I2C bus the master EEPROM is hanging on + gPlatformModuleTokenSpaceGuid.PcdEepromBus|0x08 + # 7-bit address of the master EEPROM + gPlatformModuleTokenSpaceGuid.PcdEepromAddress|0x10 + # EEPROM GPIO Whitelist for MB3M (should think about shifting to SkuId= specfic PCD to allow for other platforms). + # +--------------------= ---+-----------------------+-----------------------+-----------------------= +-----------------------+-----------------------+-----------------------+--= ---------------------+-----------------------+-----------------------+-----= ------------------+-----------------------+-----------------------+--------= ---------------+-----------------------+-----------------------+-----------= ------------+-----------------------+-----------------------+--------------= ---------+-----------------------+-----------------------+-----------------= ------+-----------------------+-----------------------+--------------------= ---+-----------------------+-----------------------+-----------------------= +-----------------------+-----------------------+-----------------------+--= ---------------------+-----------------------+-----------------------+-----= ------------------+-----------------------+-----------------------+--------= ---------------+-----------------------+-----------------------+-----------= ------------+-----------------------+-----------------------+--------------= ---------+-----------------------+-----------------------+-----------------= ------+-----------------------+-----------------------+--------------------= ---+-----------------------+-----------------------+-----------------------= +-----------------------+-----------------------+-----------------------+--= ---------------------+-----------------------+-----------------------+-----= ------------------+-----------------------+-----------------------+--------= ---------------+-----------------------+-----------------------+-----------= ------------+-----------------------+-----------------------+--------------= ---------+-----------------------+-----------------------+-----------------= ------+-----------------------+-----------------------+--------------------= ---+-----------------------+-----------------------+-----------------------= +-----------------------+-----------------------+-----------------------+--= ---------------------+-----------------------+-----------------------+-----= ------------------+-----------------------+-----------------------+--------= ---------------+-----------------------+-----------------------+ + # | SW_GPIO_206 = | SW_GPIO_166 | SW_GPIO_167 | SW_GPIO_168 = | SW_GPIO_169 | SW_GPIO_170 | SW_GPIO_171 | = SW_GPIO_172 | SW_GPIO_173 | SW_GPIO_174 | = SW_GPIO_175 | SW_GPIO_176 | SW_GPIO_177 | S= W_GPIO_178 | SW_GPIO_186 | SW_GPIO_183 | SW_S= MB_ALERTB | SW_SMB_CLK | SW_SMB_DATA | NW_GPIO= _193 | NW_GPIO_196 | NW_GPIO_197 | NW_GPIO_19= 8 | NW_GPIO_199 | NW_GPIO_200 | NW_GPIO_203 = | NW_GPIO_204 | NW_PMC_SPI_FS1 | NW_GPIO_84 = | NW_GPIO_84 | NW_GPIO_85 | NW_GPIO_86 | = NW_GPIO_87 | NW_GPIO_88 | NW_GPIO_97 | = NW_GPIO_98 | NW_GPIO_99 | NW_GPIO_100 | N= W_GPIO_103 | NW_GPIO_104 | NW_GPIO_105 | NW_G= PIO_106 | NW_GPIO_109 | NW_GPIO_110 | NW_GPIO= _112 | NW_GPIO_113 | N_GPIO_2 | N_GPIO_3 = | N_GPIO_4 | N_GPIO_6 | N_GPIO_7 = | N_GPIO_13 | N_GPIO_14 | N_GPIO_21 = | N_GPIO_22 | N_GPIO_23 | N_GPIO_24 | = N_GPIO_25 | N_GPIO_26 | N_GPIO_38 | = N_GPIO_39 | N_GPIO_40 | N_GPIO_41 | N= _GPIO_42 | N_GPIO_43 | N_GPIO_46 | N_GP= IO_47 | N_GPIO_48 | N_GPIO_49 | N_GPIO_= 64 | N_GPIO_65 | N_GPIO_66 | N_GPIO_67 = | W_GPIO_126 | W_GPIO_127 | W_GPIO_132 = | W_GPIO_133 | W_GPIO_134 | W_GPIO_135 = | W_GPIO_136 | W_GPIO_137 | W_GPIO_146 | = W_GPIO_147 | W_GPIO_148 | W_GPIO_149 | = W_OSC_CLK_OUT_0 | W_PMU_AC_PRESENT | W_PMU_BATLOW_B | W_P= MU_PLTRST_B | W_PMU_SLP_S3_B | End of array marker | + gPlatformModuleTokenSpaceGuid.PcdGpioWhiteList | {0x08, 0x05, 0xC0, 0x= 00, 0x70, 0x05, 0xC0, 0x00, 0x78, 0x05, 0xC0, 0x00, 0x80, 0x05, 0xC0, 0x00,= 0x88, 0x05, 0xC0, 0x00, 0x90, 0x05, 0xC0, 0x00, 0x98, 0x05, 0xC0, 0x00, 0x= A0, 0x05, 0xC0, 0x00, 0xA8, 0x05, 0xC0, 0x00, 0xB0, 0x05, 0xC0, 0x00, 0xB8,= 0x05, 0xC0, 0x00, 0xC0, 0x05, 0xC0, 0x00, 0xC8, 0x05, 0xC0, 0x00, 0xD0, 0x= 05, 0xC0, 0x00, 0xE0, 0x05, 0xC0, 0x00, 0xF0, 0x05, 0xC0, 0x00, 0xF8, 0x05,= 0xC0, 0x00, 0x00, 0x06, 0xC0, 0x00, 0x08, 0x06, 0xC0, 0x00, 0x30, 0x05, 0x= C4, 0x00, 0x48, 0x05, 0xC4, 0x00, 0x50, 0x05, 0xC4, 0x00, 0x58, 0x05, 0xC4,= 0x00, 0x60, 0x05, 0xC4, 0x00, 0x68, 0x05, 0xC4, 0x00, 0x80, 0x05, 0xC4, 0x= 00, 0x88, 0x05, 0xC4, 0x00, 0x98, 0x05, 0xC4, 0x00, 0x60, 0x06, 0xC4, 0x00,= 0x60, 0x06, 0xC4, 0x00, 0x68, 0x06, 0xC4, 0x00, 0x70, 0x06, 0xC4, 0x00, 0x= 78, 0x06, 0xC4, 0x00, 0x80, 0x06, 0xC4, 0x00, 0xA8, 0x06, 0xC4, 0x00, 0xB0,= 0x06, 0xC4, 0x00, 0xB8, 0x06, 0xC4, 0x00, 0xC0, 0x06, 0xC4, 0x00, 0xD8, 0x= 06, 0xC4, 0x00, 0xE8, 0x06, 0xC4, 0x00, 0xF0, 0x06, 0xC4, 0x00, 0xF8, 0x06,= 0xC4, 0x00, 0x00, 0x07, 0xC4, 0x00, 0x08, 0x07, 0xC4, 0x00, 0x18, 0x07, 0x= C4, 0x00, 0x20, 0x07, 0xC4, 0x00, 0x10, 0x05, 0xC5, 0x00, 0x18, 0x05, 0xC5,= 0x00, 0x20, 0x05, 0xC5, 0x00, 0x30, 0x05, 0xC5, 0x00, 0x38, 0x05, 0xC5, 0x= 00, 0x68, 0x05, 0xC5, 0x00, 0x70, 0x05, 0xC5, 0x00, 0xA8, 0x05, 0xC5, 0x00,= 0xB0, 0x05, 0xC5, 0x00, 0xB8, 0x05, 0xC5, 0x00, 0xC0, 0x05, 0xC5, 0x00, 0x= C8, 0x05, 0xC5, 0x00, 0xD0, 0x05, 0xC5, 0x00, 0x30, 0x06, 0xC5, 0x00, 0x38,= 0x06, 0xC5, 0x00, 0x40, 0x06, 0xC5, 0x00, 0x48, 0x06, 0xC5, 0x00, 0x50, 0x= 06, 0xC5, 0x00, 0x58, 0x06, 0xC5, 0x00, 0x70, 0x06, 0xC5, 0x00, 0x78, 0x06,= 0xC5, 0x00, 0x80, 0x06, 0xC5, 0x00, 0x88, 0x06, 0xC5, 0x00, 0xA0, 0x06, 0x= C5, 0x00, 0xA8, 0x06, 0xC5, 0x00, 0xB0, 0x06, 0xC5, 0x00, 0xB8, 0x06, 0xC5,= 0x00, 0x10, 0x05, 0xC7, 0x00, 0x18, 0x05, 0xC7, 0x00, 0x40, 0x05, 0xC7, 0x= 00, 0x48, 0x05, 0xC7, 0x00, 0x50, 0x05, 0xC7, 0x00, 0x58, 0x05, 0xC7, 0x00,= 0x60, 0x05, 0xC7, 0x00, 0x68, 0x05, 0xC7, 0x00, 0x80, 0x05, 0xC7, 0x00, 0x= 88, 0x05, 0xC7, 0x00, 0x90, 0x05, 0xC7, 0x00, 0x98, 0x05, 0xC7, 0x00, 0xF0,= 0x05, 0xC7, 0x00, 0x18, 0x06, 0xC7, 0x00, 0x20, 0x06, 0xC7, 0x00, 0x28, 0x= 06, 0xC7, 0x00, 0x48, 0x06, 0xC7, 0x00, 0xFF, 0xFF, 0xFF, 0xFF} + !endif -- 2.11.0.windows.1