From: "Steele, Kelly" <kelly.steele@intel.com>
To: "Gao, Zhichao" <zhichao.gao@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Zhang, Chao B" <chao.b.zhang@intel.com>,
"Yao, Jiewen" <jiewen.yao@intel.com>,
"Wang, Jian J" <jian.j.wang@intel.com>,
"Wu, Hao A" <hao.a.wu@intel.com>, "Ni, Ray" <ray.ni@intel.com>,
"Zeng, Star" <star.zeng@intel.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
"Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
"Justen, Jordan L" <jordan.l.justen@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
"Sun, Zailiang" <zailiang.sun@intel.com>,
"Qian, Yi" <yi.qian@intel.com>,
"Sean Brogan" <sean.brogan@microsoft.com>,
Michael Turner <Michael.Turner@microsoft.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>
Subject: Re: [PATCH V2 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype
Date: Thu, 25 Apr 2019 16:46:38 +0000 [thread overview]
Message-ID: <E6EF8131FBAF5A44BF17D9E2B45E20755FC64C56@ORSMSX114.amr.corp.intel.com> (raw)
In-Reply-To: <20190417062722.8568-1-zhichao.gao@intel.com>
QuarkSocPkg/ResetSystemLib
Reviewed-by: Kelly Steele <kelly.steele@intel.com>
> -----Original Message-----
> From: Gao, Zhichao
> Sent: April 16, 2019 23:27
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Yao,
> Jiewen <jiewen.yao@intel.com>; Wang, Jian J <jian.j.wang@intel.com>; Wu,
> Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Zeng, Star
> <star.zeng@intel.com>; Leif Lindholm <leif.lindholm@linaro.org>; Ard
> Biesheuvel <ard.biesheuvel@linaro.org>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Laszlo Ersek <lersek@redhat.com>; Steele, Kelly
> <kelly.steele@intel.com>; Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi
> <yi.qian@intel.com>; Sean Brogan <sean.brogan@microsoft.com>; Michael
> Turner <Michael.Turner@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>
> Subject: [PATCH V2 00/25] Add the new APIs ResetSystem and
> ResetSystemWithSubtype
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
> Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus
> is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific
> or not.
> Add a new API ResetSystem to ResetSystemLib instances. The new driver may
> consume this new API and then it may cause a link error. For these library
> instances, the new API only has a basic function. If the consumers want
> the full function of this API, they should use the instance in the MdeModulePkg
> and make sure the depex driver is dispatched.
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1458
> Add a new API ResetSystemWithSubtype to ResetUtilityLib
>
> V2:
> Update the copy right.
> Fix build error of PcAtChipsetPkg/ResetSystemLib.
> Fix the coding style issue.
> Update the comment for the new API ResetSystemWithSubtype
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Kelly Steele <kelly.steele@intel.com>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Michael Turner <Michael.Turner@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
>
> Bret Barkelew (2):
> MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype
> MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype
>
> Zhichao Gao (23):
> MdePkg/UefiSpec.h: Change comments of EFI_RESET_SYSTEM
> MdePkg/PiPeiCis.h: Change comments of EFI_PEI_RESET2_SYSTEM
> MdePkg/PeiServicesLib.h: Change comments of PeiServicesResetSystem2
> MdePkg/PeiServicesLib.c: Change comments of PeiServicesResetSystem2
> SecurityPkg/Tcg2Dxe: Change comments of ShutdownTpmOnReset
> MdeModulePkg/ResetSystemLib.h: Change comments of ResetSystem
> MdeModulePkg/DxeResetSystemLib.c: Change comments of ResetSystem
> MdeModulePkg/BaseResetSystemLibNull.c: Change comments of ResetSystem
> MdeModulePkg/RuntimeResetSystemLib.c: Change comments
> MdeModulePkg/PeiResetSystemlib.c: Change comments of ResetSystem
> MdeModulePkg/ResetSystemRuntimeDxe: Change comments
> MdeModulePkg/ResetSystemPei: Change comments of ResetSystem2
> MdeModulePkg/PeiMain: Change comments of PeiResetSystem2
> MdeModulePkg/NvmExpressHci.c: Change comments
> BeagleBoardPkg/ResetSystemLib: Add new API ResetSystem
> CorebootPayloadPkg/ResetSystemLib: Add new API ResetSystem
> Nt32Pkg/ResetSystemLib: Add new API ResetSystem
> OvmfPkg/ResetSystemLib: Add new API ResetSystem
> PcAtChipsetPkg/ResetSystemLib: Add new API ResetSystem
> QuarkSocPkg/ResetSystemLib: Add new API ResetSystem
> Vlv2TbltdevicePkg/ResetSystemLib: Add new API ResetSystem
> ArmPkg/ArmSmcPsciResetSystemLib: Add a new API ResetSystem
> ArmVirtPkg/ArmVirtPsciResetSystemLib: Add a new API ResetSystem
>
> .../ArmSmcPsciResetSystemLib.c | 44 +++++++++++++++++
> .../ArmVirtPsciResetSystemLib.c | 44 +++++++++++++++++
> .../Library/ResetSystemLib/ResetSystemLib.c | 44 +++++++++++++++++
> .../Library/ResetSystemLib/ResetSystemLib.c | 45 ++++++++++++++++-
> .../Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 5 +-
> MdeModulePkg/Core/Pei/PeiMain.h | 4 +-
> MdeModulePkg/Core/Pei/Reset/Reset.c | 6 +--
> MdeModulePkg/Include/Library/ResetSystemLib.h | 4 +-
> .../Include/Library/ResetUtilityLib.h | 34 +++++++++++--
> .../BaseResetSystemLibNull.c | 6 +--
> .../DxeResetSystemLib/DxeResetSystemLib.c | 4 +-
> .../PeiResetSystemLib/PeiResetSystemLib.c | 4 +-
> .../Library/ResetUtilityLib/ResetUtility.c | 40 +++++++++++++---
> .../RuntimeResetSystemLib.c | 4 +-
> .../Universal/ResetSystemPei/ResetSystem.c | 7 +--
> .../Universal/ResetSystemPei/ResetSystem.h | 5 +-
> .../ResetSystemRuntimeDxe/ResetSystem.c | 5 +-
> .../ResetSystemRuntimeDxe/ResetSystem.h | 5 +-
> MdePkg/Include/Library/PeiServicesLib.h | 6 +--
> MdePkg/Include/Pi/PiPeiCis.h | 6 +--
> MdePkg/Include/Uefi/UefiSpec.h | 7 +--
> .../Library/PeiServicesLib/PeiServicesLib.c | 6 +--
> .../Library/ResetSystemLib/ResetSystemLib.c | 45 ++++++++++++++++-
> .../Library/ResetSystemLib/ResetSystemLib.c | 45 ++++++++++++++++-
> .../Library/ResetSystemLib/ResetSystemLib.c | 48 ++++++++++++++++++-
> .../Library/ResetSystemLib/ResetSystemLib.c | 45 ++++++++++++++++-
> SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 7 +--
> .../Library/ResetSystemLib/ResetSystemLib.c | 45 ++++++++++++++++-
> 28 files changed, 488 insertions(+), 82 deletions(-)
>
> --
> 2.21.0.windows.1
prev parent reply other threads:[~2019-04-25 16:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-17 6:26 [PATCH V2 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
2019-04-17 6:26 ` [PATCH V2 01/25] MdePkg/UefiSpec.h: Change comments of EFI_RESET_SYSTEM Gao, Zhichao
2019-04-17 6:26 ` [PATCH V2 02/25] MdePkg/PiPeiCis.h: Change comments of EFI_PEI_RESET2_SYSTEM Gao, Zhichao
2019-04-17 6:27 ` [PATCH V2 03/25] MdePkg/PeiServicesLib.h: Change comments of PeiServicesResetSystem2 Gao, Zhichao
2019-04-17 6:27 ` [PATCH V2 04/25] MdePkg/PeiServicesLib.c: " Gao, Zhichao
2019-04-17 6:27 ` [PATCH V2 05/25] SecurityPkg/Tcg2Dxe: Change comments of ShutdownTpmOnReset Gao, Zhichao
2019-04-18 3:30 ` Zhang, Chao B
2019-04-17 6:27 ` [PATCH V2 06/25] MdeModulePkg/ResetSystemLib.h: Change comments of ResetSystem Gao, Zhichao
2019-04-17 6:27 ` [PATCH V2 07/25] MdeModulePkg/DxeResetSystemLib.c: " Gao, Zhichao
2019-04-17 6:27 ` [PATCH V2 08/25] MdeModulePkg/BaseResetSystemLibNull.c: " Gao, Zhichao
2019-04-17 6:27 ` [PATCH V2 09/25] MdeModulePkg/RuntimeResetSystemLib.c: Change comments Gao, Zhichao
2019-04-17 6:27 ` [PATCH V2 10/25] MdeModulePkg/PeiResetSystemlib.c: Change comments of ResetSystem Gao, Zhichao
2019-04-17 6:27 ` [PATCH V2 11/25] MdeModulePkg/ResetSystemRuntimeDxe: Change comments Gao, Zhichao
2019-04-17 6:27 ` [PATCH V2 12/25] MdeModulePkg/ResetSystemPei: Change comments of ResetSystem2 Gao, Zhichao
2019-04-17 6:27 ` [PATCH V2 13/25] MdeModulePkg/PeiMain: Change comments of PeiResetSystem2 Gao, Zhichao
2019-04-17 6:27 ` [PATCH V2 14/25] MdeModulePkg/NvmExpressHci.c: Change comments Gao, Zhichao
2019-04-17 6:27 ` [PATCH V2 15/25] BeagleBoardPkg/ResetSystemLib: Add new API ResetSystem Gao, Zhichao
2019-04-17 6:27 ` [PATCH V2 16/25] CorebootPayloadPkg/ResetSystemLib: " Gao, Zhichao
2019-04-17 6:27 ` [PATCH V2 17/25] Nt32Pkg/ResetSystemLib: " Gao, Zhichao
2019-04-17 6:27 ` [PATCH V2 18/25] OvmfPkg/ResetSystemLib: " Gao, Zhichao
2019-04-17 6:27 ` [PATCH V2 19/25] PcAtChipsetPkg/ResetSystemLib: " Gao, Zhichao
2019-04-17 6:27 ` [PATCH V2 20/25] QuarkSocPkg/ResetSystemLib: " Gao, Zhichao
2019-04-25 17:09 ` [edk2-devel] " Michael D Kinney
2019-04-17 6:27 ` [PATCH V2 21/25] Vlv2TbltdevicePkg/ResetSystemLib: " Gao, Zhichao
2019-04-17 6:27 ` [PATCH V2 22/25] ArmPkg/ArmSmcPsciResetSystemLib: Add a " Gao, Zhichao
2019-04-17 6:27 ` [PATCH V2 23/25] ArmVirtPkg/ArmVirtPsciResetSystemLib: " Gao, Zhichao
2019-04-17 6:27 ` [PATCH V2 24/25] MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype Gao, Zhichao
2019-04-17 6:36 ` Wu, Hao A
2019-04-17 6:27 ` [PATCH V2 25/25] " Gao, Zhichao
2019-04-17 6:37 ` [edk2-devel] " Wu, Hao A
2019-04-25 16:46 ` Steele, Kelly [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E6EF8131FBAF5A44BF17D9E2B45E20755FC64C56@ORSMSX114.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox