From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: kelly.steele@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Thu, 25 Apr 2019 09:46:40 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2019 09:46:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,394,1549958400"; d="scan'208";a="340755920" Received: from orsmsx107.amr.corp.intel.com ([10.22.240.5]) by fmsmga005.fm.intel.com with ESMTP; 25 Apr 2019 09:46:39 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.50]) by ORSMSX107.amr.corp.intel.com ([169.254.1.17]) with mapi id 14.03.0415.000; Thu, 25 Apr 2019 09:46:38 -0700 From: "Steele, Kelly" To: "Gao, Zhichao" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Gao, Liming" , "Zhang, Chao B" , "Yao, Jiewen" , "Wang, Jian J" , "Wu, Hao A" , "Ni, Ray" , "Zeng, Star" , Leif Lindholm , "Ard Biesheuvel" , "Justen, Jordan L" , Laszlo Ersek , "Sun, Zailiang" , "Qian, Yi" , "Sean Brogan" , Michael Turner , Bret Barkelew Subject: Re: [PATCH V2 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Thread-Topic: [PATCH V2 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Thread-Index: AQHU9Oa4AaWTCJXZDkKkPKEWv2aOzqZNIqBw Date: Thu, 25 Apr 2019 16:46:38 +0000 Message-ID: References: <20190417062722.8568-1-zhichao.gao@intel.com> In-Reply-To: <20190417062722.8568-1-zhichao.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWI3ZTYyYTktZGE1Yy00YWZlLWE3YzctNzNiZjdlNjA4NzU5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoicW1MR3BiSFJSdG9lQ280UkU2bm10dno1Z1A1dGJoRDZ0RTZ2Zk0xeUIxSVpwSlwva1YzMzJ1T24wak9NZzl6dnYifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable QuarkSocPkg/ResetSystemLib Reviewed-by: Kelly Steele > -----Original Message----- > From: Gao, Zhichao > Sent: April 16, 2019 23:27 > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; Zhang, Chao B ; Yao, > Jiewen ; Wang, Jian J ; Wu, > Hao A ; Ni, Ray ; Zeng, Star > ; Leif Lindholm ; Ard > Biesheuvel ; Justen, Jordan L > ; Laszlo Ersek ; Steele, Ke= lly > ; Sun, Zailiang ; Qian, Y= i > ; Sean Brogan ; Michael > Turner ; Bret Barkelew > > Subject: [PATCH V2 00/25] Add the new APIs ResetSystem and > ResetSystemWithSubtype >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1460 > Refer to Uefi spec 2.8, the ResetData is valid while ResetStatus > is EFI_SUCCESS regardless of the ResetType is EfiResetPlatformSpecific > or not. > Add a new API ResetSystem to ResetSystemLib instances. The new driver may > consume this new API and then it may cause a link error. For these librar= y > instances, the new API only has a basic function. If the consumers want > the full function of this API, they should use the instance in the MdeMod= ulePkg > and make sure the depex driver is dispatched. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1458 > Add a new API ResetSystemWithSubtype to ResetUtilityLib >=20 > V2: > Update the copy right. > Fix build error of PcAtChipsetPkg/ResetSystemLib. > Fix the coding style issue. > Update the comment for the new API ResetSystemWithSubtype >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Chao Zhang > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Hao Wu > Cc: Ray Ni > Cc: Star Zeng > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Michael D Kinney > Cc: Kelly Steele > Cc: Zailiang Sun > Cc: Yi Qian > Cc: Sean Brogan > Cc: Michael Turner > Cc: Bret Barkelew >=20 > Bret Barkelew (2): > MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype > MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype >=20 > Zhichao Gao (23): > MdePkg/UefiSpec.h: Change comments of EFI_RESET_SYSTEM > MdePkg/PiPeiCis.h: Change comments of EFI_PEI_RESET2_SYSTEM > MdePkg/PeiServicesLib.h: Change comments of PeiServicesResetSystem2 > MdePkg/PeiServicesLib.c: Change comments of PeiServicesResetSystem2 > SecurityPkg/Tcg2Dxe: Change comments of ShutdownTpmOnReset > MdeModulePkg/ResetSystemLib.h: Change comments of ResetSystem > MdeModulePkg/DxeResetSystemLib.c: Change comments of ResetSystem > MdeModulePkg/BaseResetSystemLibNull.c: Change comments of ResetSystem > MdeModulePkg/RuntimeResetSystemLib.c: Change comments > MdeModulePkg/PeiResetSystemlib.c: Change comments of ResetSystem > MdeModulePkg/ResetSystemRuntimeDxe: Change comments > MdeModulePkg/ResetSystemPei: Change comments of ResetSystem2 > MdeModulePkg/PeiMain: Change comments of PeiResetSystem2 > MdeModulePkg/NvmExpressHci.c: Change comments > BeagleBoardPkg/ResetSystemLib: Add new API ResetSystem > CorebootPayloadPkg/ResetSystemLib: Add new API ResetSystem > Nt32Pkg/ResetSystemLib: Add new API ResetSystem > OvmfPkg/ResetSystemLib: Add new API ResetSystem > PcAtChipsetPkg/ResetSystemLib: Add new API ResetSystem > QuarkSocPkg/ResetSystemLib: Add new API ResetSystem > Vlv2TbltdevicePkg/ResetSystemLib: Add new API ResetSystem > ArmPkg/ArmSmcPsciResetSystemLib: Add a new API ResetSystem > ArmVirtPkg/ArmVirtPsciResetSystemLib: Add a new API ResetSystem >=20 > .../ArmSmcPsciResetSystemLib.c | 44 +++++++++++++++++ > .../ArmVirtPsciResetSystemLib.c | 44 +++++++++++++++++ > .../Library/ResetSystemLib/ResetSystemLib.c | 44 +++++++++++++++++ > .../Library/ResetSystemLib/ResetSystemLib.c | 45 ++++++++++++++++- > .../Bus/Pci/NvmExpressDxe/NvmExpressHci.c | 5 +- > MdeModulePkg/Core/Pei/PeiMain.h | 4 +- > MdeModulePkg/Core/Pei/Reset/Reset.c | 6 +-- > MdeModulePkg/Include/Library/ResetSystemLib.h | 4 +- > .../Include/Library/ResetUtilityLib.h | 34 +++++++++++-- > .../BaseResetSystemLibNull.c | 6 +-- > .../DxeResetSystemLib/DxeResetSystemLib.c | 4 +- > .../PeiResetSystemLib/PeiResetSystemLib.c | 4 +- > .../Library/ResetUtilityLib/ResetUtility.c | 40 +++++++++++++--- > .../RuntimeResetSystemLib.c | 4 +- > .../Universal/ResetSystemPei/ResetSystem.c | 7 +-- > .../Universal/ResetSystemPei/ResetSystem.h | 5 +- > .../ResetSystemRuntimeDxe/ResetSystem.c | 5 +- > .../ResetSystemRuntimeDxe/ResetSystem.h | 5 +- > MdePkg/Include/Library/PeiServicesLib.h | 6 +-- > MdePkg/Include/Pi/PiPeiCis.h | 6 +-- > MdePkg/Include/Uefi/UefiSpec.h | 7 +-- > .../Library/PeiServicesLib/PeiServicesLib.c | 6 +-- > .../Library/ResetSystemLib/ResetSystemLib.c | 45 ++++++++++++++++- > .../Library/ResetSystemLib/ResetSystemLib.c | 45 ++++++++++++++++- > .../Library/ResetSystemLib/ResetSystemLib.c | 48 ++++++++++++++++++- > .../Library/ResetSystemLib/ResetSystemLib.c | 45 ++++++++++++++++- > SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 7 +-- > .../Library/ResetSystemLib/ResetSystemLib.c | 45 ++++++++++++++++- > 28 files changed, 488 insertions(+), 82 deletions(-) >=20 > -- > 2.21.0.windows.1