From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: kelly.steele@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Thu, 25 Apr 2019 14:38:30 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Apr 2019 14:38:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,394,1549958400"; d="scan'208";a="164914464" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by fmsmga002.fm.intel.com with ESMTP; 25 Apr 2019 14:38:29 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.50]) by ORSMSX109.amr.corp.intel.com ([169.254.11.52]) with mapi id 14.03.0415.000; Thu, 25 Apr 2019 14:38:29 -0700 From: "Steele, Kelly" To: "Kinney, Michael D" , "devel@edk2.groups.io" Subject: Re: [Patch] QuarkPlatformPkg/AcpiTables: Resolve iASL warnings Thread-Topic: [Patch] QuarkPlatformPkg/AcpiTables: Resolve iASL warnings Thread-Index: AQHU+5jjpOldR7px3E+f0PV5fRuIQKZNZyjg Date: Thu, 25 Apr 2019 21:38:28 +0000 Message-ID: References: <20190425185832.18256-1-michael.d.kinney@intel.com> In-Reply-To: <20190425185832.18256-1-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWVmZDNiNDEtYWRmYi00YzY2LTg5YzEtNGE3NDg4ZTIxZTlhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiendFNlZyaDJVOGNkZXpGejlsaHRnclA1cm5BVEY2bXhSa2JRem1hUlFaSVlWYnJwTjNPU0swMDVVenphcDFQcyJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Kelly Steele > -----Original Message----- > From: Kinney, Michael D > Sent: April 25, 2019 11:59 > To: devel@edk2.groups.io > Cc: Steele, Kelly > Subject: [Patch] QuarkPlatformPkg/AcpiTables: Resolve iASL warnings >=20 > Resolve a few warnings from the latest iASL compilers. >=20 > Cc: Kelly Steele > Signed-off-by: Michael D Kinney > --- > QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi | 4 ++-- > QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl | 6 +++--- > 2 files changed, 5 insertions(+), 5 deletions(-) >=20 > diff --git a/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi > b/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi > index 979e5b58b1..9a5812d068 100644 > --- a/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi > +++ b/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/GpioClient.asi > @@ -1,7 +1,7 @@ > /** @file > Expose GPIO resources to usermode through client driver. >=20 > -Copyright (c) 2013-2015 Intel Corporation. > +Copyright (c) 2013-2019 Intel Corporation. >=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -11,7 +11,7 @@ Device(GPOT) > { > Name(_HID, "INT349A") > Name(_CID, "INT349A") > - Method(_CRS, 0x0, NotSerialized) > + Method(_CRS, 0x0, Serialized) > { > Name(RBUF, ResourceTemplate() > { > diff --git a/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl > b/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl > index 53633dfbe4..35bae8248a 100644 > --- a/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl > +++ b/QuarkPlatformPkg/Acpi/AcpiTables/Dsdt/Platform.asl > @@ -1,7 +1,7 @@ > /** @file > Contains root level name space objects for the platform >=20 > -Copyright (c) 2013-2015 Intel Corporation. > +Copyright (c) 2013-2019 Intel Corporation. >=20 > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @@ -50,7 +50,7 @@ DefinitionBlock ( > "DSDT", > 1, > "INTEL ", > - "QuarkNcSocId", > + "QuarkNcS", > 3) > { > // > @@ -275,7 +275,7 @@ DefinitionBlock ( > Method (_INI) > { > Store(LINUX, OSTP) // Set the default os= is Linux > - If (CondRefOf (_OSI, local0)) > + If (CondRefOf (_OSI)) > { > // > //_OSI is supported, so it is WinXp or Win2003Server > -- > 2.21.0.windows.1