From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: kelly.steele@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Wed, 08 May 2019 07:49:40 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 May 2019 07:49:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,446,1549958400"; d="scan'208";a="169657843" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by fmsmga002.fm.intel.com with ESMTP; 08 May 2019 07:49:39 -0700 Received: from orsmsx114.amr.corp.intel.com ([169.254.8.50]) by ORSMSX109.amr.corp.intel.com ([169.254.11.52]) with mapi id 14.03.0415.000; Wed, 8 May 2019 07:49:38 -0700 From: "Steele, Kelly" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Gao, Liming" , "Dong, Eric" , "Ni, Ray" , Laszlo Ersek Subject: Re: [Patch V3 0/8] Resolve Quark build and boot issues Thread-Topic: [Patch V3 0/8] Resolve Quark build and boot issues Thread-Index: AQHU/4tJY0/adMv1VUSGpGZ+q9kL66ZhW2Qw Date: Wed, 8 May 2019 14:49:38 +0000 Message-ID: References: <20190430193108.8544-1-michael.d.kinney@intel.com> In-Reply-To: <20190430193108.8544-1-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDBiNWNmNzgtMTYxMi00NjhjLThlY2QtMjBmY2FjN2NjNWY3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiR3dyd1hjT0ZhbTBPbTJXNU83UFZoWFdlcE03aE05WjVqaFo5V2pnV1dPNXNtMVJtSG1UZG1cL0lXXC9sN3BnbXU5In0= x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Kelly Steele > -----Original Message----- > From: Kinney, Michael D > Sent: April 30, 2019 12:31 > To: devel@edk2.groups.io > Cc: Steele, Kelly ; Gao, Liming > ; Dong, Eric ; Ni, Ray > ; Laszlo Ersek > Subject: [Patch V3 0/8] Resolve Quark build and boot issues >=20 > New in V3 > =3D=3D=3D=3D=3D=3D=3D=3D=3D > * Remove change to MpInitLib to avoid use of MSR_IA32_APIC_BASE. That > change > was not safe because an AP could call the PCD Protocol/PPI. > * Add new MpInitLibUp for uni-processor platforms. > * Update Quark DSC files to use MpInitLibUp for uni-processor platforms. > * Add missing CpuLub library class to the CpuMpPei INF file >=20 > New in V2 > =3D=3D=3D=3D=3D=3D=3D=3D=3D > * Add PcdSpeculationBarrierType to select between LFENCE, CPUID, and no > operation in the x86 implementation of the BaseLib function > SpeculationBarrier(). > * Set PcdSpeculationBarrierType to CPUID on Quark platforms. >=20 > This series of patches resolves a few issues with building > and booting Quark platforms. >=20 > * Resolve name collision from API added to ResetSystemLib > * Set SMRAM region to UC when SMRAM region is closed > * Do no use LFENCE if CPU does not support SSE2 > * Avoid MSR_IA32_APIC_BASE if there is only one CPU >=20 > Cc: Kelly Steele > Cc: Liming Gao > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Signed-off-by: Michael D Kinney >=20 > Michael D Kinney (8): > MdePkg: Add PcdSpeculationBarrierType > MdePkg/BaseLib: Use PcdSpeculationBarrierType > QuarkPlatformPkg: Set PcdSpeculationBarrierType to CPUID > UefiCpuPkg/MpInitLibUp: Add uniprocessor MpInitLib > UefiCPuPkg/CpuMpPei: Add missing CpuLib class > QuarkPlatformPkg: Use uniprocessor MpInitLibUp > QuarkSocPkg/SmmAccessDxe: Set region to UC on SMRAM close > QuarkPlatformPkg/PlatformInit: Resolve ResetSystemLib name collision >=20 > MdePkg/Library/BaseLib/BaseLib.inf | 1 + > .../Library/BaseLib/X86SpeculationBarrier.c | 8 +- > MdePkg/MdePkg.dec | 9 + > MdePkg/MdePkg.uni | 8 + > .../Pei/PlatformInit/MemoryCallback.c | 6 +- > .../Pei/PlatformInit/PlatformEarlyInit.h | 4 +- > QuarkPlatformPkg/Quark.dsc | 10 +- > QuarkPlatformPkg/QuarkMin.dsc | 8 +- > .../Smm/Dxe/SmmAccessDxe/SmmAccess.inf | 3 +- > .../Smm/Dxe/SmmAccessDxe/SmmAccessDriver.c | 18 +- > .../Smm/Dxe/SmmAccessDxe/SmmAccessDriver.h | 3 +- > UefiCpuPkg/CpuMpPei/CpuMpPei.inf | 3 +- > UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c | 407 > ++++++++++++++++++ > .../Library/MpInitLibUp/MpInitLibUp.inf | 37 ++ > .../Library/MpInitLibUp/MpInitLibUp.uni | 14 + > UefiCpuPkg/UefiCpuPkg.dsc | 3 +- > 16 files changed, 525 insertions(+), 17 deletions(-) > create mode 100644 UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c > create mode 100644 UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.inf > create mode 100644 UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.uni >=20 > -- > 2.21.0.windows.1