From: "You, Benjamin" <benjamin.you@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ma, Maurice" <maurice.ma@intel.com>,
"Agyeman, Prince" <prince.agyeman@intel.com>
Subject: Re: [PATCH v3 5/6] CorebootPayloadPkg: Fix build failure due to Tftp/Dp library removal
Date: Wed, 29 Nov 2017 01:51:12 +0000 [thread overview]
Message-ID: <E748835C6D8DB54B8E8AF33091ECC57C62131E7B@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20171129005952.208940-6-ruiyu.ni@intel.com>
Reviewed-by: Benjamin You <benjamin.you@intel.com>
> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Wednesday, November 29, 2017 9:00 AM
> To: edk2-devel@lists.01.org
> Cc: Ma, Maurice <maurice.ma@intel.com>; Agyeman, Prince
> <prince.agyeman@intel.com>; You, Benjamin <benjamin.you@intel.com>
> Subject: [PATCH v3 5/6] CorebootPayloadPkg: Fix build failure due to Tftp/Dp
> library removal
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Prince Agyeman <prince.agyeman@intel.com>
> Cc: Benjamin You <benjamin.you@intel.com>
> ---
> CorebootPayloadPkg/CorebootPayloadPkg.fdf | 4 ++-
> CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc | 36 +++++++++++++------
> -----
> CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 36 +++++++++++++----
> -------
> 3 files changed, 41 insertions(+), 35 deletions(-)
>
> diff --git a/CorebootPayloadPkg/CorebootPayloadPkg.fdf
> b/CorebootPayloadPkg/CorebootPayloadPkg.fdf
> index 303e626842..7994f0c949 100644
> --- a/CorebootPayloadPkg/CorebootPayloadPkg.fdf
> +++ b/CorebootPayloadPkg/CorebootPayloadPkg.fdf
> @@ -3,7 +3,7 @@
> #
> # Provides drivers and definitions to create uefi payload for coreboot.
> #
> -# Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2014 - 2017, Intel Corporation. All rights reserved.<BR>
> # This program and the accompanying materials are licensed and made
> available under
> # the terms and conditions of the BSD License that accompanies this distribution.
> # The full text of the license may be found at
> @@ -180,6 +180,8 @@ [FV.DXEFV]
> # Shell
> #
> !if $(SHELL_TYPE) == BUILD_SHELL
> +INF
> ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
> +INF
> ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf
> INF ShellPkg/Application/Shell/Shell.inf
> !endif
>
> diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
> b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
> index cdfcb75b59..ace1bc0a37 100644
> --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
> +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
> @@ -3,7 +3,7 @@
> #
> # Provides drivers and definitions to create uefi payload for coreboot.
> #
> -# Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2014 - 2017, Intel Corporation. All rights reserved.<BR>
> # This program and the accompanying materials are licensed and made
> available under
> # the terms and conditions of the BSD License that accompanies this distribution.
> # The full text of the license may be found at
> @@ -515,11 +515,6 @@ [Components.IA32]
>
> !if $(SHELL_TYPE) == BUILD_SHELL
>
> -[PcdsFixedAtBuild]
> - ## This flag is used to control initialization of the shell library
> - # This should be FALSE for compiling the shell application itself only.
> - gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> -
> #
> # Shell Lib
> #
> @@ -527,9 +522,27 @@ [LibraryClasses]
>
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCo
> mmandLib.inf
> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf
> + ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> + NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf
>
> [Components.IA32]
> +
> ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
> {
> + <PcdsFixedAtBuild>
> + ## This flag is used to control initialization of the shell library
> + # This should be FALSE for compiling the dynamic command.
> + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> + }
> + ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf {
> + <PcdsFixedAtBuild>
> + ## This flag is used to control initialization of the shell library
> + # This should be FALSE for compiling the dynamic command.
> + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> + }
> ShellPkg/Application/Shell/Shell.inf {
> + <PcdsFixedAtBuild>
> + ## This flag is used to control initialization of the shell library
> + # This should be FALSE for compiling the shell application itself only.
> + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
>
> #------------------------------
> # Basic commands
> @@ -549,14 +562,6 @@ [Components.IA32]
>
> <LibraryClasses>
>
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Co
> mmandsLib.inf
> -
> NULL|ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.inf
> -
> - #------------------------------
> - # Performance command
> - #------------------------------
> -
> - <LibraryClasses>
> - NULL|ShellPkg/Library/UefiDpLib/UefiDpLib.inf
>
> #------------------------------
> # Support libraries
> @@ -565,13 +570,10 @@ [Components.IA32]
> <LibraryClasses>
> DebugLib|MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf
> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> - FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf
>
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.i
> nf
> - NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf
> PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
>
> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLi
> b.inf
> - ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
> }
>
> diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
> b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
> index 6b16af63ba..2492142b97 100644
> --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
> +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
> @@ -3,7 +3,7 @@
> #
> # Provides drivers and definitions to create uefi payload for coreboot.
> #
> -# Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2014 - 2017, Intel Corporation. All rights reserved.<BR>
> # This program and the accompanying materials are licensed and made
> available under
> # the terms and conditions of the BSD License that accompanies this distribution.
> # The full text of the license may be found at
> @@ -516,11 +516,6 @@ [Components.X64]
>
> !if $(SHELL_TYPE) == BUILD_SHELL
>
> -[PcdsFixedAtBuild]
> - ## This flag is used to control initialization of the shell library
> - # This should be FALSE for compiling the shell application itself only.
> - gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> -
> #
> # Shell Lib
> #
> @@ -528,9 +523,27 @@ [LibraryClasses]
>
> BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCo
> mmandLib.inf
> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf
> + ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> + NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf
>
> [Components.X64]
> +
> ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf
> {
> + <PcdsFixedAtBuild>
> + ## This flag is used to control initialization of the shell library
> + # This should be FALSE for compiling the dynamic command.
> + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> + }
> + ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf {
> + <PcdsFixedAtBuild>
> + ## This flag is used to control initialization of the shell library
> + # This should be FALSE for compiling the dynamic command.
> + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
> + }
> ShellPkg/Application/Shell/Shell.inf {
> + <PcdsFixedAtBuild>
> + ## This flag is used to control initialization of the shell library
> + # This should be FALSE for compiling the shell application itself only.
> + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE
>
> #------------------------------
> # Basic commands
> @@ -550,14 +563,6 @@ [Components.X64]
>
> <LibraryClasses>
>
> NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Co
> mmandsLib.inf
> -
> NULL|ShellPkg/Library/UefiShellTftpCommandLib/UefiShellTftpCommandLib.inf
> -
> - #------------------------------
> - # Performance command
> - #------------------------------
> -
> - <LibraryClasses>
> - NULL|ShellPkg/Library/UefiDpLib/UefiDpLib.inf
>
> #------------------------------
> # Support libraries
> @@ -566,13 +571,10 @@ [Components.X64]
> <LibraryClasses>
> DebugLib|MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf
> DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> - FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf
>
> HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsingLib.i
> nf
> - NetLib|MdeModulePkg/Library/DxeNetLib/DxeNetLib.inf
> PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
> ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntryLib.inf
>
> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLi
> b.inf
> - ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf
> SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf
> }
>
> --
> 2.15.0.gvfs.1.preview.4
next prev parent reply other threads:[~2017-11-29 1:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 0:59 [PATCH v3 0/6] Fix build failure due to tftp/dp library removal Ruiyu Ni
2017-11-29 0:59 ` [PATCH v3 1/6] ShellPkg/tftp: Correct file comments header of Tftp.uni Ruiyu Ni
2017-11-29 0:59 ` [PATCH v3 2/6] EmulatorPkg: Fix build failure due to Tftp library removal Ruiyu Ni
2017-11-29 0:59 ` [PATCH v3 3/6] ArmVirtPkg: " Ruiyu Ni
2017-11-29 9:36 ` Ni, Ruiyu
2017-11-29 9:44 ` Ard Biesheuvel
2017-11-29 9:57 ` Ni, Ruiyu
2017-11-29 9:59 ` Ard Biesheuvel
2017-11-29 10:03 ` Ni, Ruiyu
2017-11-29 10:05 ` Ard Biesheuvel
2017-11-29 11:06 ` Laszlo Ersek
2017-11-29 0:59 ` [PATCH v3 4/6] BeagleBoardPkg: " Ruiyu Ni
2017-11-29 7:57 ` Ard Biesheuvel
2017-11-29 8:28 ` Ni, Ruiyu
2017-11-29 8:40 ` Ard Biesheuvel
2017-11-29 0:59 ` [PATCH v3 5/6] CorebootPayloadPkg: Fix build failure due to Tftp/Dp " Ruiyu Ni
2017-11-29 1:51 ` You, Benjamin [this message]
2017-11-29 0:59 ` [PATCH v3 6/6] OvmfPkg: Add tftp dynamic command Ruiyu Ni
2017-11-29 10:53 ` Laszlo Ersek
2017-11-29 13:12 ` Ni, Ruiyu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E748835C6D8DB54B8E8AF33091ECC57C62131E7B@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox