From: "You, Benjamin" <benjamin.you@intel.com>
To: "arthur@aheymans.xyz" <arthur@aheymans.xyz>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] CorebootPayloadPkg: Use correct BytesPerScanLine
Date: Tue, 30 Jan 2018 06:15:29 +0000 [thread overview]
Message-ID: <E748835C6D8DB54B8E8AF33091ECC57C6214D4F0@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20180124105736.14877-1-arthur@aheymans.xyz>
Reviewed-by: Benjamin You <benjamin.you@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> arthur@aheymans.xyz
> Sent: Wednesday, January 24, 2018 6:58 PM
> To: edk2-devel@lists.01.org
> Cc: Arthur Heymans <arthur@aheymans.xyz>
> Subject: [edk2] [PATCH] CorebootPayloadPkg: Use correct BytesPerScanLine
>
> From: Arthur Heymans <arthur@aheymans.xyz>
>
> Fetch BytesPerScanLine from coreboot table to reflect how the actual
> framebuffer is set up instead of guessing it from the horizontal
> resolution.
>
> This fixes a garbled display when HorizontalResolution * (BitsPerPixel
> / 8) and pFbInfo->BytesPerScanLine don't match.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
>
> diff --git a/CorebootPayloadPkg/FbGop/FbGop.c
> b/CorebootPayloadPkg/FbGop/FbGop.c
> index 37d6def7f7..6790617033 100644
> --- a/CorebootPayloadPkg/FbGop/FbGop.c
> +++ b/CorebootPayloadPkg/FbGop/FbGop.c
> @@ -822,7 +822,7 @@ FbGopCheckForVbe (
> BitsPerPixel = pFbInfo->BitsPerPixel;
> HorizontalResolution = pFbInfo->HorizontalResolution;
> VerticalResolution = pFbInfo->VerticalResolution;
> - BytesPerScanLine = HorizontalResolution * (BitsPerPixel / 8);
> + BytesPerScanLine = pFbInfo->BytesPerScanLine;
>
> ModeBuffer = (FB_VIDEO_MODE_DATA *) AllocatePool (
>
>
> ModeNumber * sizeof
> (FB_VIDEO_MODE_DATA)
> --
> 2.16.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2018-01-30 6:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 10:57 [PATCH] CorebootPayloadPkg: Use correct BytesPerScanLine arthur
2018-01-25 5:34 ` You, Benjamin
2018-01-25 9:03 ` Arthur Heymans
2018-01-26 8:40 ` You, Benjamin
2018-01-26 9:08 ` Arthur Heymans
2018-01-27 4:11 ` You, Benjamin
2018-01-27 10:17 ` Arthur Heymans
2018-01-27 14:14 ` Nico Huber
2018-01-28 8:49 ` You, Benjamin
2018-01-28 14:33 ` Nico Huber
2018-01-29 1:09 ` You, Benjamin
2018-01-29 5:36 ` You, Benjamin
2018-01-30 6:15 ` You, Benjamin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E748835C6D8DB54B8E8AF33091ECC57C6214D4F0@SHSMSX103.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox