public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "You, Benjamin" <benjamin.you@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ma, Maurice" <maurice.ma@intel.com>,
	"Agyeman, Prince" <prince.agyeman@intel.com>
Subject: Re: [PATCH v3 2/7] CorebootPayload/PlatformBDS: Impl PlatformBootManagerUnableToBoot
Date: Tue, 3 Jul 2018 22:58:57 +0000	[thread overview]
Message-ID: <E748835C6D8DB54B8E8AF33091ECC57C6222996E@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <20180703063743.373172-3-ruiyu.ni@intel.com>

Reviewed-by: Benjamin You <benjamin.you@intel.com>

> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Tuesday, July 3, 2018 2:38 PM
> To: edk2-devel@lists.01.org
> Cc: Ma, Maurice <maurice.ma@intel.com>; Agyeman, Prince
> <prince.agyeman@intel.com>; You, Benjamin <benjamin.you@intel.com>
> Subject: [PATCH v3 2/7] CorebootPayload/PlatformBDS: Impl
> PlatformBootManagerUnableToBoot
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Prince Agyeman <prince.agyeman@intel.com>
> Cc: Benjamin You <benjamin.you@intel.com>
> ---
>  .../PlatformBootManagerLib/PlatformBootManager.c      | 19
> ++++++++++++++++++-
>  1 file changed, 18 insertions(+), 1 deletion(-)
> 
> diff --git
> a/CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManage
> r.c
> b/CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManage
> r.c
> index 7e92441da1..368e89d586 100644
> ---
> a/CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManage
> r.c
> +++
> b/CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManage
> r.c
> @@ -2,7 +2,7 @@
>    This file include all platform action which can be customized
>    by IBV/OEM.
> 
> -Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.<BR>
>  This program and the accompanying materials
>  are licensed and made available under the terms and conditions of the BSD
> License
>  which accompanies this distribution.  The full text of the license may be found
> at
> @@ -252,3 +252,20 @@ PlatformBootManagerWaitCallback (
>  {
>    return;
>  }
> +
> +/**
> +  The function is called when no boot option could be launched,
> +  including platform recovery options and options pointing to applications
> +  built into firmware volumes.
> +
> +  If this function returns, BDS attempts to enter an infinite loop.
> +**/
> +VOID
> +EFIAPI
> +PlatformBootManagerUnableToBoot (
> +  VOID
> +  )
> +{
> +  return;
> +}
> +
> --
> 2.16.1.windows.1



  reply	other threads:[~2018-07-03 22:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-03  6:37 [PATCH v3 0/7] Add platform hook for ultimate boot failure Ruiyu Ni
2018-07-03  6:37 ` [PATCH v3 1/7] MdeModulePkg/PlatformBootManager: Add PlatformBootManagerUnableToBoot Ruiyu Ni
2018-07-03 15:27   ` Laszlo Ersek
2018-07-03  6:37 ` [PATCH v3 2/7] CorebootPayload/PlatformBDS: Impl PlatformBootManagerUnableToBoot Ruiyu Ni
2018-07-03 22:58   ` You, Benjamin [this message]
2018-07-03  6:37 ` [PATCH v3 3/7] OvmfPkg/PlatformBds: Implement PlatformBootManagerUnableToBoot Ruiyu Ni
2018-07-03 15:37   ` Laszlo Ersek
2018-07-04  1:27     ` Ni, Ruiyu
2018-07-03  6:37 ` [PATCH v3 4/7] Nt32Pkg/PlatformBDS: " Ruiyu Ni
2018-07-04  1:09   ` Wu, Hao A
2018-07-03  6:37 ` [PATCH v3 5/7] QuarkPlatform/PlatformBDS: " Ruiyu Ni
2018-07-03  6:37 ` [PATCH v3 6/7] MdeModulePkg/BdsDxe: Revert "fall back to UI loop before hanging" Ruiyu Ni
2018-07-03 15:28   ` Laszlo Ersek
2018-07-03  6:37 ` [PATCH v3 7/7] MdeModulePkg/BdsDxe: Call PlatformBootManagerUnableToBoot() Ruiyu Ni
2018-07-03 15:29   ` Laszlo Ersek
2018-07-03 15:52 ` [PATCH v3 0/7] Add platform hook for ultimate boot failure Laszlo Ersek
2018-07-04  1:08   ` Ni, Ruiyu
2018-07-04  1:46     ` Ni, Ruiyu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E748835C6D8DB54B8E8AF33091ECC57C6222996E@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox