public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "You, Benjamin" <benjamin.you@intel.com>
To: "Chen, Chen A" <chen.a.chen@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ma, Maurice" <maurice.ma@intel.com>,
	"Agyeman, Prince" <prince.agyeman@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH 07/37] CorebootPayloadPkg: Removing ipf from edk2.
Date: Wed, 11 Jul 2018 06:08:11 +0000	[thread overview]
Message-ID: <E748835C6D8DB54B8E8AF33091ECC57C62237089@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20180613034333.13168-1-chen.a.chen@intel.com>

Reviewed-by: Benjamin You <benjamin.you@intel.com>

> -----Original Message-----
> From: Chen, Chen A
> Sent: Wednesday, June 13, 2018 11:44 AM
> To: edk2-devel@lists.01.org
> Cc: Chen, Chen A <chen.a.chen@intel.com>; Ma, Maurice
> <maurice.ma@intel.com>; Agyeman, Prince <prince.agyeman@intel.com>; You,
> Benjamin <benjamin.you@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: [PATCH 07/37] CorebootPayloadPkg: Removing ipf from edk2.
> 
> Removing rules for Ipf sources file:
> * Remove the source file which path with "ipf" and also listed in
>   [Sources.IPF] section of INF file.
> * Remove the source file which listed in [Components.IPF] section
>   of DSC file and not listed in any other [Components] section.
> * Remove the embedded Ipf code for MDE_CPU_IPF.
> 
> Removing rules for Inf file:
> * Remove IPF from VALID_ARCHITECTURES comments.
> * Remove DXE_SAL_DRIVER from LIBRARY_CLASS in [Defines] section.
> * Remove the INF which only listed in [Components.IPF] section in DSC.
> * Remove statements from [BuildOptions] that provide IPF specific flags.
> * Remove any IPF sepcific sections.
> 
> Removing rules for Dec file:
> * Remove [Includes.IPF] section from Dec.
> 
> Removing rules for Dsc file:
> * Remove IPF from SUPPORTED_ARCHITECTURES in [Defines] section of DSC.
> * Remove any IPF specific sections.
> * Remove statements from [BuildOptions] that provide IPF specific flags.
> 
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Prince Agyeman <prince.agyeman@intel.com>
> Cc: Benjamin You <benjamin.you@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: chenc2 <chen.a.chen@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> ---
>  CorebootPayloadPkg/FbGop/FbGop.inf                               | 2 +-
>  CorebootPayloadPkg/Library/AcpiTimerLib/AcpiTimerLib.inf         | 4 ++--
>  CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 2 +-
>  CorebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.inf     | 2 +-
>  4 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/CorebootPayloadPkg/FbGop/FbGop.inf
> b/CorebootPayloadPkg/FbGop/FbGop.inf
> index 0d97387679..b95add240b 100644
> --- a/CorebootPayloadPkg/FbGop/FbGop.inf
> +++ b/CorebootPayloadPkg/FbGop/FbGop.inf
> @@ -29,7 +29,7 @@
>  #
>  # The following information is for reference only and not required by the build
> tools.
>  #
> -#  VALID_ARCHITECTURES           = IA32 X64 IPF EBC
> +#  VALID_ARCHITECTURES           = IA32 X64 EBC
>  #
>  #  DRIVER_BINDING                =  gBiosVideoDriverBinding
>  #  COMPONENT_NAME                =  gBiosVideoComponentName
> diff --git a/CorebootPayloadPkg/Library/AcpiTimerLib/AcpiTimerLib.inf
> b/CorebootPayloadPkg/Library/AcpiTimerLib/AcpiTimerLib.inf
> index 2bff61094a..4c5684cb09 100644
> --- a/CorebootPayloadPkg/Library/AcpiTimerLib/AcpiTimerLib.inf
> +++ b/CorebootPayloadPkg/Library/AcpiTimerLib/AcpiTimerLib.inf
> @@ -25,7 +25,7 @@
>  #
>  # The following information is for reference only and not required by the build
> tools.
>  #
> -#  VALID_ARCHITECTURES           = IA32 X64 IPF EBC
> +#  VALID_ARCHITECTURES           = IA32 X64 EBC
>  #
> 
>  [Sources]
> @@ -43,4 +43,4 @@
>    DebugLib
> 
>  [Guids]
> -  gUefiAcpiBoardInfoGuid
> \ No newline at end of file
> +  gUefiAcpiBoardInfoGuid
> diff --git a/CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf
> b/CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf
> index 15ffb45f84..7fc1326a70 100644
> --- a/CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf
> +++ b/CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf
> @@ -27,7 +27,7 @@
>  # The following information is for reference only and not required by the build
>  # tools.
>  #
> -#  VALID_ARCHITECTURES           = IA32 X64 IPF EBC
> +#  VALID_ARCHITECTURES           = IA32 X64 EBC
>  #
> 
>  [Sources]
> diff --git a/CorebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.inf
> b/CorebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.inf
> index 1af96c6e23..9e025ecee2 100644
> --- a/CorebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.inf
> +++ b/CorebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.inf
> @@ -23,7 +23,7 @@
>  #
>  # The following information is for reference only and not required by the build
> tools.
>  #
> -#  VALID_ARCHITECTURES           = IA32 X64 IPF
> +#  VALID_ARCHITECTURES           = IA32 X64
>  #
> 
>  [Sources]
> --
> 2.16.2.windows.1



      reply	other threads:[~2018-07-11  6:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-13  3:43 [PATCH 07/37] CorebootPayloadPkg: Removing ipf from edk2 chenc2
2018-07-11  6:08 ` You, Benjamin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E748835C6D8DB54B8E8AF33091ECC57C62237089@SHSMSX103.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox