Re: [PATCH] CorebootPayloadPkg: don't use serial output for Release build

["You, Benjamin" <benjamin.you@intel.com>]

Hi,

Reviewed-by: Benjamin You <benjamin.you@intel.com>

Thanks,

- ben

> -----Original Message-----
> From: Wonkyu Kim [mailto:norwayforest92@gmail.com]
> Sent: Tuesday, October 16, 2018 6:45 AM
> To: edk2-devel@lists.01.org
> Cc: You, Benjamin <benjamin.you@intel.com>; Agyeman, Prince
> <prince.agyeman@intel.com>; gaumless@gmail.com;
> stefan.reinauer@coreboot.org; Williams, Hannah <hannah.williams@intel.com>;
> Kim, Wonkyu <wonkyu.kim@intel.com>; Zhao, Lijian <lijian.zhao@intel.com>
> Subject: [PATCH] CorebootPayloadPkg: don't use serial output for Release build
> 
> From: Wonkyu Kim <wonkyu.kim@intel.com>
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Wonkyu Kim <wonkyu.kim@intel.com>
> ---
>  CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc    | 4 ++++
>  CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 4 ++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
> b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
> index b6cdb697a5b0..7d5052be9301 100644
> --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
> +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
> @@ -263,7 +263,11 @@
>  #
> 
> #################################################################
> ###############
>  [PcdsFeatureFlag]
> +!if $(TARGET) == DEBUG
>    gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
> +!else
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE
> +!endif
>    gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE
>    gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|FALSE
>    gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
> diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
> b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
> index c3fe099e5fec..0484e941cce7 100644
> --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
> +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
> @@ -263,7 +263,11 @@
>  #
> 
> #################################################################
> ###############
>  [PcdsFeatureFlag]
> +!if $(TARGET) == DEBUG
>    gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
> +!else
> +  gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE
> +!endif
>    gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE
>    gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE
>    gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
> --
> 2.17.1