From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.126; helo=mga18.intel.com; envelope-from=benjamin.you@intel.com; receiver=edk2-devel@lists.01.org Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 31BAF211799F7 for ; Tue, 16 Oct 2018 19:45:16 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Oct 2018 19:45:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,389,1534834800"; d="scan'208";a="98076811" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 16 Oct 2018 19:45:15 -0700 Received: from fmsmsx120.amr.corp.intel.com (10.18.124.208) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 16 Oct 2018 19:45:15 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx120.amr.corp.intel.com (10.18.124.208) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 16 Oct 2018 19:45:15 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.111]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.183]) with mapi id 14.03.0319.002; Wed, 17 Oct 2018 10:45:10 +0800 From: "You, Benjamin" To: Wonkyu Kim , "edk2-devel@lists.01.org" CC: "Agyeman, Prince" , "gaumless@gmail.com" , "stefan.reinauer@coreboot.org" , "Williams, Hannah" , "Kim, Wonkyu" , "Zhao, Lijian" Thread-Topic: [PATCH] CorebootPayloadPkg: don't use serial output for Release build Thread-Index: AQHUZNilxzwx40VRhEqi4WeJlykBRqUivP7Q Date: Wed, 17 Oct 2018 02:45:10 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYjQzYWM3MWItZDgyYS00ZWVkLTkxZTgtMjA3NzhhZGQ5MGI4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiaXc5UXdtOTlkeWpDUHkyVzVrSDBJOFJrSkozcjIxOGVpeUhOcDc1dEg0eUJcL2xUYnYwTXdUV1l1KzBIWkk1a08ifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] CorebootPayloadPkg: don't use serial output for Release build X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2018 02:45:16 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Reviewed-by: Benjamin You Thanks, - ben > -----Original Message----- > From: Wonkyu Kim [mailto:norwayforest92@gmail.com] > Sent: Tuesday, October 16, 2018 6:45 AM > To: edk2-devel@lists.01.org > Cc: You, Benjamin ; Agyeman, Prince > ; gaumless@gmail.com; > stefan.reinauer@coreboot.org; Williams, Hannah ; > Kim, Wonkyu ; Zhao, Lijian > Subject: [PATCH] CorebootPayloadPkg: don't use serial output for Release = build >=20 > From: Wonkyu Kim >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Wonkyu Kim > --- > CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc | 4 ++++ > CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 4 ++++ > 2 files changed, 8 insertions(+) >=20 > diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc > b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc > index b6cdb697a5b0..7d5052be9301 100644 > --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc > +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc > @@ -263,7 +263,11 @@ > # >=20 > ################################################################# > ############### > [PcdsFeatureFlag] > +!if $(TARGET) =3D=3D DEBUG > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE > +!else > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE > +!endif > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE > diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc > b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc > index c3fe099e5fec..0484e941cce7 100644 > --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc > +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc > @@ -263,7 +263,11 @@ > # >=20 > ################################################################# > ############### > [PcdsFeatureFlag] > +!if $(TARGET) =3D=3D DEBUG > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE > +!else > + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE > +!endif > gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE > -- > 2.17.1