From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=benjamin.you@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D0B4B208EB41A for ; Sun, 10 Feb 2019 17:01:37 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Feb 2019 17:01:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,357,1544515200"; d="scan'208";a="319263178" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga005.fm.intel.com with ESMTP; 10 Feb 2019 17:01:36 -0800 Received: from fmsmsx161.amr.corp.intel.com (10.18.125.9) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 10 Feb 2019 17:01:36 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX161.amr.corp.intel.com (10.18.125.9) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 10 Feb 2019 17:01:36 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.194]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.110]) with mapi id 14.03.0415.000; Mon, 11 Feb 2019 09:01:34 +0800 From: "You, Benjamin" To: Antoine Coeur , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH] CorebootPayloadPkg: Fix various typos Thread-Index: AQHUvj4ERJtNkPT0+keIispROcS+66XZzhyw Date: Mon, 11 Feb 2019 01:01:34 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGJmMTNkZWMtYmYxYi00YTRhLThmZWYtNWRmZDNiNzEyNGE0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZHVXNHlFcE5pT3Jxa3R1ZXBqdUtVU013Vlp6YVM4MnZxR2xwMUcyYUxJV21Nd3FKenczOFc1SnJqRk40SFNYSCJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] CorebootPayloadPkg: Fix various typos X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Feb 2019 01:01:38 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Benjamin You > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Antoine Coeur > Sent: Thursday, February 7, 2019 12:49 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH] CorebootPayloadPkg: Fix various typos >=20 > Fix various typos in CorebootPayloadPkg. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Coeur > --- > CorebootPayloadPkg/FbGop/FbGop.c | 8 +- > CorebootPayloadPkg/FbGop/FbGop.h | 8 +- > .../Library/PciHostBridgeLib/PciHostBridge.h | 2 +- > .../PciHostBridgeLib/PciHostBridgeLib.c | 2 +- > .../PciHostBridgeLib/PciHostBridgeSupport.c | 6 +- > .../PlatformBootManager.c | 2 +- > .../Library/PlatformHookLib/PlatformHookLib.c | 106 +++++++++--------- > 7 files changed, 67 insertions(+), 67 deletions(-) >=20 > diff --git a/CorebootPayloadPkg/FbGop/FbGop.c > b/CorebootPayloadPkg/FbGop/FbGop.c > index ecafc95ae3..9a66943cbf 100644 > --- a/CorebootPayloadPkg/FbGop/FbGop.c > +++ b/CorebootPayloadPkg/FbGop/FbGop.c > @@ -262,7 +262,7 @@ FbGopDriverBindingStart ( > if (IsDevicePathEnd (RemainingDevicePath)) { > // > // If RemainingDevicePath is the End of Device Path Node, > - // don't create any child device and return EFI_SUCESS > + // don't create any child device and return EFI_SUCCESS > Status =3D EFI_SUCCESS; > goto Done; > } > @@ -688,7 +688,7 @@ FbGopChildHandleUninstall ( >=20 >=20 > /** > - Release resource for biso video instance. > + Release resource for bios video instance. >=20 > @param FbGopPrivate Video child device private data structure >=20 > @@ -703,7 +703,7 @@ FbGopDeviceReleaseResource ( > } >=20 > // > - // Release all the resourses occupied by the FB_VIDEO_DEV > + // Release all the resources occupied by the FB_VIDEO_DEV > // >=20 > // > @@ -1222,7 +1222,7 @@ FbGopVbeBltWorker ( > } > // > // We need to fill the Virtual Screen buffer with the blt data. > - // The virtual screen is upside down, as the first row is the bootom r= ow of > + // The virtual screen is upside down, as the first row is the bottom r= ow of > // the image. > // > if (BltOperation =3D=3D EfiBltVideoToBltBuffer) { > diff --git a/CorebootPayloadPkg/FbGop/FbGop.h > b/CorebootPayloadPkg/FbGop/FbGop.h > index 4445f5c730..112d5c5cb5 100644 > --- a/CorebootPayloadPkg/FbGop/FbGop.h > +++ b/CorebootPayloadPkg/FbGop/FbGop.h > @@ -205,7 +205,7 @@ FbGopCheckForVbe ( >=20 >=20 > /** > - Release resource for biso video instance. > + Release resource for bios video instance. >=20 > @param FbGopPrivate Video child device private data structure >=20 > @@ -311,9 +311,9 @@ FbGopGraphicsOutputVbeBlt ( >=20 >=20 > /** > - Grahpics Output protocol instance to block transfer for VGA device. > + Graphics Output protocol instance to block transfer for VGA device. >=20 > - @param This Pointer to Grahpics Output protocol ins= tance > + @param This Pointer to Graphics Output protocol ins= tance > @param BltBuffer The data to transfer to screen > @param BltOperation The operation to perform > @param SourceX The X coordinate of the source for BltO= peration > @@ -394,7 +394,7 @@ FbGopChildHandleUninstall ( > ); >=20 > /** > - Release resource for biso video instance. > + Release resource for bios video instance. >=20 > @param FbGopPrivate Video child device private data structure >=20 > diff --git a/CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridge.h > b/CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridge.h > index 4852ed0d8d..c777cdbac1 100644 > --- a/CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridge.h > +++ b/CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridge.h > @@ -42,7 +42,7 @@ ScanForRootBridges ( > assigned to any subordinate bus found beh= ind any > PCI bridge hanging off this root bus. >=20 > - The caller is repsonsible for ensuring th= at > + The caller is responsible for ensuring th= at > RootBusNumber <=3D MaxSubBusNumber. If > RootBusNumber equals MaxSubBusNumber, the= n the > root bus has no room for subordinate buse= s. > diff --git a/CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeLib= .c > b/CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c > index b0a6361557..f7e1369a08 100644 > --- a/CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c > +++ b/CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c > @@ -70,7 +70,7 @@ CB_PCI_ROOT_BRIDGE_DEVICE_PATH > mRootBridgeDevicePathTemplate =3D { > assigned to any subordinate bus found beh= ind any > PCI bridge hanging off this root bus. >=20 > - The caller is repsonsible for ensuring th= at > + The caller is responsible for ensuring th= at > RootBusNumber <=3D MaxSubBusNumber. If > RootBusNumber equals MaxSubBusNumber, the= n the > root bus has no room for subordinate buse= s. > diff --git > a/CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c > b/CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c > index 18dcbafdf0..d06db1e12e 100644 > --- a/CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c > +++ b/CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c > @@ -146,7 +146,7 @@ PcatPciRootBridgeBarExisted ( > } >=20 > /** > - Parse PCI bar and collect the assigned PCI resouce information. > + Parse PCI bar and collect the assigned PCI resource information. >=20 > @param[in] Command Supported attributes. >=20 > @@ -397,7 +397,7 @@ ScanForRootBridges ( > // > if (Pci.Bridge.SubordinateBus > SubBus) { > // > - // If the suborinate bus number of the PCI-PCI bridge is gre= ater > + // If the subordinate bus number of the PCI-PCI bridge is gr= eater > // than the PCI root bridge's current subordinate bus number= , > // then update the PCI root bridge's subordinate bus number > // > @@ -536,7 +536,7 @@ ScanForRootBridges ( >=20 > // > // See if the PCI Device is a PCI - ISA or PCI - EISA > - // or ISA_POSITIVIE_DECODE Bridge device > + // or ISA_POSITIVE_DECODE Bridge device > // > if (Pci.Hdr.ClassCode[2] =3D=3D PCI_CLASS_BRIDGE) { > if (Pci.Hdr.ClassCode[1] =3D=3D PCI_CLASS_BRIDGE_ISA || > diff --git > a/CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManage > r.c > b/CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManage > r.c > index 368e89d586..0b180dad32 100644 > --- > a/CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManage > r.c > +++ > b/CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManage > r.c > @@ -208,7 +208,7 @@ PlatformBootManagerBeforeConsole ( > Signal console ready platform customized event; > Run diagnostics like memory testing; > Connect certain devices; > - Dispatch aditional option roms. > + Dispatch additional option roms. > **/ > VOID > EFIAPI > diff --git a/CorebootPayloadPkg/Library/PlatformHookLib/PlatformHookLib.c > b/CorebootPayloadPkg/Library/PlatformHookLib/PlatformHookLib.c > index b1cfb8e2c0..83bf0eba08 100644 > --- a/CorebootPayloadPkg/Library/PlatformHookLib/PlatformHookLib.c > +++ b/CorebootPayloadPkg/Library/PlatformHookLib/PlatformHookLib.c > @@ -14,27 +14,27 @@ >=20 > #include > #include > -#include > +#include > #include > #include > #include >=20 > -typedef struct { > - UINT16 VendorId; ///< Vendor ID to match the PCI device. Th= e value > 0xFFFF terminates the list of entries. > - UINT16 DeviceId; ///< Device ID to match the PCI device > - UINT32 ClockRate; ///< UART clock rate. Set to 0 for default= clock rate > of 1843200 Hz > - UINT64 Offset; ///< The byte offset into to the BAR > - UINT8 BarIndex; ///< Which BAR to get the UART base address > - UINT8 RegisterStride; ///< UART register stride in bytes. Set to= 0 for default > register stride of 1 byte. > - UINT16 ReceiveFifoDepth; ///< UART receive FIFO depth in bytes. Set = to 0 for > a default FIFO depth of 16 bytes. > - UINT16 TransmitFifoDepth; ///< UART transmit FIFO depth in bytes. Set= to 0 > for a default FIFO depth of 16 bytes. > - UINT8 Reserved[2]; > -} PCI_SERIAL_PARAMETER; > - > +typedef struct { > + UINT16 VendorId; ///< Vendor ID to match the PCI device. Th= e value > 0xFFFF terminates the list of entries. > + UINT16 DeviceId; ///< Device ID to match the PCI device > + UINT32 ClockRate; ///< UART clock rate. Set to 0 for default= clock rate > of 1843200 Hz > + UINT64 Offset; ///< The byte offset into to the BAR > + UINT8 BarIndex; ///< Which BAR to get the UART base address > + UINT8 RegisterStride; ///< UART register stride in bytes. Set to= 0 for > default register stride of 1 byte. > + UINT16 ReceiveFifoDepth; ///< UART receive FIFO depth in bytes. Set = to 0 > for a default FIFO depth of 16 bytes. > + UINT16 TransmitFifoDepth; ///< UART transmit FIFO depth in bytes. Set= to 0 > for a default FIFO depth of 16 bytes. > + UINT8 Reserved[2]; > +} PCI_SERIAL_PARAMETER; > + > /** > Performs platform specific initialization required for the CPU to acce= ss > the hardware associated with a SerialPortLib instance. This function = does > - not intiailzie the serial port hardware itself. Instead, it initializ= es > + not initialize the serial port hardware itself. Instead, it initializ= es > hardware devices that are required for the CPU to access the serial po= rt > hardware. This function may be called more than once. >=20 > @@ -51,16 +51,16 @@ PlatformHookSerialPortInitialize ( > RETURN_STATUS Status; > UINT32 SerialRegBase; > UINT32 SerialRegAccessType; > - UINT32 BaudRate; > - UINT32 RegWidth; > - UINT32 InputHertz; > - UINT32 PayloadParam; > - UINT32 DeviceVendor; > - PCI_SERIAL_PARAMETER *SerialParam; > - > - Status =3D CbParseSerialInfo (&SerialRegBase, &SerialRegAccessType, > - &RegWidth, &BaudRate, &InputHertz, > - &PayloadParam); > + UINT32 BaudRate; > + UINT32 RegWidth; > + UINT32 InputHertz; > + UINT32 PayloadParam; > + UINT32 DeviceVendor; > + PCI_SERIAL_PARAMETER *SerialParam; > + > + Status =3D CbParseSerialInfo (&SerialRegBase, &SerialRegAccessType, > + &RegWidth, &BaudRate, &InputHertz, > + &PayloadParam); > if (RETURN_ERROR (Status)) { > return Status; > } > @@ -78,34 +78,34 @@ PlatformHookSerialPortInitialize ( > return Status; > } >=20 > - Status =3D PcdSet32S (PcdSerialRegisterStride, RegWidth); > - if (RETURN_ERROR (Status)) { > - return Status; > - } > - > - Status =3D PcdSet32S (PcdSerialBaudRate, BaudRate); > - if (RETURN_ERROR (Status)) { > - return Status; > - } > - > - Status =3D PcdSet64S (PcdUartDefaultBaudRate, BaudRate); > - if (RETURN_ERROR (Status)) { > - return Status; > - } > - > - Status =3D PcdSet32S (PcdSerialClockRate, InputHertz); > - if (RETURN_ERROR (Status)) { > - return Status; > - } > - > - if (PayloadParam >=3D 0x80000000) { > - DeviceVendor =3D PciRead32 (PayloadParam & 0x0ffff000); > - SerialParam =3D PcdGetPtr(PcdPciSerialParameters); > - SerialParam->VendorId =3D (UINT16)DeviceVendor; > - SerialParam->DeviceId =3D DeviceVendor >> 16; > - SerialParam->ClockRate =3D InputHertz; > - SerialParam->RegisterStride =3D (UINT8)RegWidth; > - } > - > + Status =3D PcdSet32S (PcdSerialRegisterStride, RegWidth); > + if (RETURN_ERROR (Status)) { > + return Status; > + } > + > + Status =3D PcdSet32S (PcdSerialBaudRate, BaudRate); > + if (RETURN_ERROR (Status)) { > + return Status; > + } > + > + Status =3D PcdSet64S (PcdUartDefaultBaudRate, BaudRate); > + if (RETURN_ERROR (Status)) { > + return Status; > + } > + > + Status =3D PcdSet32S (PcdSerialClockRate, InputHertz); > + if (RETURN_ERROR (Status)) { > + return Status; > + } > + > + if (PayloadParam >=3D 0x80000000) { > + DeviceVendor =3D PciRead32 (PayloadParam & 0x0ffff000); > + SerialParam =3D PcdGetPtr(PcdPciSerialParameters); > + SerialParam->VendorId =3D (UINT16)DeviceVendor; > + SerialParam->DeviceId =3D DeviceVendor >> 16; > + SerialParam->ClockRate =3D InputHertz; > + SerialParam->RegisterStride =3D (UINT8)RegWidth; > + } > + > return RETURN_SUCCESS; > } > -- > 2.17.2 (Apple Git-113) >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel