From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: benjamin.you@intel.com) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by groups.io with SMTP; Wed, 10 Apr 2019 23:22:21 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Apr 2019 23:22:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,336,1549958400"; d="scan'208";a="163291938" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 10 Apr 2019 23:22:20 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 10 Apr 2019 23:22:20 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.93]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.153]) with mapi id 14.03.0415.000; Thu, 11 Apr 2019 14:22:18 +0800 From: "Benjamin You" To: "Bi, Dandan" , "devel@edk2.groups.io" CC: "Ma, Maurice" , "Agyeman, Prince" Subject: Re: [patch] CorebootPayloadPkg: Remove the dependency of ShellBinPkg Thread-Topic: [patch] CorebootPayloadPkg: Remove the dependency of ShellBinPkg Thread-Index: AQHU718WJZXuM1mNBEaqZa1e5LJRSKY2fn/A Date: Thu, 11 Apr 2019 06:22:18 +0000 Message-ID: References: <20190410053413.31288-1-dandan.bi@intel.com> In-Reply-To: <20190410053413.31288-1-dandan.bi@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGQ3Nzc3MDgtYWYzNC00OTZmLWFiODQtZWQ1YWI5YTU5Y2VkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZGdXQ2VnYTVnN3IyRUdETklYVjAzS0Jmc21wMDlMSjJ2Z0lxdk5oWWREOEtjd2paM0prZjhcL3NtRFdnNXhnS1EifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: benjamin.you@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Benjamin You Thanks, - ben > -----Original Message----- > From: Bi, Dandan > Sent: Wednesday, April 10, 2019 1:34 PM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Agyeman, Prince > ; You, Benjamin > Subject: [patch] CorebootPayloadPkg: Remove the dependency of ShellBinPkg >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1675 >=20 > In long term we will remove ShellBinPkg, so now we update > platform to use ShellPkg only. >=20 > Cc: Maurice Ma > Cc: Prince Agyeman > Cc: Benjamin You > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Dandan Bi > --- > CorebootPayloadPkg/CorebootPayloadPkg.fdf | 18 ------------------ > CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc | 9 --------- > .../CorebootPayloadPkgIa32X64.dsc | 9 --------- > 3 files changed, 36 deletions(-) >=20 > diff --git a/CorebootPayloadPkg/CorebootPayloadPkg.fdf > b/CorebootPayloadPkg/CorebootPayloadPkg.fdf > index 0c24f96a15..d399ad8eb8 100644 > --- a/CorebootPayloadPkg/CorebootPayloadPkg.fdf > +++ b/CorebootPayloadPkg/CorebootPayloadPkg.fdf > @@ -177,31 +177,13 @@ INF > MdeModulePkg/Bus/Usb/UsbMassStorageDxe/UsbMassStorageDxe.inf > INF QuarkSocPkg/QuarkSouthCluster/Usb/Ohci/Dxe/OhciDxe.inf >=20 > # > # Shell > # > -!if $(SHELL_TYPE) =3D=3D BUILD_SHELL > INF > ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.inf > INF > ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamicCommand.inf > INF ShellPkg/Application/Shell/Shell.inf > -!endif > - > -!if $(SHELL_TYPE) =3D=3D MIN_BIN > -!if $(ARCH) =3D=3D IA32 > -INF RuleOverride =3D BINARY USE =3D IA32 > ShellBinPkg/MinUefiShell/MinUefiShell.inf > -!else > -INF RuleOverride =3D BINARY USE =3D X64 > ShellBinPkg/MinUefiShell/MinUefiShell.inf > -!endif > -!endif > - > -!if $(SHELL_TYPE) =3D=3D UEFI_BIN > -!if $(ARCH) =3D=3D IA32 > -INF RuleOverride =3D BINARY USE =3D IA32 ShellBinPkg/UefiShell/UefiShel= l.inf > -!else > -INF RuleOverride =3D BINARY USE =3D X64 ShellBinPkg/UefiShell/UefiShell= .inf > -!endif > -!endif >=20 > FILE FREEFORM =3D > PCD(gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile) { > SECTION RAW =3D MdeModulePkg/Logo/Logo.bmp > } >=20 > diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc > b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc > index 98d6073866..c53b53b2f7 100644 > --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc > +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc > @@ -80,15 +80,10 @@ > # > # Chipset options > # > DEFINE USE_HPET_TIMER =3D FALSE >=20 > - # > - # Shell options: [BUILD_SHELL, MIN_BIN, NONE, UEFI] > - # > - DEFINE SHELL_TYPE =3D UEFI_BIN > - > [BuildOptions] > *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACE= S > GCC:*_UNIXGCC_*_CC_FLAGS =3D -DMDEPKG_NDEBUG > GCC:RELEASE_*_*_CC_FLAGS =3D -DMDEPKG_NDEBUG > INTEL:RELEASE_*_*_CC_FLAGS =3D /D MDEPKG_NDEBUG > @@ -520,12 +515,10 @@ >=20 > #------------------------------ > # Build the shell > #------------------------------ >=20 > -!if $(SHELL_TYPE) =3D=3D BUILD_SHELL > - > # > # Shell Lib > # > [LibraryClasses] >=20 > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCo > mmandLib.inf > @@ -583,7 +576,5 @@ > PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntry= Lib.inf >=20 > ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLi > b.inf > SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf > } > - > -!endif > diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc > b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc > index 608a288c42..3ecc0d0039 100644 > --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc > +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc > @@ -80,15 +80,10 @@ > # > # Chipset options > # > DEFINE USE_HPET_TIMER =3D FALSE >=20 > - # > - # Shell options: [BUILD_SHELL, MIN_BIN, NONE, UEFI] > - # > - DEFINE SHELL_TYPE =3D UEFI_BIN > - > [BuildOptions] > *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACE= S > GCC:*_UNIXGCC_*_CC_FLAGS =3D -DMDEPKG_NDEBUG > GCC:RELEASE_*_*_CC_FLAGS =3D -DMDEPKG_NDEBUG > INTEL:RELEASE_*_*_CC_FLAGS =3D /D MDEPKG_NDEBUG > @@ -521,12 +516,10 @@ >=20 > #------------------------------ > # Build the shell > #------------------------------ >=20 > -!if $(SHELL_TYPE) =3D=3D BUILD_SHELL > - > # > # Shell Lib > # > [LibraryClasses] >=20 > BcfgCommandLib|ShellPkg/Library/UefiShellBcfgCommandLib/UefiShellBcfgCo > mmandLib.inf > @@ -584,7 +577,5 @@ > PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf > ShellCEntryLib|ShellPkg/Library/UefiShellCEntryLib/UefiShellCEntry= Lib.inf >=20 > ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLi > b.inf > SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf > } > - > -!endif > -- > 2.18.0.windows.1