public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Kinney, Michael D" <michael.d.kinney@intel.com>
To: "Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH 07/11] QuarkSocPkg/ResetSystemLib: Implement ResetPlatformSpecific
Date: Wed, 10 Aug 2016 16:28:36 +0000	[thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5647F5726@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <20160810055611.266232-8-ruiyu.ni@intel.com>

Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>

> -----Original Message-----
> From: Ni, Ruiyu
> Sent: Tuesday, August 9, 2016 10:56 PM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Steele, Kelly
> <kelly.steele@intel.com>
> Subject: [PATCH 07/11] QuarkSocPkg/ResetSystemLib: Implement ResetPlatformSpecific
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Kelly Steele <kelly.steele@intel.com>
> ---
>  .../Library/ResetSystemLib/ResetSystemLib.c        | 22 +++++++++++++++++++++-
>  1 file changed, 21 insertions(+), 1 deletion(-)
> 
> diff --git a/QuarkSocPkg/QuarkNorthCluster/Library/ResetSystemLib/ResetSystemLib.c
> b/QuarkSocPkg/QuarkNorthCluster/Library/ResetSystemLib/ResetSystemLib.c
> index c2ad7f3..3aa0f6d 100644
> --- a/QuarkSocPkg/QuarkNorthCluster/Library/ResetSystemLib/ResetSystemLib.c
> +++ b/QuarkSocPkg/QuarkNorthCluster/Library/ResetSystemLib/ResetSystemLib.c
> @@ -2,7 +2,7 @@
>  System reset Library Services.  This library class provides a set of
>  methods to reset whole system with manipulate QNC.
> 
> -Copyright (c) 2013-2015 Intel Corporation.
> +Copyright (c) 2013-2016 Intel Corporation.
> 
>  This program and the accompanying materials
>  are licensed and made available under the terms and conditions of the BSD License
> @@ -320,3 +320,23 @@ VOID
>    }
>  }
> 
> +/**
> +  This function causes a systemwide reset. The exact type of the reset is defined
> +  by the EFI_GUID that follows the Null-terminated Unicode string passed into
> ResetData.
> +  If the platform does not recognize the EFI_GUID in ResetData the platform must
> pick a
> +  supported reset type to perform.The platform may optionally log the parameters
> from
> +  any non-normal reset that occurs.
> +
> +  @param[in]  DataSize   The size, in bytes, of ResetData.
> +  @param[in]  ResetData  The data buffer starts with a Null-terminated string,
> followed
> +                         by the EFI_GUID.
> +**/
> +VOID
> +EFIAPI
> +ResetPlatformSpecific (
> +  IN UINTN   DataSize,
> +  IN VOID    *ResetData
> +  )
> +{
> +  ResetCold ();
> +}
> --
> 2.9.0.windows.1



  reply	other threads:[~2016-08-10 16:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-10  5:56 [PATCH 00/11] Add ResetPlatformSpecific() to ResetSystemLib Ruiyu Ni
2016-08-10  5:56 ` [PATCH 01/11] MdePkg/UefiSpec.h: Align function header of ResetSystem to UEFI Spec Ruiyu Ni
2016-08-16  4:49   ` Gao, Liming
2016-08-10  5:56 ` [PATCH 02/11] MdeModulePkg: Add API ResetPlatformSpecific() to ResetSystemLib.h Ruiyu Ni
2016-08-10  5:56 ` [PATCH 03/11] MdeModulePkg/BaseResetSystemLibNull: Implement ResetPlatformSpecific Ruiyu Ni
2016-08-23  3:21   ` Tian, Feng
2016-08-23  4:56     ` Ni, Ruiyu
2016-08-10  5:56 ` [PATCH 04/11] CorebootPayloadPkg/ResetSystemLib: " Ruiyu Ni
2016-08-11 16:09   ` Ma, Maurice
2016-08-10  5:56 ` [PATCH 05/11] OvmfPkg/ResetSystemLib: " Ruiyu Ni
2016-08-10  5:56 ` [PATCH 06/11] PcAtChipsetPkg/ResetSystemLib: " Ruiyu Ni
2016-08-10  5:56 ` [PATCH 07/11] QuarkSocPkg/ResetSystemLib: " Ruiyu Ni
2016-08-10 16:28   ` Kinney, Michael D [this message]
2016-08-10  5:56 ` [PATCH 08/11] Vlv2TbltDevicePkg/ResetSystemLib: " Ruiyu Ni
2016-08-11  2:22   ` Wei, David
2016-08-10  5:56 ` [PATCH 09/11] OvmfPkg: Use MdeModulePkg/ResetSystemRuntimeDxe Ruiyu Ni
2016-08-10  5:56 ` [PATCH 10/11] PcAtChipsetPkg: Remove KbcResetDxe Ruiyu Ni
2016-08-10  5:56 ` [PATCH 11/11] MdeModulePkg/ResetSystemRuntimeDxe: Support EfiResetPlatformSpecific Ruiyu Ni
2016-08-10 17:33   ` Jordan Justen
2016-08-11  2:43     ` Ni, Ruiyu
2016-08-11  6:05       ` Jordan Justen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E92EE9817A31E24EB0585FDF735412F5647F5726@ORSMSX113.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox