Re: [PATCH 3/3] IntelFsp2WrapperPkg: Update pragma to use push and pop

["Kinney, Michael D" <michael.d.kinney@intel.com>]

Giri,

Just leave this as #pragma pack(1) and #pragma pack() to follow the 
style used everywhere else.

EDK II sources assume the default packing is natural packing. The compiler
Configuration in tools_def.txt need to make sure natural packing is the default.

Mike

> -----Original Message-----
> From: Mudusuru, Giri P
> Sent: Monday, August 29, 2016 11:14 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Ma, Maurice <maurice.ma@intel.com>; Yarlagadda,
> Satya P <satya.p.yarlagadda@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [edk2] [PATCH 3/3] IntelFsp2WrapperPkg: Update pragma to use push and pop
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Satya Yarlagadda <satya.p.yarlagadda@intel.com>
> Cc: Michael Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
> ---
>  .../Library/BaseFspWrapperApiLib/X64/DispatchExecute.c                | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/DispatchExecute.c
> b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/DispatchExecute.c
> index 061d381..5f4b75e 100644
> --- a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/DispatchExecute.c
> +++ b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/DispatchExecute.c
> @@ -18,7 +18,7 @@
>  #include <Library/BaseLib.h>
>  #include <FspEas.h>
> 
> -#pragma pack(1)
> +#pragma pack(push, 1)
>  typedef union {
>    struct {
>      UINT32  LimitLow    : 16;
> @@ -37,7 +37,7 @@ typedef union {
>    } Bits;
>    UINT64  Uint64;
>  } IA32_GDT;
> -#pragma pack()
> +#pragma pack(pop)
> 
>  GLOBAL_REMOVE_IF_UNREFERENCED IA32_GDT mGdtEntries[] = {
>    {{0,      0,  0,  0,    0,  0,  0,  0,    0,  0, 0,  0,  0}}, /* 0x0:  reserve */
> --
> 2.9.0.windows.1