From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 463001A1DE9 for ; Mon, 29 Aug 2016 11:45:05 -0700 (PDT) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP; 29 Aug 2016 11:45:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,597,1470726000"; d="scan'208";a="2371042" Received: from orsmsx105.amr.corp.intel.com ([10.22.225.132]) by fmsmga005.fm.intel.com with ESMTP; 29 Aug 2016 11:45:04 -0700 Received: from orsmsx116.amr.corp.intel.com (10.22.240.14) by ORSMSX105.amr.corp.intel.com (10.22.225.132) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 29 Aug 2016 11:45:04 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.118]) by ORSMSX116.amr.corp.intel.com ([169.254.7.187]) with mapi id 14.03.0248.002; Mon, 29 Aug 2016 11:45:04 -0700 From: "Kinney, Michael D" To: "Mudusuru, Giri P" , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "Yao, Jiewen" , "Ma, Maurice" , "Yarlagadda, Satya P" Thread-Topic: [edk2] [PATCH 3/3] IntelFsp2WrapperPkg: Update pragma to use push and pop Thread-Index: AQHSAiEpQ5SVvDqPk0aHxM4IKGWt46BgRhCA Date: Mon, 29 Aug 2016 18:45:03 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTI3M2U5OTgtNzU2Ni00ZDAwLTk4NzEtMTIwZTgwYTJmMGRmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjNHV2RSSytjRDF3VG1QYUJYWFV2R1wvb1BkZXBtZW81SUpKYUJHeldWTExFPSJ9 x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: [PATCH 3/3] IntelFsp2WrapperPkg: Update pragma to use push and pop X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Aug 2016 18:45:05 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Giri, Just leave this as #pragma pack(1) and #pragma pack() to follow the=20 style used everywhere else. EDK II sources assume the default packing is natural packing. The compiler Configuration in tools_def.txt need to make sure natural packing is the def= ault. Mike > -----Original Message----- > From: Mudusuru, Giri P > Sent: Monday, August 29, 2016 11:14 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Ma, Maurice ; Yarlagadda, > Satya P ; Kinney, Michael D > Subject: [edk2] [PATCH 3/3] IntelFsp2WrapperPkg: Update pragma to use pus= h and pop >=20 > Cc: Jiewen Yao > Cc: Maurice Ma > Cc: Satya Yarlagadda > Cc: Michael Kinney > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Giri P Mudusuru > --- > .../Library/BaseFspWrapperApiLib/X64/DispatchExecute.c | = 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/Dispatc= hExecute.c > b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/DispatchExecute.c > index 061d381..5f4b75e 100644 > --- a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/DispatchExecut= e.c > +++ b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/DispatchExecut= e.c > @@ -18,7 +18,7 @@ > #include > #include >=20 > -#pragma pack(1) > +#pragma pack(push, 1) > typedef union { > struct { > UINT32 LimitLow : 16; > @@ -37,7 +37,7 @@ typedef union { > } Bits; > UINT64 Uint64; > } IA32_GDT; > -#pragma pack() > +#pragma pack(pop) >=20 > GLOBAL_REMOVE_IF_UNREFERENCED IA32_GDT mGdtEntries[] =3D { > {{0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}}, /* 0x0: = reserve */ > -- > 2.9.0.windows.1