From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 39D571A1E6F for ; Thu, 1 Sep 2016 08:57:46 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP; 01 Sep 2016 08:57:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,268,1470726000"; d="scan'208";a="1050217961" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by fmsmga002.fm.intel.com with ESMTP; 01 Sep 2016 08:57:45 -0700 Received: from orsmsx114.amr.corp.intel.com (10.22.240.10) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 1 Sep 2016 08:57:45 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.118]) by ORSMSX114.amr.corp.intel.com ([169.254.8.42]) with mapi id 14.03.0248.002; Thu, 1 Sep 2016 08:57:44 -0700 From: "Kinney, Michael D" To: Laszlo Ersek , "Zeng, Star" , "Kinney, Michael D" CC: "edk2-devel@ml01.01.org" , "Yao, Jiewen" , Chan Amy , "Zhang, Chao B" , "Wei, David" Thread-Topic: [edk2] [PATCH 0/6] PiDxeS3BootScriptLib: Support multiple PCI segment Thread-Index: AQHR+exTuQInQlk0ZkCV3NybaFKGvKBX3zQAgAz/YbA= Date: Thu, 1 Sep 2016 15:57:44 +0000 Message-ID: References: <1471592131-143456-1-git-send-email-star.zeng@intel.com> <7ec1654a-55c8-26bc-5340-85d10907b0e1@redhat.com> In-Reply-To: <7ec1654a-55c8-26bc-5340-85d10907b0e1@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDJlYmY1ZjMtM2M3Yi00MDNiLWFlNDktNzI0YmEyMTU2MGY2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjkwcGJNVzdDN29WQXBEK01kOXBzUExwMlFUS29cL09VZzdNTEY2Q3ZuY2hNPSJ9 x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Subject: Re: [PATCH 0/6] PiDxeS3BootScriptLib: Support multiple PCI segment X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Sep 2016 15:57:46 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Laszlo, You are correct. No functional change. I think I was more concerned about source changes to the functions that=20 were already well tested, and wanted to focus the source code changes on=20 the functions that were being enabled for multiple segments. If we are all confident from the code review and testing that we have not introduced any regression, then it is a good change. Reviewed-by: Michael Kinney Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of La= szlo Ersek > Sent: Tuesday, August 23, 2016 7:26 PM > To: Zeng, Star ; Kinney, Michael D > Cc: edk2-devel@ml01.01.org; Yao, Jiewen ; Chan Amy > ; Zhang, Chao B ; Wei, David > > Subject: Re: [edk2] [PATCH 0/6] PiDxeS3BootScriptLib: Support multiple PC= I segment >=20 > On 08/19/16 03:35, Star Zeng wrote: > > Support multiple PCI segment for PCI_CONFIG2 opcodes. > > > > PiDxeS3BootScriptLib needs to be updated to consume PciSegmentLib > > instead of PciLib. That means platforms need to add PciSegmentLib > > declaration like below in platform dsc if the PciSegmentLib was > > not declared in platform dsc before. > > > > PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci.= inf > > > > For platforms only have one segment, > > MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci.inf is recomme= nded > > to be used and declared in platform dsc for PiDxeS3BootScriptLib to hav= e > > equivalent functionality with before. > > > > Cc: Jiewen Yao > > Cc: Michael D Kinney > > Cc: Chan Amy > > Cc: Laszlo Ersek > > Cc: Kelly Steele > > Cc: David Wei > > Cc: Chao Zhang > > > > Star Zeng (6): > > MdeModulePkg PiDxeS3BootScriptLib: Remove the trailing white spaces > > MdeModulePkg PiDxeS3BootScriptLib: Support multiple PCI segment > > Vlv2TbltDevicePkg: Declare PciSegmentLib in platform dsc > > QuarkPlatformPkg: Declare PciSegmentLib in platform dsc > > QuarkSocPkg/QuarkSocPkg.dsc: Declare PciSegmentLib > > SecurityPkg/SecurityPkg.dsc: Declare PciSegmentLib > > > > .../PiDxeS3BootScriptLib/BootScriptExecute.c | 411 +++++++++----= ------ > > .../BootScriptInternalFormat.h | 2 +- > > .../Library/PiDxeS3BootScriptLib/BootScriptSave.c | 451 ++++++++++---= -------- > > .../PiDxeS3BootScriptLib/DxeS3BootScriptLib.inf | 4 +- > > .../PiDxeS3BootScriptLib/DxeS3BootScriptLib.uni | 2 +- > > .../PiDxeS3BootScriptLib/InternalBootScriptLib.h | 26 +- > > QuarkPlatformPkg/Quark.dsc | 1 + > > QuarkPlatformPkg/QuarkMin.dsc | 1 + > > QuarkSocPkg/QuarkSocPkg.dsc | 1 + > > SecurityPkg/SecurityPkg.dsc | 1 + > > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 1 + > > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 1 + > > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 1 + > > 13 files changed, 450 insertions(+), 453 deletions(-) > > >=20 > For patches #1 and #2: >=20 > Tested-by: Laszlo Ersek >=20 > (Also compared some logs.) >=20 > I read the sub-thread under #2, but I don't understand Mike's concern. I > can be wrong of course, but in my understanding, the boot script's > internal representation does not change. The "saver" side only relaxes > the Segment=3D0 requirement. And, the "executor side" accommodates nonzer= o > segments in the Pci2 opcodes, and rebases the Pci[1] opcode functions on > top of Pci2 opcode functions (with hardcoded Segment=3D0). >=20 > I don't understand why calling PciSegmentLib functions with a UINT64 > parameter where the segment bit-field is hardcoded to 0 is worse than > calling PciLib (uncapable of nonzero segments) with an UINTN parameter. >=20 > Is this about the cost of a function call on Ia32? That is, assuming a > very long S3 boot script, the patch might noticeably slow down S3 resume > on Ia32? >=20 > Thanks > Laszlo > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel