public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Kinney, Michael D" <michael.d.kinney@intel.com>
To: Leif Lindholm <leif.lindholm@linaro.org>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>,
	"Gao, Liming" <liming.gao@intel.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH 0/3] MdePkg/Misc: fix Arm BaseMemoryLib
Date: Fri, 2 Sep 2016 15:49:03 +0000	[thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F5648061B1@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <20160902142912.17297-1-leif.lindholm@linaro.org>

Leif,

Moving this library into MdePkg looks good to me along with the addition of the 2 new BaseMemoryLib APIs.

Minor issues in ArmPkg.dsc, ArmPkg.dsc.inc not updating the Copyright to 2016.  

Reviewed-by: Michael Kinney <michael.d.kinney@intel.com>

Mike

> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: Friday, September 2, 2016 7:29 AM
> To: edk2-devel@lists.01.org
> Cc: Laszlo Ersek <lersek@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> Gao, Liming <liming.gao@intel.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Subject: [PATCH 0/3] MdePkg/Misc: fix Arm BaseMemoryLib
> 
> The recent addition, and use, of new functions IsZeroGuid/IsZeroBuffer
> caused all ARM/AARCH64 platforms to stop building. The oversight was
> helped by the ARM implementation residing in ArmPkg rather than in
> MdePkg with all of the others.
> 
> Move BaseMemoryLibStm across to MdePkg to reduce risk of similar
> accidents in future, and add the new functions.
> 
> This set resolves the build issue without affecting any non-ARM
> platforms, in the interest of getting back to a working master
> branch. It would be very nice if it could be approved quickly.
> 
> Ard Biesheuvel (2):
>   MdePkg/BaseMemoryLibStm: implement new IsZeroGuid() API function
>   MdePkg/BaseMemoryLibStm: implement new IsZeroBuffer() API function
> 
> Leif Lindholm (1):
>   MdePkg/Misc: Move ARM* BaseMemoryLibStm to MdePkg
> 
>  ArmPkg/ArmPkg.dsc                                  |  1 -
>  ArmVirtPkg/ArmVirt.dsc.inc                         |  2 +-
>  BeagleBoardPkg/BeagleBoardPkg.dsc                  |  2 +-
>  .../Library/BaseMemoryLibStm/AArch64/CopyMem.c     |  0
>  .../Library/BaseMemoryLibStm/AArch64/SetMem.c      |  0
>  .../Library/BaseMemoryLibStm/Arm/CopyMem.S         |  0
>  .../Library/BaseMemoryLibStm/Arm/CopyMem.asm       |  0
>  .../Library/BaseMemoryLibStm/Arm/SetMem.S          |  0
>  .../Library/BaseMemoryLibStm/Arm/SetMem.asm        |  0
>  .../Library/BaseMemoryLibStm/BaseMemoryLibStm.inf  |  1 +
>  .../Library/BaseMemoryLibStm/CompareMemWrapper.c   |  0
>  .../Library/BaseMemoryLibStm/CopyMem.c             |  0
>  .../Library/BaseMemoryLibStm/CopyMemWrapper.c      |  0
>  .../Library/BaseMemoryLibStm/IsZeroBufferWrapper.c | 54 ++++++++++++++++++++++
>  .../Library/BaseMemoryLibStm/MemLibGeneric.c       | 29 ++++++++++++
>  .../Library/BaseMemoryLibStm/MemLibGuid.c          | 29 ++++++++++++
>  .../Library/BaseMemoryLibStm/MemLibInternals.h     | 17 +++++++
>  .../Library/BaseMemoryLibStm/ScanMem16Wrapper.c    |  0
>  .../Library/BaseMemoryLibStm/ScanMem32Wrapper.c    |  0
>  .../Library/BaseMemoryLibStm/ScanMem64Wrapper.c    |  0
>  .../Library/BaseMemoryLibStm/ScanMem8Wrapper.c     |  0
>  .../Library/BaseMemoryLibStm/SetMem.c              |  0
>  .../Library/BaseMemoryLibStm/SetMem16Wrapper.c     |  0
>  .../Library/BaseMemoryLibStm/SetMem32Wrapper.c     |  0
>  .../Library/BaseMemoryLibStm/SetMem64Wrapper.c     |  0
>  .../Library/BaseMemoryLibStm/SetMemWrapper.c       |  0
>  .../Library/BaseMemoryLibStm/ZeroMemWrapper.c      |  0
>  MdePkg/MdePkg.dsc                                  |  1 +
>  28 files changed, 133 insertions(+), 3 deletions(-)
>  rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/AArch64/CopyMem.c (100%)
>  rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/AArch64/SetMem.c (100%)
>  rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/Arm/CopyMem.S (100%)
>  rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/Arm/CopyMem.asm (100%)
>  rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/Arm/SetMem.S (100%)
>  rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/Arm/SetMem.asm (100%)
>  rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/BaseMemoryLibStm.inf (94%)
>  rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/CompareMemWrapper.c (100%)
>  rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/CopyMem.c (100%)
>  rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/CopyMemWrapper.c (100%)
>  create mode 100644 MdePkg/Library/BaseMemoryLibStm/IsZeroBufferWrapper.c
>  rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/MemLibGeneric.c (88%)
>  rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/MemLibGuid.c (81%)
>  rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/MemLibInternals.h (90%)
>  rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ScanMem16Wrapper.c (100%)
>  rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ScanMem32Wrapper.c (100%)
>  rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ScanMem64Wrapper.c (100%)
>  rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ScanMem8Wrapper.c (100%)
>  rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMem.c (100%)
>  rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMem16Wrapper.c (100%)
>  rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMem32Wrapper.c (100%)
>  rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMem64Wrapper.c (100%)
>  rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/SetMemWrapper.c (100%)
>  rename {ArmPkg => MdePkg}/Library/BaseMemoryLibStm/ZeroMemWrapper.c (100%)
> 
> --
> 2.9.3



  parent reply	other threads:[~2016-09-02 15:49 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-02 14:29 [PATCH 0/3] MdePkg/Misc: fix Arm BaseMemoryLib Leif Lindholm
2016-09-02 14:29 ` [PATCH 1/3] MdePkg/Misc: Move ARM* BaseMemoryLibStm to MdePkg Leif Lindholm
2016-09-02 15:02   ` Ard Biesheuvel
2016-09-02 15:23     ` Leif Lindholm
2016-09-02 16:07       ` Ard Biesheuvel
2016-09-02 18:05         ` Leif Lindholm
2016-09-02 18:11           ` Ard Biesheuvel
2016-09-02 18:32             ` Leif Lindholm
2016-09-02 18:45               ` Ard Biesheuvel
2016-09-02 19:18                 ` Leif Lindholm
2016-09-02 19:24                   ` Laszlo Ersek
2016-09-02 14:29 ` [PATCH 2/3] MdePkg/BaseMemoryLibStm: implement new IsZeroGuid() API function Leif Lindholm
2016-09-02 14:29 ` [PATCH 3/3] MdePkg/BaseMemoryLibStm: implement new IsZeroBuffer() " Leif Lindholm
2016-09-02 14:48 ` [PATCH 0/3] MdePkg/Misc: fix Arm BaseMemoryLib Laszlo Ersek
2016-09-02 14:53   ` Laszlo Ersek
2016-09-02 16:02     ` Leif Lindholm
2016-09-02 15:49 ` Kinney, Michael D [this message]
2016-09-02 15:57   ` Leif Lindholm
2016-09-02 15:59     ` Andrew Fish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E92EE9817A31E24EB0585FDF735412F5648061B1@ORSMSX113.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox