From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DA0F51A1E06 for ; Fri, 2 Sep 2016 08:49:04 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 02 Sep 2016 08:49:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,271,1470726000"; d="scan'208";a="1050690338" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by fmsmga002.fm.intel.com with ESMTP; 02 Sep 2016 08:49:04 -0700 Received: from orsmsx162.amr.corp.intel.com (10.22.240.85) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 2 Sep 2016 08:49:03 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.118]) by ORSMSX162.amr.corp.intel.com ([169.254.3.27]) with mapi id 14.03.0248.002; Fri, 2 Sep 2016 08:49:03 -0700 From: "Kinney, Michael D" To: Leif Lindholm , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: Laszlo Ersek , "Gao, Liming" , Ard Biesheuvel Thread-Topic: [PATCH 0/3] MdePkg/Misc: fix Arm BaseMemoryLib Thread-Index: AQHSBSZjeF0/vFxOTEC3wvIXqzj8/KBmV3XQ Date: Fri, 2 Sep 2016 15:49:03 +0000 Message-ID: References: <20160902142912.17297-1-leif.lindholm@linaro.org> In-Reply-To: <20160902142912.17297-1-leif.lindholm@linaro.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzM4MzhlYzItODVkNS00NTczLWEyZTMtMzMzNzNlZjhmNDg2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IitMZnJleVFcL0NnWHFLSE9KeTlrU2k3K2FtOFR5bjcydXEzUkQ1XC9yOWUxQT0ifQ== x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Subject: Re: [PATCH 0/3] MdePkg/Misc: fix Arm BaseMemoryLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Sep 2016 15:49:05 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leif, Moving this library into MdePkg looks good to me along with the addition of= the 2 new BaseMemoryLib APIs. Minor issues in ArmPkg.dsc, ArmPkg.dsc.inc not updating the Copyright to 20= 16. =20 Reviewed-by: Michael Kinney Mike > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Friday, September 2, 2016 7:29 AM > To: edk2-devel@lists.01.org > Cc: Laszlo Ersek ; Kinney, Michael D ; > Gao, Liming ; Ard Biesheuvel > Subject: [PATCH 0/3] MdePkg/Misc: fix Arm BaseMemoryLib >=20 > The recent addition, and use, of new functions IsZeroGuid/IsZeroBuffer > caused all ARM/AARCH64 platforms to stop building. The oversight was > helped by the ARM implementation residing in ArmPkg rather than in > MdePkg with all of the others. >=20 > Move BaseMemoryLibStm across to MdePkg to reduce risk of similar > accidents in future, and add the new functions. >=20 > This set resolves the build issue without affecting any non-ARM > platforms, in the interest of getting back to a working master > branch. It would be very nice if it could be approved quickly. >=20 > Ard Biesheuvel (2): > MdePkg/BaseMemoryLibStm: implement new IsZeroGuid() API function > MdePkg/BaseMemoryLibStm: implement new IsZeroBuffer() API function >=20 > Leif Lindholm (1): > MdePkg/Misc: Move ARM* BaseMemoryLibStm to MdePkg >=20 > ArmPkg/ArmPkg.dsc | 1 - > ArmVirtPkg/ArmVirt.dsc.inc | 2 +- > BeagleBoardPkg/BeagleBoardPkg.dsc | 2 +- > .../Library/BaseMemoryLibStm/AArch64/CopyMem.c | 0 > .../Library/BaseMemoryLibStm/AArch64/SetMem.c | 0 > .../Library/BaseMemoryLibStm/Arm/CopyMem.S | 0 > .../Library/BaseMemoryLibStm/Arm/CopyMem.asm | 0 > .../Library/BaseMemoryLibStm/Arm/SetMem.S | 0 > .../Library/BaseMemoryLibStm/Arm/SetMem.asm | 0 > .../Library/BaseMemoryLibStm/BaseMemoryLibStm.inf | 1 + > .../Library/BaseMemoryLibStm/CompareMemWrapper.c | 0 > .../Library/BaseMemoryLibStm/CopyMem.c | 0 > .../Library/BaseMemoryLibStm/CopyMemWrapper.c | 0 > .../Library/BaseMemoryLibStm/IsZeroBufferWrapper.c | 54 ++++++++++++++++= ++++++ > .../Library/BaseMemoryLibStm/MemLibGeneric.c | 29 ++++++++++++ > .../Library/BaseMemoryLibStm/MemLibGuid.c | 29 ++++++++++++ > .../Library/BaseMemoryLibStm/MemLibInternals.h | 17 +++++++ > .../Library/BaseMemoryLibStm/ScanMem16Wrapper.c | 0 > .../Library/BaseMemoryLibStm/ScanMem32Wrapper.c | 0 > .../Library/BaseMemoryLibStm/ScanMem64Wrapper.c | 0 > .../Library/BaseMemoryLibStm/ScanMem8Wrapper.c | 0 > .../Library/BaseMemoryLibStm/SetMem.c | 0 > .../Library/BaseMemoryLibStm/SetMem16Wrapper.c | 0 > .../Library/BaseMemoryLibStm/SetMem32Wrapper.c | 0 > .../Library/BaseMemoryLibStm/SetMem64Wrapper.c | 0 > .../Library/BaseMemoryLibStm/SetMemWrapper.c | 0 > .../Library/BaseMemoryLibStm/ZeroMemWrapper.c | 0 > MdePkg/MdePkg.dsc | 1 + > 28 files changed, 133 insertions(+), 3 deletions(-) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/AArch64/CopyMem.c (= 100%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/AArch64/SetMem.c (1= 00%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/Arm/CopyMem.S (100%= ) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/Arm/CopyMem.asm (10= 0%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/Arm/SetMem.S (100%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/Arm/SetMem.asm (100= %) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/BaseMemoryLibStm.in= f (94%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/CompareMemWrapper.c= (100%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/CopyMem.c (100%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/CopyMemWrapper.c (1= 00%) > create mode 100644 MdePkg/Library/BaseMemoryLibStm/IsZeroBufferWrapper.c > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/MemLibGeneric.c (88= %) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/MemLibGuid.c (81%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/MemLibInternals.h (= 90%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/ScanMem16Wrapper.c = (100%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/ScanMem32Wrapper.c = (100%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/ScanMem64Wrapper.c = (100%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/ScanMem8Wrapper.c (= 100%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/SetMem.c (100%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/SetMem16Wrapper.c (= 100%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/SetMem32Wrapper.c (= 100%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/SetMem64Wrapper.c (= 100%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/SetMemWrapper.c (10= 0%) > rename {ArmPkg =3D> MdePkg}/Library/BaseMemoryLibStm/ZeroMemWrapper.c (1= 00%) >=20 > -- > 2.9.3