From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 17A241A1DF7 for ; Tue, 20 Sep 2016 09:25:50 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP; 20 Sep 2016 09:25:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,368,1470726000"; d="scan'208";a="11457963" Received: from orsmsx106.amr.corp.intel.com ([10.22.225.133]) by orsmga005.jf.intel.com with ESMTP; 20 Sep 2016 09:25:46 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.161]) by ORSMSX106.amr.corp.intel.com ([169.254.1.77]) with mapi id 14.03.0248.002; Tue, 20 Sep 2016 09:25:46 -0700 From: "Kinney, Michael D" To: "Gao, Liming" , Felix Poludov , "edk2-devel@lists.01.org" , "Kinney, Michael D" Thread-Topic: [PATCH] [MdePkg ] New Debug Message Levels Thread-Index: AdIOoGfwP58VzQt9RL+w0VhTGXv9FAAAR6uQAAb6ZRABImanIAAFA+8w Date: Tue, 20 Sep 2016 16:25:45 +0000 Message-ID: References: <9333E191E0D52B4999CE63A99BA663A00270FEBC69@atlms1.us.megatrends.com> <9333E191E0D52B4999CE63A99BA663A00270FEBD66@atlms1.us.megatrends.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14B47ACEB@shsmsx102.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14B47ACEB@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGJlYTEyMmYtZGQwYS00NjdkLWFkMjAtNmYyYmNlM2RiZjJkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik9HY21Wellpa0IyN3FwTjBGZlI0RVZ5aEcySFwvaWV3MDhjXC9mNTlQQWV3OD0ifQ== x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Subject: Re: [PATCH] [MdePkg ] New Debug Message Levels X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2016 16:25:50 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Felix, We should only add the DEBUG_ defines for new bit values. We would like to= retire the use of EFI_D_ defines and encourage use of DEBUG_ defines. The= reason is that DEBUG() macros apply to all execution phases and module typ= es. Also, what is the use case for DEBUG_CSM. I would image this would only be= used for CSM wrapper modules, and the exiting define values should be suff= icient for that specific use case. That bit mask is starting to get full. Thanks, Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ga= o, Liming > Sent: Tuesday, September 20, 2016 7:01 AM > To: Felix Poludov ; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] [MdePkg ] New Debug Message Levels >=20 > Felix: > I have two comments. > 1) Update @Expression 0x80000002 | (gEfiMdePkgTokenSpaceGuid.PcdDebugPri= ntErrorLevel > & 0x7F84AA00) =3D=3D 0. 0x7F84AA00 should be updated to match the valid d= ebug error level > bit mask. > 2) PCD help message in MdePkg.uni is also required to be updated. >=20 > Thanks > Liming > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fe= lix Poludov > Sent: Thursday, September 15, 2016 3:27 AM > To: edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] [MdePkg ] New Debug Message Levels >=20 > Resending with the patch (the patch was missing in the original e-mail). >=20 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Fe= lix Poludov > Sent: Wednesday, September 14, 2016 12:05 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH] [MdePkg ] New Debug Message Levels >=20 > Dear MdePkg maintainer, >=20 > DebugLib.h defines debug message levels. Some values such as DEBUG_ERROR = and > DEBUG_INFO define messages category, whereas other values such as DEBUG_B= LKIO and > DEBUG_VARIABLE define message domain. > This patch adds definitions for several additional message domains. >=20 > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Felix Polyudov > >=20 > Thanks > Felix >=20 > =3D=3D > diff --git a/MdePkg/Include/Library/DebugLib.h b/MdePkg/Include/Library/D= ebugLib.h > index 803872c..47549b7 100644 > --- a/MdePkg/Include/Library/DebugLib.h > +++ b/MdePkg/Include/Library/DebugLib.h > @@ -54,6 +54,12 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EIT= HER EXPRESS > OR IMPLIED. > #define DEBUG_CACHE 0x00200000 // Memory range cachability changes > #define DEBUG_VERBOSE 0x00400000 // Detailed debug messages that may > // significantly impact boot perform= ance > +#define DEBUG_USB 0x00000200 // USB Driver > +#define DEBUG_PCI 0x00000800 // PCI Bus Driver > +#define DEBUG_CSM 0x00002000 // Compatibility Support Module > +#define DEBUG_CPU 0x00008000 // Processor Driver > +#define DEBUG_CHIPSET 0x00040000 // Chipset/SoC Drivers > +#define DEBUG_PLATFORM 0x00800000 // Platform/Board Drivers > #define DEBUG_ERROR 0x80000000 // Error >=20 > // > @@ -75,6 +81,12 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EIT= HER EXPRESS > OR IMPLIED. > #define EFI_D_LOADFILE DEBUG_LOADFILE > #define EFI_D_EVENT DEBUG_EVENT > #define EFI_D_VERBOSE DEBUG_VERBOSE > +#define EFI_D_USB DEBUG_USB > +#define EFI_D_PCI DEBUG_PCI > +#define EFI_D_CSM DEBUG_CSM > +#define EFI_D_CPU DEBUG_CPU > +#define EFI_D_CHIPSET DEBUG_CHIPSET > +#define EFI_D_PLATFORM DEBUG_PLATFORM > #define EFI_D_ERROR DEBUG_ERROR >=20 > /** > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec > index 606e2f1..eaae076 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -1883,15 +1883,21 @@ > # BIT6 - Information message.
> # BIT7 - Dispatcher message.
> # BIT8 - Variable message.
> + # BIT9 - USB Driver message.
> # BIT10 - Boot Manager message.
> + # BIT11 - PCI Bus Driver message.
> # BIT12 - BlockIo Driver message.
> + # BIT13 - Compatibility Support Module message.
> # BIT14 - Network Driver message.
> + # BIT15 - Processor Driver message.
> # BIT16 - UNDI Driver message.
> # BIT17 - LoadFile message.
> + # BIT18 - Chipset/SoC Driver message.
> # BIT19 - Event message.
> # BIT20 - Global Coherency Database changes message.
> # BIT21 - Memory range cachability changes message.
> # BIT22 - Detailed debug message.
> + # BIT23 - Platform/Board Driver message.
> # BIT31 - Error message.
> # @Prompt Fixed Debug Message Print Level. > gEfiMdePkgTokenSpaceGuid.PcdFixedDebugPrintErrorLevel|0xFFFFFFFF|UINT3= 2|0x30001016 > @@ -1951,15 +1957,21 @@ > # BIT6 - Information message.
> # BIT7 - Dispatcher message.
> # BIT8 - Variable message.
> + # BIT9 - USB Driver message.
> # BIT10 - Boot Manager message.
> + # BIT11 - PCI Bus Driver message.
> # BIT12 - BlockIo Driver message.
> + # BIT13 - Compatibility Support Module message.
> # BIT14 - Network Driver message.
> + # BIT15 - Processor Driver message.
> # BIT16 - UNDI Driver message.
> # BIT17 - LoadFile message.
> + # BIT18 - Chipset/SoC Driver message.
> # BIT19 - Event message.
> # BIT20 - Global Coherency Database changes message.
> # BIT21 - Memory range cachability changes message.
> # BIT22 - Detailed debug message.
> + # BIT23 - Platform/Board Driver message.
> # BIT31 - Error message.
> # @Prompt Debug Message Print Level. > # @Expression 0x80000002 | (gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErr= orLevel & > 0x7F84AA00) =3D=3D 0 >=20 > Please consider the environment before printing this email. >=20 > The information contained in this message may be confidential and proprie= tary to > American Megatrends, Inc. This communication is intended to be read only= by the > individual or entity to whom it is addressed or by their designee. If the= reader of > this message is not the intended recipient, you are on notice that any di= stribution > of this message, in any form, is strictly prohibited. Please promptly no= tify the > sender by reply e-mail or by telephone at 770-246-8600, and then delete o= r destroy > all copies of the transmission. > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel