From: "Kinney, Michael D" <michael.d.kinney@intel.com>
To: "Fan, Jeff" <jeff.fan@intel.com>,
"edk2-devel@ml01.01.org" <edk2-devel@ml01.01.org>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [Patch 0/3] Fix Quark platform ASSERT() on GCC tip
Date: Tue, 20 Sep 2016 20:28:54 +0000 [thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F56481A206@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <20160920082911.6908-1-jeff.fan@intel.com>
Jeff,
These changes look good to me and I have verified Galileo boots with these changes.
Series Reviewed-by: Michael Kinney <michael.d.kinney@intel.com>
Mike
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jeff Fan
> Sent: Tuesday, September 20, 2016 1:29 AM
> To: edk2-devel@ml01.01.org
> Subject: [edk2] [Patch 0/3] Fix Quark platform ASSERT() on GCC tip
>
> Flat32.S should set ESP to top of eSRAM range that aligns with Flat32.asm.
> It cause ASSERT() reported at https://tianocore.acgmultimedia.com/show_bug.cgi?id=123
>
> Jeff Fan (3):
> QuarkPlatformPkg/PlatformSecLib: Fix stack pointer issue in Flat32.S
> UefiCpuPkg/SecCore: Fix comment typo
> UefiCpuPkg/SecCore: SecPlatformInformation(2) are optional PPIs
>
> QuarkPlatformPkg/Library/PlatformSecLib/Ia32/Flat32.S | 4 ++--
> UefiCpuPkg/SecCore/SecBist.c | 14 ++++++++------
> 2 files changed, 10 insertions(+), 8 deletions(-)
>
> --
> 2.9.3.windows.2
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2016-09-20 20:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 8:29 [Patch 0/3] Fix Quark platform ASSERT() on GCC tip Jeff Fan
2016-09-20 8:29 ` [Patch 1/3] QuarkPlatformPkg/PlatformSecLib: Fix stack pointer issue in Flat32.S Jeff Fan
2016-09-20 8:29 ` [Patch 2/3] UefiCpuPkg/SecCore: Fix comment typo Jeff Fan
2016-09-20 8:29 ` [Patch 3/3] UefiCpuPkg/SecCore: SecPlatformInformation(2) are optional PPIs Jeff Fan
2016-09-20 20:28 ` Kinney, Michael D [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E92EE9817A31E24EB0585FDF735412F56481A206@ORSMSX113.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox