From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2EBBD1A1DF4 for ; Tue, 20 Sep 2016 13:28:56 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP; 20 Sep 2016 13:28:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,370,1470726000"; d="scan'208";a="11887084" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by orsmga004.jf.intel.com with ESMTP; 20 Sep 2016 13:28:55 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.161]) by ORSMSX102.amr.corp.intel.com ([169.254.3.44]) with mapi id 14.03.0248.002; Tue, 20 Sep 2016 13:28:55 -0700 From: "Kinney, Michael D" To: "Fan, Jeff" , "edk2-devel@ml01.01.org" , "Kinney, Michael D" Thread-Topic: [edk2] [Patch 0/3] Fix Quark platform ASSERT() on GCC tip Thread-Index: AQHSExm01VX3V9LfKUiXGAE3liJ4FaCC1Hxw Date: Tue, 20 Sep 2016 20:28:54 +0000 Message-ID: References: <20160920082911.6908-1-jeff.fan@intel.com> In-Reply-To: <20160920082911.6908-1-jeff.fan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzViMmRkMWEtYzQwZC00NzVhLWJmNGItODNiOTFiZjVmMjk1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IkRubG1qenU2VDVVZGYrUHgzR1l6cEdwMFdUZERWQVdUVzBFVllTXC9QZkU4PSJ9 x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Subject: Re: [Patch 0/3] Fix Quark platform ASSERT() on GCC tip X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2016 20:28:56 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jeff, These changes look good to me and I have verified Galileo boots with these = changes. Series Reviewed-by: Michael Kinney Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Je= ff Fan > Sent: Tuesday, September 20, 2016 1:29 AM > To: edk2-devel@ml01.01.org > Subject: [edk2] [Patch 0/3] Fix Quark platform ASSERT() on GCC tip >=20 > Flat32.S should set ESP to top of eSRAM range that aligns with Flat32.asm= . > It cause ASSERT() reported at https://tianocore.acgmultimedia.com/show_bu= g.cgi?id=3D123 >=20 > Jeff Fan (3): > QuarkPlatformPkg/PlatformSecLib: Fix stack pointer issue in Flat32.S > UefiCpuPkg/SecCore: Fix comment typo > UefiCpuPkg/SecCore: SecPlatformInformation(2) are optional PPIs >=20 > QuarkPlatformPkg/Library/PlatformSecLib/Ia32/Flat32.S | 4 ++-- > UefiCpuPkg/SecCore/SecBist.c | 14 ++++++++-----= - > 2 files changed, 10 insertions(+), 8 deletions(-) >=20 > -- > 2.9.3.windows.2 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel