public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Kinney, Michael D" <michael.d.kinney@intel.com>
To: Tim Lewis <tim.lewis@insyde.com>,
	"Gao, Liming" <liming.gao@intel.com>,
	Boaz Kahana <Boaz_Kahana@Phoenix.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: Protocol EFI_FORM_BROWSER_EXTENSION_PROTOCOL - included in UDK code but not part of the spec
Date: Wed, 21 Sep 2016 16:26:18 +0000	[thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F56481A8DF@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <7236196A5DF6C040855A6D96F556A53F3EEF30@msmail.insydesw.com.tw>

Tim,

That is a good idea.  We should also add a comment block for that typedef to explain why 
the EFI_ name is provided for compatibility.

The rule that should be followed for new Protocols/PPIs/GUIDs that are part of the 
EDK II implementation is to prefix with EDKII_.

Thanks,

Mike


> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Tim Lewis
> Sent: Wednesday, September 21, 2016 9:03 AM
> To: Gao, Liming <liming.gao@intel.com>; Boaz Kahana <Boaz_Kahana@Phoenix.com>; edk2-
> devel@lists.01.org
> Subject: Re: [edk2] Protocol EFI_FORM_BROWSER_EXTENSION_PROTOCOL - included in UDK
> code but not part of the spec
> 
> Liming --
> 
> Could you change the protocol name, and then use a typedef with the old name for
> compatibility?
> 
> Tim
> 
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Gao, Liming
> Sent: Tuesday, September 20, 2016 8:57 PM
> To: Boaz Kahana <Boaz_Kahana@Phoenix.com>; edk2-devel@lists.01.org
> Subject: Re: [edk2] Protocol EFI_FORM_BROWSER_EXTENSION_PROTOCOL - included in UDK
> code but not part of the spec
> 
> Boaz:
>   This protocol is edk2 implement protocol. We have no plan to propose it to UEFI
> spec. Its EFI_ prefix is history reason. To avoid the incompatible change, we don't
> change its definition. But for any new introduced protocol, we will insist on this
> rule without EFI_ prefix.
> 
> Thanks
> Liming
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Boaz Kahana
> > Sent: Friday, September 16, 2016 8:25 AM
> > To: edk2-devel@lists.01.org
> > Subject: [edk2] Protocol EFI_FORM_BROWSER_EXTENSION_PROTOCOL -
> > included in UDK code but not part of the spec
> >
> > The protocol EFI_FORM_BROWSER_EXTENSION_PROTOCOL is defined in
> > MdeModulePkg\Include\Protocol\FormBrowserEx.h with EFI_ prefix
> > although it is not part of the UEFI spec.
> > (It was added by Intel - Liming - in Sep 2011)
> >
> > IMHO it should be added to the UEFI spec otherwise it should not use
> > the EFI_ prefix.
> >
> > Boaz
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2016-09-21 16:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-16  0:24 Protocol EFI_FORM_BROWSER_EXTENSION_PROTOCOL - included in UDK code but not part of the spec Boaz Kahana
2016-09-21  3:56 ` Gao, Liming
2016-09-21 16:03   ` Tim Lewis
2016-09-21 16:26     ` Kinney, Michael D [this message]
2016-09-22  2:08       ` Gao, Liming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E92EE9817A31E24EB0585FDF735412F56481A8DF@ORSMSX113.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox