public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH] Add Pkcs7VerifyPkg
@ 2016-09-21 22:34 Peter Jones
  2016-09-22  2:48 ` Kinney, Michael D
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Jones @ 2016-09-21 22:34 UTC (permalink / raw)
  To: edk2-devel; +Cc: Peter Jones

This patch adds a Pkcs7VerifyPkg package, which builds the Pkcs7Verify
DXE API as a standalone driver.  This allows us to build a driver that
can be loaded on UEFI 2.4 systems, so that UEFI applications can move to
the newer APIs without breaking compatibility.

Signed-off-by: Peter Jones <pjones@redhat.com>
---
 Pkcs7VerifyPkg/Pkcs7VerifyPkg.dec | 25 +++++++++++++++++
 Pkcs7VerifyPkg/Pkcs7VerifyPkg.dsc | 59 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 84 insertions(+)
 create mode 100644 Pkcs7VerifyPkg/Pkcs7VerifyPkg.dec
 create mode 100644 Pkcs7VerifyPkg/Pkcs7VerifyPkg.dsc

diff --git a/Pkcs7VerifyPkg/Pkcs7VerifyPkg.dec b/Pkcs7VerifyPkg/Pkcs7VerifyPkg.dec
new file mode 100644
index 0000000..00d50c9
--- /dev/null
+++ b/Pkcs7VerifyPkg/Pkcs7VerifyPkg.dec
@@ -0,0 +1,25 @@
+## @file
+#
+#  PKCS7 Verify Package
+#
+#  PKCS7 Verify Driver
+#
+#  This program and the accompanying materials are licensed and made available
+#  under the terms and conditions of the BSD License which accompanies this
+#  distribution. The full text of the license may be found at
+#  http://opensource.org/licenses/bsd-license.php
+#
+#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+#
+##
+
+[Defines]
+  DEC_SPECIFICATION              = 0x00010005
+  PACKAGE_NAME                   = Pkcs7VerifyPkg
+  PACKAGE_UNI_FILE               = Pkcs7VerifyPkg.uni
+  PACKAGE_GUID                   = 322d72de-efb5-4ef4-af15-294e31a562fd
+  PACKAGE_VERSION                = 0.1
+
+[Includes]
+  Include
diff --git a/Pkcs7VerifyPkg/Pkcs7VerifyPkg.dsc b/Pkcs7VerifyPkg/Pkcs7VerifyPkg.dsc
new file mode 100644
index 0000000..dff2ab2
--- /dev/null
+++ b/Pkcs7VerifyPkg/Pkcs7VerifyPkg.dsc
@@ -0,0 +1,59 @@
+## @file
+#
+#  Build Binary Pkcs7Verify Driver Modules
+#
+#  This program and the accompanying materials are licensed and made available
+#  under the terms and conditions of the BSD License which accompanies this
+#  distribution. The full text of the license may be found at
+#  http://opensource.org/licenses/bsd-license.php
+#
+#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
+#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+#
+##
+
+[Defines]
+  PLATFORM_NAME                  = Pkcs7Verify
+  PLATFORM_GUID                  = 3346fed4-ba87-42f0-bbf2-ae2be12ad0f0
+  PLATFORM_VERSION               = 0.1
+  DSC_SPECIFICATION              = 0x00010005
+  SUPPORTED_ARCHITECTURES        = IA32|X64|EBC|ARM|AARCH64
+  OUTPUT_DIRECTORY               = Build/Pkcs7VerifyPkg
+  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
+  SKUID_IDENTIFIER               = DEFAULT
+
+[BuildOptions]
+  GCC:RELEASE_*_*_CC_FLAGS             = -DMDEPKG_NDEBUG
+  INTEL:RELEASE_*_*_CC_FLAGS           = /D MDEPKG_NDEBUG
+  MSFT:RELEASE_*_*_CC_FLAGS            = /D MDEPKG_NDEBUG /ALIGN:256
+  RVCT:RELEASE_*_*_CC_FLAGS            = -DMDEPKG_NDEBUG /ALIGN:256
+
+[LibraryClasses]
+  #
+  # Entry Point Libraries
+  #
+  UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
+  #
+  # Common Libraries
+  #
+  UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
+  UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTableLib.inf
+  UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeServicesTableLib.inf
+  BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
+  BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
+  MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
+  DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
+  OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
+  IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
+  PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
+  PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
+  DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
+
+[LibraryClasses.common.DXE_DRIVER]
+  BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
+
+[Components]
+  #
+  # PKCS7 Verification
+  #
+  SecurityPkg/Pkcs7Verify/Pkcs7VerifyDxe/Pkcs7VerifyDxe.inf
-- 
2.10.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Add Pkcs7VerifyPkg
  2016-09-21 22:34 [PATCH] Add Pkcs7VerifyPkg Peter Jones
@ 2016-09-22  2:48 ` Kinney, Michael D
  0 siblings, 0 replies; 2+ messages in thread
From: Kinney, Michael D @ 2016-09-22  2:48 UTC (permalink / raw)
  To: Peter Jones, edk2-devel@ml01.01.org, Kinney, Michael D

Hi Peter,

Instead of adding a new package, would it make more sense to add this DSC
to the SecurityPkg?

Actually, the SecurityPkg.dsc already builds this module.  Does the current
SecurityPkg.dsc use the correct lib mappings, PCD settings, and build flags?

Thanks,

Mike

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Peter Jones
> Sent: Wednesday, September 21, 2016 3:34 PM
> To: edk2-devel@ml01.01.org
> Cc: Peter Jones <pjones@redhat.com>
> Subject: [edk2] [PATCH] Add Pkcs7VerifyPkg
> 
> This patch adds a Pkcs7VerifyPkg package, which builds the Pkcs7Verify
> DXE API as a standalone driver.  This allows us to build a driver that
> can be loaded on UEFI 2.4 systems, so that UEFI applications can move to
> the newer APIs without breaking compatibility.
> 
> Signed-off-by: Peter Jones <pjones@redhat.com>
> ---
>  Pkcs7VerifyPkg/Pkcs7VerifyPkg.dec | 25 +++++++++++++++++
>  Pkcs7VerifyPkg/Pkcs7VerifyPkg.dsc | 59 +++++++++++++++++++++++++++++++++++++++
>  2 files changed, 84 insertions(+)
>  create mode 100644 Pkcs7VerifyPkg/Pkcs7VerifyPkg.dec
>  create mode 100644 Pkcs7VerifyPkg/Pkcs7VerifyPkg.dsc
> 
> diff --git a/Pkcs7VerifyPkg/Pkcs7VerifyPkg.dec b/Pkcs7VerifyPkg/Pkcs7VerifyPkg.dec
> new file mode 100644
> index 0000000..00d50c9
> --- /dev/null
> +++ b/Pkcs7VerifyPkg/Pkcs7VerifyPkg.dec
> @@ -0,0 +1,25 @@
> +## @file
> +#
> +#  PKCS7 Verify Package
> +#
> +#  PKCS7 Verify Driver
> +#
> +#  This program and the accompanying materials are licensed and made available
> +#  under the terms and conditions of the BSD License which accompanies this
> +#  distribution. The full text of the license may be found at
> +#  http://opensource.org/licenses/bsd-license.php
> +#
> +#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +#
> +##
> +
> +[Defines]
> +  DEC_SPECIFICATION              = 0x00010005
> +  PACKAGE_NAME                   = Pkcs7VerifyPkg
> +  PACKAGE_UNI_FILE               = Pkcs7VerifyPkg.uni
> +  PACKAGE_GUID                   = 322d72de-efb5-4ef4-af15-294e31a562fd
> +  PACKAGE_VERSION                = 0.1
> +
> +[Includes]
> +  Include
> diff --git a/Pkcs7VerifyPkg/Pkcs7VerifyPkg.dsc b/Pkcs7VerifyPkg/Pkcs7VerifyPkg.dsc
> new file mode 100644
> index 0000000..dff2ab2
> --- /dev/null
> +++ b/Pkcs7VerifyPkg/Pkcs7VerifyPkg.dsc
> @@ -0,0 +1,59 @@
> +## @file
> +#
> +#  Build Binary Pkcs7Verify Driver Modules
> +#
> +#  This program and the accompanying materials are licensed and made available
> +#  under the terms and conditions of the BSD License which accompanies this
> +#  distribution. The full text of the license may be found at
> +#  http://opensource.org/licenses/bsd-license.php
> +#
> +#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +#
> +##
> +
> +[Defines]
> +  PLATFORM_NAME                  = Pkcs7Verify
> +  PLATFORM_GUID                  = 3346fed4-ba87-42f0-bbf2-ae2be12ad0f0
> +  PLATFORM_VERSION               = 0.1
> +  DSC_SPECIFICATION              = 0x00010005
> +  SUPPORTED_ARCHITECTURES        = IA32|X64|EBC|ARM|AARCH64
> +  OUTPUT_DIRECTORY               = Build/Pkcs7VerifyPkg
> +  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
> +  SKUID_IDENTIFIER               = DEFAULT
> +
> +[BuildOptions]
> +  GCC:RELEASE_*_*_CC_FLAGS             = -DMDEPKG_NDEBUG
> +  INTEL:RELEASE_*_*_CC_FLAGS           = /D MDEPKG_NDEBUG
> +  MSFT:RELEASE_*_*_CC_FLAGS            = /D MDEPKG_NDEBUG /ALIGN:256
> +  RVCT:RELEASE_*_*_CC_FLAGS            = -DMDEPKG_NDEBUG /ALIGN:256
> +
> +[LibraryClasses]
> +  #
> +  # Entry Point Libraries
> +  #
> +  UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntryPoint.inf
> +  #
> +  # Common Libraries
> +  #
> +  UefiLib|MdePkg/Library/UefiLib/UefiLib.inf
> +
> UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBootServicesTabl
> eLib.inf
> +
> UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/UefiRuntimeSer
> vicesTableLib.inf
> +  BaseLib|MdePkg/Library/BaseLib/BaseLib.inf
> +  BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf
> +
> MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.in
> f
> +  DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
> +  OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
> +  IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> +  PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
> +  PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf
> +  DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf
> +
> +[LibraryClasses.common.DXE_DRIVER]
> +  BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
> +
> +[Components]
> +  #
> +  # PKCS7 Verification
> +  #
> +  SecurityPkg/Pkcs7Verify/Pkcs7VerifyDxe/Pkcs7VerifyDxe.inf
> --
> 2.10.0
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-09-22  2:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-21 22:34 [PATCH] Add Pkcs7VerifyPkg Peter Jones
2016-09-22  2:48 ` Kinney, Michael D

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox