From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 56F271A1E28 for ; Sat, 8 Oct 2016 17:54:11 -0700 (PDT) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP; 08 Oct 2016 17:54:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,315,1473145200"; d="scan'208";a="17649878" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by fmsmga005.fm.intel.com with ESMTP; 08 Oct 2016 17:54:10 -0700 Received: from orsmsx114.amr.corp.intel.com (10.22.240.10) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sat, 8 Oct 2016 17:54:10 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.161]) by ORSMSX114.amr.corp.intel.com ([169.254.8.240]) with mapi id 14.03.0248.002; Sat, 8 Oct 2016 17:54:10 -0700 From: "Kinney, Michael D" To: "Yao, Jiewen" , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "Ni, Ruiyu" , "Tian, Feng" , "Gao, Liming" , "Zeng, Star" , "Dong, Eric" Thread-Topic: [edk2] [PATCH 1/3] MdeModulePkg/dec: Add PcdRecoveryFileName PCD. Thread-Index: AQHSIRAYn0jbhZBl00+TDvf5fXYs0KCfTMUQ Date: Sun, 9 Oct 2016 00:54:09 +0000 Message-ID: References: <1475895597-156-1-git-send-email-jiewen.yao@intel.com> <1475895597-156-2-git-send-email-jiewen.yao@intel.com> In-Reply-To: <1475895597-156-2-git-send-email-jiewen.yao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiODcyOTUwZDAtM2I4Ni00NmVhLWE2ODgtOGMwMmQ2NDc1ODQxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Ik9nT3J6Q1dPc1gydENkbGgzVWJtWFlLWVB3azNTdmF6dEd0VTQyT0FQQXM9In0= x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Subject: Re: [PATCH 1/3] MdeModulePkg/dec: Add PcdRecoveryFileName PCD. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Oct 2016 00:54:11 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jiewen, This new PCD is restricted to only support PatchableInMoule. I think it should be moved to support all types and be in section: [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] Thanks, Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ji= ewen Yao > Sent: Friday, October 7, 2016 8:00 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Tian, Feng ; Gao= , Liming > ; Zeng, Star ; Dong, Eric > > Subject: [edk2] [PATCH 1/3] MdeModulePkg/dec: Add PcdRecoveryFileName PCD= . >=20 > This PCD is used to indicated the recovery file name. > The previous name - FvMain.Fv is hardcoded in FatPei and CdExpressPei. > It does not make sense to force the name. >=20 > Now a platform may use any recovery file name. >=20 > Cc: Feng Tian > Cc: Star Zeng > Cc: Liming Gao > Cc: Eric Dong > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jiewen Yao > --- > MdeModulePkg/MdeModulePkg.dec | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.de= c > index 1e88568..0d0691a 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -1674,6 +1674,12 @@ > # @ValidList 0x80000001 | 0 >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdLoadFixAddressSmmCodePageNumber|0|UINT3= 2|0x0000002c >=20 > + ## This is recover file name in PEI phase. > + # The file must be in the root directory. > + # The file name must be the 8.3 format. > + # The PCD data must be in UNICODE format. > + gEfiMdeModulePkgTokenSpaceGuid.PcdRecoveryFileName|L"FVMAIN.FV"|VOID*|= 0x00001019 > + > [PcdsDynamic, PcdsDynamicEx] > ## This dynamic PCD hold an address to point to private data structure= used in > DxeS3BootScriptLib library > # instance which records the S3 boot script table start address, leng= th, etc. To > introduce this PCD is > -- > 2.7.4.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel