From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2DB981A1E28 for ; Sun, 9 Oct 2016 10:25:15 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP; 09 Oct 2016 10:25:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,467,1473145200"; d="scan'208";a="178099482" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by fmsmga004.fm.intel.com with ESMTP; 09 Oct 2016 10:25:15 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.161]) by ORSMSX110.amr.corp.intel.com ([169.254.10.12]) with mapi id 14.03.0248.002; Sun, 9 Oct 2016 10:25:14 -0700 From: "Kinney, Michael D" To: "Yao, Jiewen" , "edk2-devel@lists.01.org" , "Kinney, Michael D" Thread-Topic: [edk2] [PATCH 0/4] Show test key info on front page Thread-Index: AQHSIiR+Eu1GFzqy/02Uj0PjoiVnrKCgXyLw Date: Sun, 9 Oct 2016 17:25:13 +0000 Message-ID: References: <1476014313-11992-1-git-send-email-jiewen.yao@intel.com> In-Reply-To: <1476014313-11992-1-git-send-email-jiewen.yao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWQ3YzZlOTMtZmUwMy00NWY3LThiNWEtOTZlNzBkMTNlNzZlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InJkUzErUFlcL2JPdlNQbGl4UWppV3V1SktkR2w5S2Q1b3lrazdMQkVCUVRNPSJ9 x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Subject: Re: [PATCH 0/4] Show test key info on front page X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Oct 2016 17:25:15 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jiewen, It does not make sense to put the check for use of test keys into a platfor= m specific=20 library that requires every platform to implement that logic. The real cons= umers of these=20 keys are the section extraction libs in the SecurityPkg. Can we move these= checks into those libraries? Mike=20 > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ji= ewen Yao > Sent: Sunday, October 9, 2016 4:58 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 0/4] Show test key info on front page >=20 > This series patch supports to show the test key information > on the front page. > PcdTestKeyUsed is added to MdeModulePkg. >=20 > This PCD can be set by platform to indicate if there is any > test key used in current BIOS, such as recovery key, > or capsule update key. > Then the generic UI may consume this PCD to show warning information. >=20 > Jiewen Yao (4): > MdeModulePkg/dec: Add PcdTestKeyUsed PCD. > MdeModulePkg/UiApp: Show test key warning info in FrontPage. > QuarkPlatformPkg/Bds: Produce PcdTestKeyUsed. > Vlv2TbleDevicePkg/Bds: Produce PcdTestKeyUsed. >=20 > MdeModulePkg/Application/UiApp/FrontPageCustomizedUi.c = | 34 > ++++++++++++++++++++ > MdeModulePkg/Application/UiApp/FrontPageStrings.uni = | 8 > ++++- > MdeModulePkg/Application/UiApp/UiApp.inf = | 3 +- > MdeModulePkg/MdeModulePkg.dec = | 11 > +++++++ > QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager.c = | 11 > +++++++ > QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManager.h = | 5 +++ > QuarkPlatformPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i= nf | 1 + > Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c = | 11 > +++++++ > Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.h = | 5 +++ > Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf = | 2 ++ > 10 files changed, 89 insertions(+), 2 deletions(-) >=20 > -- > 2.7.4.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel