From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3BE461A1DEF for ; Sun, 9 Oct 2016 20:53:50 -0700 (PDT) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP; 09 Oct 2016 20:53:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,470,1473145200"; d="scan'208,217";a="1062634789" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga002.jf.intel.com with ESMTP; 09 Oct 2016 20:53:49 -0700 Received: from orsmsx162.amr.corp.intel.com (10.22.240.85) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 9 Oct 2016 20:53:49 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.161]) by ORSMSX162.amr.corp.intel.com ([10.22.240.85]) with mapi id 14.03.0248.002; Sun, 9 Oct 2016 20:53:49 -0700 From: "Kinney, Michael D" To: "Yao, Jiewen" , "edk2-devel@lists.01.org" , "Kinney, Michael D" Thread-Topic: [edk2] [PATCH V2 0/3] Add PcdRecoveryFileName PCD. Thread-Index: AQHSIcx2CBGfFQqj9EmBYsXDJ1VBCaCgYbRggAEfR4D//48P4A== Date: Mon, 10 Oct 2016 03:53:48 +0000 Message-ID: References: <1475976509-7580-1-git-send-email-jiewen.yao@intel.com> <74D8A39837DF1E4DA445A8C0B3885C50386A07B8@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C50386A07B8@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTIxMjVkYjgtNjBjZi00ODE2LWIyYTgtNWUyMmUyZmQ0NGRhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjBHV3dPTzhEU0ljalJGSWlidGc0WGNOWnJKcTczdnRNQSsybHBrUXVKS0k9In0= x-originating-ip: [10.22.254.139] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH V2 0/3] Add PcdRecoveryFileName PCD. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Oct 2016 03:53:50 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jiewen, That is one of the values I tried. Maybe it is a build or merge issue on m= y end. I will try again. Mike From: Yao, Jiewen Sent: Sunday, October 9, 2016 8:37 PM To: Kinney, Michael D ; edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: RE: [edk2] [PATCH V2 0/3] Add PcdRecoveryFileName PCD. Hi Mike I am surprised to hear that. I double check it just now. It still works well. I am using below: gEfiMdeModulePkgTokenSpaceGuid.PcdRecoveryFileName|L"QUARKREC.Cap" What do you configure? Thank you Yao Jiewen From: Kinney, Michael D Sent: Monday, October 10, 2016 1:32 AM To: Yao, Jiewen >; edk2-d= evel@lists.01.org; Kinney, Michael D > Subject: RE: [edk2] [PATCH V2 0/3] Add PcdRecoveryFileName PCD. Jiewen, Not sure what is wrong, but if I set this PCD to a different value, the recovery image can not be found on the recovery media. For example, if I update Quark DSC to use the value QUARKREC.CAP, and I put that file on the same USB FLASH drive that worked with default value of FVMAIN.FV, the file can not be found. Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ji= ewen Yao > Sent: Saturday, October 8, 2016 6:28 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH V2 0/3] Add PcdRecoveryFileName PCD. > > The V2 version moves PCD to [PcdsFixedAtBuild, > PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > This PCD is used to indicated the recovery file name. > The previous name - FvMain.Fv is hardcoded in FatPei and CdExpressPei. > It does not make sense to force the name. > > Now a platform may use any recovery file name. > > Jiewen Yao (3): > MdeModulePkg/dec: Add PcdRecoveryFileName PCD. > MdeModulePkg/CdExpressPei: Use PcdRecoveryFileName PCD. > FatPkg/FatPei: Use PcdRecoveryFileName PCD. > > FatPkg/FatPei/FatLiteApi.c | 8 ++++---- > FatPkg/FatPei/FatLitePeim.h | 4 +--- > FatPkg/FatPei/FatPei.inf | 5 ++++- > MdeModulePkg/MdeModulePkg.dec | 6 ++++++ > MdeModulePkg/Universal/Disk/CdExpressPei/CdExpressPei.inf | 5 ++++- > MdeModulePkg/Universal/Disk/CdExpressPei/PeiCdExpress.c | 16 +++++++++= +++++-- > MdeModulePkg/Universal/Disk/CdExpressPei/PeiCdExpress.h | 7 +------ > 7 files changed, 34 insertions(+), 17 deletions(-) > > -- > 2.7.4.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel