Re: [PATCH V2 0/3] Add PcdRecoveryFileName PCD.

["Kinney, Michael D" <michael.d.kinney@intel.com>]

Jiewen,

I have resolved my build issue.  I have verified that using a recovery 
filename of L"QUARKREC.Cap" works.

However, as part of my testing, I added this PCD to a [PcdsFixedAtBuild]
section and the FAT PEIM does not build.  With this PCD type the PcdGetPtr() 
function returns a CONST pointer and the FindRecoveryFile() requires a non 
CONST pointer.

The fix is to cast the value returned by PcdGetPtr() to CHAR16 *.

-    Status = FindRecoveryFile (PrivateData, Index, PcdGetPtr(PcdRecoveryFileName), &Handle);
+    Status = FindRecoveryFile (PrivateData, Index, (CHAR16 *)PcdGetPtr (PcdRecoveryFileName), &Handle);

There are 3 instances of this in the FAT PEIM that need to be fixed.

Thanks,

Mike




From: Yao, Jiewen 
Sent: Sunday, October 9, 2016 8:37 PM
To: Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel@lists.01.org
Cc: Yao, Jiewen <jiewen.yao@intel.com>
Subject: RE: [edk2] [PATCH V2 0/3] Add PcdRecoveryFileName PCD.

Hi Mike
I am surprised to hear that.

I double check it just now. It still works well.

I am using below:
  gEfiMdeModulePkgTokenSpaceGuid.PcdRecoveryFileName|L"QUARKREC.Cap"

What do you configure?

Thank you
Yao Jiewen

From: Kinney, Michael D 
Sent: Monday, October 10, 2016 1:32 AM
To: Yao, Jiewen <jiewen.yao@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: RE: [edk2] [PATCH V2 0/3] Add PcdRecoveryFileName PCD.

Jiewen,

Not sure what is wrong, but if I set this PCD to a different value, the
recovery image can not be found on the recovery media.  For example, if I
update Quark DSC to use the value QUARKREC.CAP, and I put that file on
the same USB FLASH drive that worked with default value of FVMAIN.FV, the
file can not be found.

Mike

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jiewen Yao
> Sent: Saturday, October 8, 2016 6:28 PM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH V2 0/3] Add PcdRecoveryFileName PCD.
> 
> The V2 version moves PCD to [PcdsFixedAtBuild,
> PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
> 
> =========================
> This PCD is used to indicated the recovery file name.
> The previous name - FvMain.Fv is hardcoded in FatPei and CdExpressPei.
> It does not make sense to force the name.
> 
> Now a platform may use any recovery file name.
> 
> Jiewen Yao (3):
>   MdeModulePkg/dec: Add PcdRecoveryFileName PCD.
>   MdeModulePkg/CdExpressPei: Use PcdRecoveryFileName PCD.
>   FatPkg/FatPei: Use PcdRecoveryFileName PCD.
> 
>  FatPkg/FatPei/FatLiteApi.c                                |  8 ++++----
>  FatPkg/FatPei/FatLitePeim.h                               |  4 +---
>  FatPkg/FatPei/FatPei.inf                                  |  5 ++++-
>  MdeModulePkg/MdeModulePkg.dec                             |  6 ++++++
>  MdeModulePkg/Universal/Disk/CdExpressPei/CdExpressPei.inf |  5 ++++-
>  MdeModulePkg/Universal/Disk/CdExpressPei/PeiCdExpress.c   | 16 ++++++++++++++--
>  MdeModulePkg/Universal/Disk/CdExpressPei/PeiCdExpress.h   |  7 +------
>  7 files changed, 34 insertions(+), 17 deletions(-)
> 
> --
> 2.7.4.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel