From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C3C241A1E6B for ; Mon, 10 Oct 2016 17:43:11 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP; 10 Oct 2016 17:43:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,327,1473145200"; d="scan'208";a="1042947488" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by orsmga001.jf.intel.com with ESMTP; 10 Oct 2016 17:43:12 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.161]) by ORSMSX110.amr.corp.intel.com ([169.254.10.12]) with mapi id 14.03.0248.002; Mon, 10 Oct 2016 17:43:11 -0700 From: "Kinney, Michael D" To: "Yao, Jiewen" , "edk2-devel@lists.01.org" , "Kinney, Michael D" Thread-Topic: [edk2] [PATCH V2 0/3] Add PcdRecoveryFileName PCD. Thread-Index: AQHSIcx2CBGfFQqj9EmBYsXDJ1VBCaCgYbRggAEfR4CAAOrRwA== Date: Tue, 11 Oct 2016 00:43:10 +0000 Message-ID: References: <1475976509-7580-1-git-send-email-jiewen.yao@intel.com> <74D8A39837DF1E4DA445A8C0B3885C50386A07B8@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C50386A07B8@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDk4YWU2ZDYtMGI4NC00MDE0LTk2YWMtMWViN2M0NDc2MDg2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InRpdVE4RzRhUTkwTk45bGZVT0MxSmJjSjlMYWRJaStVMzUyMWE4WUJFMzg9In0= x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Subject: Re: [PATCH V2 0/3] Add PcdRecoveryFileName PCD. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2016 00:43:12 -0000 Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Jiewen, I have resolved my build issue. I have verified that using a recovery=20 filename of L"QUARKREC.Cap" works. However, as part of my testing, I added this PCD to a [PcdsFixedAtBuild] section and the FAT PEIM does not build. With this PCD type the PcdGetPtr(= )=20 function returns a CONST pointer and the FindRecoveryFile() requires a non= =20 CONST pointer. The fix is to cast the value returned by PcdGetPtr() to CHAR16 *. - Status =3D FindRecoveryFile (PrivateData, Index, PcdGetPtr(PcdRecovery= FileName), &Handle); + Status =3D FindRecoveryFile (PrivateData, Index, (CHAR16 *)PcdGetPtr (= PcdRecoveryFileName), &Handle); There are 3 instances of this in the FAT PEIM that need to be fixed. Thanks, Mike From: Yao, Jiewen=20 Sent: Sunday, October 9, 2016 8:37 PM To: Kinney, Michael D ; edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: RE: [edk2] [PATCH V2 0/3] Add PcdRecoveryFileName PCD. Hi Mike I am surprised to hear that. I double check it just now. It still works well. I am using below: =A0 gEfiMdeModulePkgTokenSpaceGuid.PcdRecoveryFileName|L"QUARKREC.Cap" What do you configure? Thank you Yao Jiewen From: Kinney, Michael D=20 Sent: Monday, October 10, 2016 1:32 AM To: Yao, Jiewen ; edk2-devel@lists.01.org; Kinney, Mi= chael D Subject: RE: [edk2] [PATCH V2 0/3] Add PcdRecoveryFileName PCD. Jiewen, Not=A0sure=A0what=A0is=A0wrong,=A0but=A0if=A0I=A0set=A0this=A0PCD=A0to=A0a= =A0different=A0value,=A0the recovery=A0image=A0can=A0not=A0be=A0found=A0on=A0the=A0recovery=A0media.=A0= =A0For=A0example,=A0if=A0I update=A0Quark=A0DSC=A0to=A0use=A0the=A0value=A0QUARKREC.CAP,=A0and=A0I=A0p= ut=A0that=A0file=A0on the=A0same=A0USB=A0FLASH=A0drive=A0that=A0worked=A0with=A0default=A0value= =A0of=A0FVMAIN.FV,=A0the file=A0can=A0not=A0be=A0found. Mike >=A0-----Original=A0Message----- >=A0From:=A0edk2-devel=A0[mailto:edk2-devel-bounces@lists.01.org]=A0On=A0Be= half=A0Of=A0Jiewen=A0Yao >=A0Sent:=A0Saturday,=A0October=A08,=A02016=A06:28=A0PM >=A0To:=A0edk2-devel@lists.01.org >=A0Subject:=A0[edk2]=A0[PATCH=A0V2=A00/3]=A0Add=A0PcdRecoveryFileName=A0PC= D. >=A0 >=A0The=A0V2=A0version=A0moves=A0PCD=A0to=A0[PcdsFixedAtBuild, >=A0PcdsPatchableInModule,=A0PcdsDynamic,=A0PcdsDynamicEx] >=A0 >=A0=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D >=A0This=A0PCD=A0is=A0used=A0to=A0indicated=A0the=A0recovery=A0file=A0name. >=A0The=A0previous=A0name=A0-=A0FvMain.Fv=A0is=A0hardcoded=A0in=A0FatPei=A0= and=A0CdExpressPei. >=A0It=A0does=A0not=A0make=A0sense=A0to=A0force=A0the=A0name. >=A0 >=A0Now=A0a=A0platform=A0may=A0use=A0any=A0recovery=A0file=A0name. >=A0 >=A0Jiewen=A0Yao=A0(3): >=A0=A0=A0MdeModulePkg/dec:=A0Add=A0PcdRecoveryFileName=A0PCD. >=A0=A0=A0MdeModulePkg/CdExpressPei:=A0Use=A0PcdRecoveryFileName=A0PCD. >=A0=A0=A0FatPkg/FatPei:=A0Use=A0PcdRecoveryFileName=A0PCD. >=A0 >=A0=A0FatPkg/FatPei/FatLiteApi.c=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0|=A0=A08=A0++++---- >=A0=A0FatPkg/FatPei/FatLitePeim.h=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0|=A0=A04=A0+--- >=A0=A0FatPkg/FatPei/FatPei.inf=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0|=A0=A05=A0++++= - >=A0=A0MdeModulePkg/MdeModulePkg.dec=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0|=A0=A06=A0++++++ >=A0=A0MdeModulePkg/Universal/Disk/CdExpressPei/CdExpressPei.inf=A0|=A0=A05= =A0++++- >=A0=A0MdeModulePkg/Universal/Disk/CdExpressPei/PeiCdExpress.c=A0=A0=A0|=A0= 16=A0++++++++++++++-- >=A0=A0MdeModulePkg/Universal/Disk/CdExpressPei/PeiCdExpress.h=A0=A0=A0|=A0= =A07=A0+------ >=A0=A07=A0files=A0changed,=A034=A0insertions(+),=A017=A0deletions(-) >=A0 >=A0-- >=A02.7.4.windows.1 >=A0 >=A0_______________________________________________ >=A0edk2-devel=A0mailing=A0list >=A0edk2-devel@lists.01.org >=A0https://lists.01.org/mailman/listinfo/edk2-devel