Re: [PATCH V3 0/3] Add PcdRecoveryFileName PCD.

["Kinney, Michael D" <michael.d.kinney@intel.com>]

Jiewen,

This update looks good.  The series of 3 patches

Reviewed-by: Michael Kinney <michael.d.kinney@intel.com>

Mike

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jiewen Yao
> Sent: Monday, October 10, 2016 6:04 PM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Tian, Feng <feng.tian@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Zeng, Star <star.zeng@intel.com>; Dong, Eric
> <eric.dong@intel.com>
> Subject: [edk2] [PATCH V3 0/3] Add PcdRecoveryFileName PCD.
> 
> The V3 version fixes PcdGetPtr() type cast issue in FatPei.
> 
> =========================
> The V2 version moves PCD to [PcdsFixedAtBuild,
> PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
> 
> =========================
> This PCD is used to indicated the recovery file name.
> The previous name - FvMain.Fv is hardcoded in FatPei and CdExpressPei.
> It does not make sense to force the name.
> 
> Now a platform may use any recovery file name.
> 
> 
> Tested-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Cc: Feng Tian <feng.tian@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
> Reviewed-by: Feng Tian <feng.tian@intel.com>
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
> 
> 
> Jiewen Yao (3):
>   MdeModulePkg/dec: Add PcdRecoveryFileName PCD.
>   MdeModulePkg/CdExpressPei: Use PcdRecoveryFileName PCD.
>   FatPkg/FatPei: Use PcdRecoveryFileName PCD.
> 
>  FatPkg/FatPei/FatLiteApi.c                                |  8 ++++----
>  FatPkg/FatPei/FatLitePeim.h                               |  4 +---
>  FatPkg/FatPei/FatPei.inf                                  |  5 ++++-
>  MdeModulePkg/MdeModulePkg.dec                             |  6 ++++++
>  MdeModulePkg/Universal/Disk/CdExpressPei/CdExpressPei.inf |  5 ++++-
>  MdeModulePkg/Universal/Disk/CdExpressPei/PeiCdExpress.c   | 16 ++++++++++++++--
>  MdeModulePkg/Universal/Disk/CdExpressPei/PeiCdExpress.h   |  7 +------
>  7 files changed, 34 insertions(+), 17 deletions(-)
> 
> --
> 2.7.4.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel