From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 65BE81A1E9B for ; Tue, 11 Oct 2016 11:46:08 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP; 11 Oct 2016 11:46:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,330,1473145200"; d="scan'208";a="18524859" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by fmsmga006.fm.intel.com with ESMTP; 11 Oct 2016 11:46:07 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.161]) by ORSMSX109.amr.corp.intel.com ([169.254.11.11]) with mapi id 14.03.0248.002; Tue, 11 Oct 2016 11:46:07 -0700 From: "Kinney, Michael D" To: "Yao, Jiewen" , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "Ni, Ruiyu" , "Tian, Feng" , "Gao, Liming" , "Zeng, Star" , "Dong, Eric" Thread-Topic: [edk2] [PATCH V3 0/3] Add PcdRecoveryFileName PCD. Thread-Index: AQHSI1t0v2HVHOIBwUyznMi7qbK9u6CjmE4w Date: Tue, 11 Oct 2016 18:46:06 +0000 Message-ID: References: <1476147853-15976-1-git-send-email-jiewen.yao@intel.com> In-Reply-To: <1476147853-15976-1-git-send-email-jiewen.yao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYWI2ZGMzMjAtOWRlMi00YTZhLTkyZTctN2Q3MjBmMzJmZTJhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InZCM0VLbTRnNkt6RGlpVXpUXC8yYjIrWWtkeWJrMU5tTnBralFySWYwNms4PSJ9 x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Subject: Re: [PATCH V3 0/3] Add PcdRecoveryFileName PCD. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2016 18:46:08 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jiewen, This update looks good. The series of 3 patches Reviewed-by: Michael Kinney Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ji= ewen Yao > Sent: Monday, October 10, 2016 6:04 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu ; Tian, Feng ; Gao= , Liming > ; Zeng, Star ; Dong, Eric > > Subject: [edk2] [PATCH V3 0/3] Add PcdRecoveryFileName PCD. >=20 > The V3 version fixes PcdGetPtr() type cast issue in FatPei. >=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > The V2 version moves PCD to [PcdsFixedAtBuild, > PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] >=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > This PCD is used to indicated the recovery file name. > The previous name - FvMain.Fv is hardcoded in FatPei and CdExpressPei. > It does not make sense to force the name. >=20 > Now a platform may use any recovery file name. >=20 >=20 > Tested-by: Michael D Kinney >=20 > Cc: Feng Tian > Cc: Star Zeng > Cc: Liming Gao > Cc: Eric Dong > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jiewen Yao > Reviewed-by: Feng Tian > Reviewed-by: Ruiyu Ni >=20 >=20 > Jiewen Yao (3): > MdeModulePkg/dec: Add PcdRecoveryFileName PCD. > MdeModulePkg/CdExpressPei: Use PcdRecoveryFileName PCD. > FatPkg/FatPei: Use PcdRecoveryFileName PCD. >=20 > FatPkg/FatPei/FatLiteApi.c | 8 ++++---- > FatPkg/FatPei/FatLitePeim.h | 4 +--- > FatPkg/FatPei/FatPei.inf | 5 ++++- > MdeModulePkg/MdeModulePkg.dec | 6 ++++++ > MdeModulePkg/Universal/Disk/CdExpressPei/CdExpressPei.inf | 5 ++++- > MdeModulePkg/Universal/Disk/CdExpressPei/PeiCdExpress.c | 16 +++++++++= +++++-- > MdeModulePkg/Universal/Disk/CdExpressPei/PeiCdExpress.h | 7 +------ > 7 files changed, 34 insertions(+), 17 deletions(-) >=20 > -- > 2.7.4.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel