From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 61D7E1A1DF5 for ; Wed, 12 Oct 2016 10:11:16 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP; 12 Oct 2016 10:11:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,336,1473145200"; d="scan'208";a="18965235" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga005.jf.intel.com with ESMTP; 12 Oct 2016 10:11:15 -0700 Received: from orsmsx152.amr.corp.intel.com (10.22.226.39) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 12 Oct 2016 10:11:15 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.161]) by ORSMSX152.amr.corp.intel.com ([10.22.226.39]) with mapi id 14.03.0248.002; Wed, 12 Oct 2016 10:11:15 -0700 From: "Kinney, Michael D" To: "Zhu, Yonghong" , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "Steele, Kelly" , "Gao, Liming" Thread-Topic: [Patch 1/2] BaseTools/GenFds: Support FDF sections in any order Thread-Index: AQHSJD76afaN4U8WFUSi+9hWa3enEKClDK8Q Date: Wed, 12 Oct 2016 17:11:14 +0000 Message-ID: References: <1475875986-9148-1-git-send-email-michael.d.kinney@intel.com> <1475875986-9148-2-git-send-email-michael.d.kinney@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmZmMmM1NGItNmVlOS00MjIxLTkyNmQtNjA3MzE0NmYwY2U0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjVKSEYyajZTZktGaXd6Yk9ZQlo5RWk0bWJWVE1kbkNiNXNsaFBjdXVZelE9In0= x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: [Patch 1/2] BaseTools/GenFds: Support FDF sections in any order X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Oct 2016 17:11:16 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Zhu Yonghong, Thanks for the RB on the first patch in that series. Your patch:=20 https://lists.01.org/pipermail/edk2-devel/2016-October/002507.html [Patch] BaseTools: Extend FMP to support FV statement and FD statement is a better solution to the OUTPUT_DIRECTORY issue, so I am dropping=20 https://lists.01.org/pipermail/edk2-devel/2016-October/002481.html [Patch 2/2] BaseTools/GenFds: Skip parse time OUTPUT_DIRECTORY file verif= y Thanks, Mike > -----Original Message----- > From: Zhu, Yonghong > Sent: Tuesday, October 11, 2016 9:13 PM > To: Kinney, Michael D ; edk2-devel@lists.01.o= rg > Cc: Steele, Kelly ; Gao, Liming ; Zhu, > Yonghong > Subject: RE: [Patch 1/2] BaseTools/GenFds: Support FDF sections in any or= der >=20 > This patch is fine to me. >=20 > Reviewed-by: Yonghong Zhu >=20 > Best Regards, > Zhu Yonghong >=20 > -----Original Message----- > From: Kinney, Michael D > Sent: Saturday, October 08, 2016 5:33 AM > To: edk2-devel@lists.01.org > Cc: Steele, Kelly ; Zhu, Yonghong ; > Gao, Liming > Subject: [Patch 1/2] BaseTools/GenFds: Support FDF sections in any order >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D141 >=20 > This patch updates EDK II FDF parser in GenFds to allow sections to be pl= aced in any > order in the FDF file. >=20 > Cc: Kelly Steele > Cc: Yonghong Zhu > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Michael Kinney > --- > BaseTools/Source/Python/GenFds/FdfParser.py | 23 ++++------------------- > 1 file changed, 4 insertions(+), 19 deletions(-) >=20 > diff --git a/BaseTools/Source/Python/GenFds/FdfParser.py > b/BaseTools/Source/Python/GenFds/FdfParser.py > index 02ae7c9..693128c 100644 > --- a/BaseTools/Source/Python/GenFds/FdfParser.py > +++ b/BaseTools/Source/Python/GenFds/FdfParser.py > @@ -1385,25 +1385,10 @@ class FdfParser: >=20 > try: > self.Preprocess() > - while self.__GetFd(): > - pass > - > - while self.__GetFv(): > - pass > - > - while self.__GetFmp(): > - pass > - > - while self.__GetCapsule(): > - pass > - > - while self.__GetVtf(): > - pass > - > - while self.__GetRule(): > - pass > - > - while self.__GetOptionRom(): > + # > + # Keep processing sections of the FDF until no new sections = or a syntax > error is found > + # > + while self.__GetFd() or self.__GetFv() or self.__GetFmp() or > self.__GetCapsule() or self.__GetVtf() or self.__GetRule() or self.__GetO= ptionRom(): > pass >=20 > except Warning, X: > -- > 2.6.3.windows.1