From: "Kinney, Michael D" <michael.d.kinney@intel.com>
To: Gary Lin <glin@suse.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: [PATCH 27/33] QuarkPlatformPkg: Fix typos in comments
Date: Tue, 25 Oct 2016 20:53:01 +0000 [thread overview]
Message-ID: <E92EE9817A31E24EB0585FDF735412F56483ADA9@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <20161019070138.16424-28-glin@suse.com>
Gary,
Thanks for these updates. I made sure the Copyright year was updated
to 2016. With that change:
Reviewed-by: Michael D Kinney <michael.d.kinney@intel.com>
It has been committed at:
commit 65aec00829912662cbfe842ab747d7608fc90553
Mike
> -----Original Message-----
> From: Gary Lin [mailto:glin@suse.com]
> Sent: Wednesday, October 19, 2016 12:02 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Steele, Kelly
> <kelly.steele@intel.com>
> Subject: [PATCH 27/33] QuarkPlatformPkg: Fix typos in comments
>
> - TURE -> TRUE
> - reseting -> resetting
> - retore -> restore
> - boundry -> boundary
> - tempory -> temporary
>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Kelly Steele <kelly.steele@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Gary Lin <glin@suse.com>
> ---
> QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c | 6 +++---
> QuarkPlatformPkg/Acpi/Dxe/BootScriptExecutorDxe/ScriptExecute.c | 2 +-
> QuarkPlatformPkg/Acpi/DxeSmm/AcpiSmm/AcpiSmmPlatform.c | 2 +-
> QuarkPlatformPkg/Platform/Pei/PlatformInit/PlatformEarlyInit.c | 6 +++---
> 4 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c
> b/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c
> index 96af046..28d7016 100644
> --- a/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c
> +++ b/QuarkPlatformPkg/Acpi/Dxe/AcpiPlatform/AcpiPciUpdate.c
> @@ -87,7 +87,7 @@ SdtGetInteger (
> @param OpCode Expected OpCode
> @param SubOpCode Expected SubOpCode
>
> - @retval TURE This handle has expected opcode
> + @retval TRUE This handle has expected opcode
> @retval FALSE This handle does not have expected opcode
> **/
> BOOLEAN
> @@ -127,7 +127,7 @@ SdtIsThisTypeObject (
> @param Name Expected name
> @param Value Expected name value
>
> - @retval TURE This handle has expected name and name value.
> + @retval TRUE This handle has expected name and name value.
> @retval FALSE This handle does not have expected name and name value.
> **/
> BOOLEAN
> @@ -176,7 +176,7 @@ SdtIsNameIntegerValueEqual (
> @param Name Expected name
> @param Value Expected name value
>
> - @retval TURE This handle's children has expected name and name value.
> + @retval TRUE This handle's children has expected name and name value.
> @retval FALSE This handle's children does not have expected name and name value.
> **/
> BOOLEAN
> diff --git a/QuarkPlatformPkg/Acpi/Dxe/BootScriptExecutorDxe/ScriptExecute.c
> b/QuarkPlatformPkg/Acpi/Dxe/BootScriptExecutorDxe/ScriptExecute.c
> index a1a18c9..63f8ae5 100644
> --- a/QuarkPlatformPkg/Acpi/Dxe/BootScriptExecutorDxe/ScriptExecute.c
> +++ b/QuarkPlatformPkg/Acpi/Dxe/BootScriptExecutorDxe/ScriptExecute.c
> @@ -225,7 +225,7 @@ BootScriptExecutorEntryPoint (
> }
> ImageContext.ImageAddress = (PHYSICAL_ADDRESS)(UINTN)FfsBuffer;
> //
> - // Align buffer on section boundry
> + // Align buffer on section boundary
> //
> ImageContext.ImageAddress += ImageContext.SectionAlignment - 1;
> ImageContext.ImageAddress &= ~(ImageContext.SectionAlignment - 1);
> diff --git a/QuarkPlatformPkg/Acpi/DxeSmm/AcpiSmm/AcpiSmmPlatform.c
> b/QuarkPlatformPkg/Acpi/DxeSmm/AcpiSmm/AcpiSmmPlatform.c
> index 321cf62..7df7459 100644
> --- a/QuarkPlatformPkg/Acpi/DxeSmm/AcpiSmm/AcpiSmmPlatform.c
> +++ b/QuarkPlatformPkg/Acpi/DxeSmm/AcpiSmm/AcpiSmmPlatform.c
> @@ -501,7 +501,7 @@ RestoreQncS3SwCallback (
> /*++
>
> Routine Description:
> - SMI handler to retore QncS3 code & context for S3 path
> + SMI handler to restore QncS3 code & context for S3 path
> This will be only triggered when BootScript got executed during resume
>
> Arguments:
> diff --git a/QuarkPlatformPkg/Platform/Pei/PlatformInit/PlatformEarlyInit.c
> b/QuarkPlatformPkg/Platform/Pei/PlatformInit/PlatformEarlyInit.c
> index 0f71b1f..88b50c1 100644
> --- a/QuarkPlatformPkg/Platform/Pei/PlatformInit/PlatformEarlyInit.c
> +++ b/QuarkPlatformPkg/Platform/Pei/PlatformInit/PlatformEarlyInit.c
> @@ -142,7 +142,7 @@ SetLanControllerMacAddr (
> SaveBarReg = PciRead32 (DevPcieAddr + R_IOH_MAC_MEMBAR);
>
> //
> - // Use predefined tempory memory resource
> + // Use predefined temporary memory resource
> //
> PciWrite32 ( DevPcieAddr + R_IOH_MAC_MEMBAR, Bar0);
> PciWrite8 ( DevPcieAddr + PCI_COMMAND_OFFSET, EFI_PCI_COMMAND_MEMORY_SPACE);
> @@ -800,7 +800,7 @@ CheckForResetDueToErrors (
>
> //
> // Check if RMU reset system due to access violations.
> - // RMU updates a SOC Unit register before reseting the system.
> + // RMU updates a SOC Unit register before resetting the system.
> //
> RegValue = QNCAltPortRead (QUARK_SCSS_SOC_UNIT_SB_PORT_ID,
> QUARK_SCSS_SOC_UNIT_CFG_STICKY_RW);
> if ((RegValue & B_CFG_STICKY_RW_VIOLATION) != 0) {
> @@ -1048,7 +1048,7 @@ EarlyPlatformGpioCtrlerInitAndManipulation (
> SaveBarReg = PciRead32 (DevPcieAddr + PcdGet8 (PcdIohGpioBarRegister));
>
> //
> - // Use predefined tempory memory resource.
> + // Use predefined temporary memory resource.
> //
> PciWrite32 ( DevPcieAddr + PcdGet8 (PcdIohGpioBarRegister), IohGpioBase);
> PciWrite8 ( DevPcieAddr + PCI_COMMAND_OFFSET, EFI_PCI_COMMAND_MEMORY_SPACE);
> --
> 2.10.1
next prev parent reply other threads:[~2016-10-25 20:53 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 7:01 [PATCH 00/33] Fix typos in comments and variables Gary Lin
2016-10-19 7:01 ` [PATCH 01/33] ArmPkg: Fix typos in comments Gary Lin
2016-10-19 15:09 ` Ard Biesheuvel
2016-10-19 15:15 ` Laszlo Ersek
2016-10-19 15:33 ` Leif Lindholm
2016-10-19 7:01 ` [PATCH 02/33] BaseTools: Fix typos in comments and variables Gary Lin
2016-10-19 7:30 ` Gao, Liming
2016-10-19 7:36 ` Zhu, Yonghong
2016-10-19 7:01 ` [PATCH 03/33] CorebootPayloadPkg: Fix typos in comments Gary Lin
2016-10-26 18:50 ` Ma, Maurice
2016-10-19 7:01 ` [PATCH 04/33] CorebootModulePkg: " Gary Lin
2016-10-26 18:41 ` Ma, Maurice
2016-10-19 7:01 ` [PATCH 05/33] CryptoPkg: " Gary Lin
2016-10-26 3:00 ` Long, Qin
2016-10-19 7:01 ` [PATCH 06/33] DuetPkg: " Gary Lin
2016-10-19 7:46 ` Ni, Ruiyu
2016-10-19 7:01 ` [PATCH 07/33] EdkCompatibilityPkg: " Gary Lin
2016-10-19 8:19 ` Gao, Liming
2016-10-19 7:01 ` [PATCH 08/33] EmulatorPkg: Fix typos in comments and variables Gary Lin
2016-10-19 20:37 ` Jordan Justen
2016-10-20 8:16 ` Laszlo Ersek
2016-10-19 7:01 ` [PATCH 09/33] EmbeddedPkg: Fix typos in comments Gary Lin
2016-10-19 15:09 ` Ard Biesheuvel
2016-10-19 7:01 ` [PATCH 10/33] IntelFrameworkModulePkg: " Gary Lin
2016-10-20 1:08 ` Fan, Jeff
2016-10-19 7:01 ` [PATCH 11/33] IntelFrameworkPkg: " Gary Lin
2016-10-20 1:08 ` Fan, Jeff
2016-10-19 7:01 ` [PATCH 12/33] IntelFspPkg: " Gary Lin
2016-10-19 7:06 ` Yao, Jiewen
2016-10-19 7:01 ` [PATCH 13/33] IntelFspWrapperPkg: " Gary Lin
2016-10-19 7:08 ` Yao, Jiewen
2016-10-19 7:01 ` [PATCH 14/33] IntelFsp2Pkg: " Gary Lin
2016-10-19 7:06 ` Yao, Jiewen
2016-10-19 7:12 ` Mudusuru, Giri P
2016-10-19 7:01 ` [PATCH 15/33] IntelFsp2WrapperPkg: Fix a typo in the comment Gary Lin
2016-10-19 7:07 ` Yao, Jiewen
2016-10-19 7:11 ` Mudusuru, Giri P
2016-10-19 7:01 ` [PATCH 16/33] MdeModulePkg: BootManagerMenuApp: Fix typos in comments Gary Lin
2016-10-19 8:20 ` Tian, Feng
2016-10-19 7:01 ` [PATCH 17/33] MdeModulePkg/Bus: " Gary Lin
2016-10-19 7:01 ` [PATCH 18/33] MdeModulePkg/Core: " Gary Lin
2016-10-19 8:20 ` Tian, Feng
2016-10-19 7:01 ` [PATCH 19/33] MdeModulePkg/Include: " Gary Lin
2016-10-19 7:01 ` [PATCH 20/33] MdeModulePkg/Library: Fix typos in comments and variables Gary Lin
2016-10-19 7:01 ` [PATCH 21/33] MdeModulePkg/Universal: Fix typos in comments Gary Lin
2016-10-19 7:01 ` [PATCH 22/33] MdePkg: " Gary Lin
2016-10-19 8:21 ` Gao, Liming
2016-10-19 7:01 ` [PATCH 23/33] NetworkPkg: " Gary Lin
2016-10-19 7:21 ` Fu, Siyuan
2016-10-26 0:53 ` Fu, Siyuan
2016-10-19 7:01 ` [PATCH 24/33] Nt32Pkg: Fix typos in comments and variables Gary Lin
2016-10-19 7:50 ` Ni, Ruiyu
2016-10-19 7:01 ` [PATCH 25/33] OptionRomPkg: Fix typos in comments Gary Lin
2016-10-19 7:51 ` Ni, Ruiyu
2016-10-19 7:01 ` [PATCH 26/33] OvmfPkg: " Gary Lin
2016-10-19 7:01 ` [PATCH 27/33] QuarkPlatformPkg: " Gary Lin
2016-10-25 20:53 ` Kinney, Michael D [this message]
2016-10-19 7:01 ` [PATCH 28/33] QuarkSocPkg: " Gary Lin
2016-10-25 21:00 ` Kinney, Michael D
2016-10-19 7:01 ` [PATCH 29/33] SecurityPkg: " Gary Lin
2016-10-27 1:29 ` Zhang, Chao B
2016-11-14 3:12 ` Zhang, Chao B
2016-11-14 4:03 ` Gary Lin
2016-11-14 6:24 ` Gao, Liming
2016-11-14 8:30 ` Gary Lin
2016-10-19 7:01 ` [PATCH 30/33] ShellPkg: Fix typos in comments and variables Gary Lin
2016-10-19 7:51 ` Ni, Ruiyu
2016-10-19 20:29 ` Carsey, Jaben
2016-10-20 1:55 ` Gary Lin
2016-10-19 7:01 ` [PATCH 31/33] SourceLevelDebugPkg: Fix typos in comments Gary Lin
2016-10-19 7:46 ` Wu, Hao A
2016-10-19 7:01 ` [PATCH 32/33] UefiCpuPkg: " Gary Lin
2016-10-20 1:58 ` Fan, Jeff
2016-10-20 2:08 ` Gary Lin
2016-10-20 2:45 ` Fan, Jeff
2016-10-19 7:01 ` [PATCH 33/33] Vlv2TbltDevicePkg: " Gary Lin
2016-10-24 1:33 ` Wei, David
2016-10-19 7:28 ` [PATCH 00/33] Fix typos in comments and variables Zeng, Star
2016-10-19 14:50 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E92EE9817A31E24EB0585FDF735412F56483ADA9@ORSMSX113.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox