From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3E7FB1A1E43 for ; Tue, 25 Oct 2016 15:45:58 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP; 25 Oct 2016 15:45:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,399,1473145200"; d="scan'208";a="23996211" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga004.jf.intel.com with ESMTP; 25 Oct 2016 15:45:57 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.50]) by ORSMSX104.amr.corp.intel.com ([169.254.4.86]) with mapi id 14.03.0248.002; Tue, 25 Oct 2016 15:45:57 -0700 From: "Kinney, Michael D" To: "Yao, Jiewen" , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "Tian, Feng" , "Zeng, Star" , "Gao, Liming" , "Zhang, Chao B" Thread-Topic: [PATCH V4 06/12] SignedCapsulePkg/CapsulePkg.dec: Add capsule related definition. Thread-Index: AQHSLNRQFWv/tlXN4UeHmLzvr8lrNKC5x5zg Date: Tue, 25 Oct 2016 22:45:56 +0000 Message-ID: References: <1477189323-3312-1-git-send-email-jiewen.yao@intel.com> <1477189323-3312-7-git-send-email-jiewen.yao@intel.com> In-Reply-To: <1477189323-3312-7-git-send-email-jiewen.yao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMTQyODZjZTMtYjY0ZC00ZmFhLTg2MDktMWMyNWJjZjYzZThjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InA5Q0krRkNpajA0bXd4THJjaEFnV3h0Z3puXC9zWEdIRjNRZFQyRU1JODhvPSJ9 x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Subject: Re: [PATCH V4 06/12] SignedCapsulePkg/CapsulePkg.dec: Add capsule related definition. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Oct 2016 22:45:58 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jiewen, Comments included inline. Mike > -----Original Message----- > From: Yao, Jiewen > Sent: Saturday, October 22, 2016 7:22 PM > To: edk2-devel@lists.01.org > Cc: Tian, Feng ; Zeng, Star ; K= inney, Michael > D ; Gao, Liming ; Zhang= , Chao B > > Subject: [PATCH V4 06/12] SignedCapsulePkg/CapsulePkg.dec: Add capsule re= lated > definition. >=20 > 1) Add capsule related GUID. > EdkiiSystemFmpCapsule > 2) Add capsule related library. > EdkiiSystemCapsuleLib > IniParsingLib > PlatformFlashAccessLib > 5) Add EDKII system capsule related DynamicEx PCD > PcdEdkiiSystemFirmwareImageDescriptor > PcdEdkiiSystemFirmwareFileGuid > NOTE: We use DynamicEx here because the update driver may be in > the capsule FMP, instead of system firmware. > The update driver MUST use the PCD info produced system firmware. >=20 > Cc: Feng Tian > Cc: Star Zeng > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Chao Zhang > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jiewen Yao > Reviewed-by: Liming Gao > --- > SignedCapsulePkg/SignedCapsulePkg.dec | 65 ++++++++++++++++++++ > 1 file changed, 65 insertions(+) >=20 > diff --git a/SignedCapsulePkg/SignedCapsulePkg.dec > b/SignedCapsulePkg/SignedCapsulePkg.dec > new file mode 100644 > index 0000000..c03f70c > --- /dev/null > +++ b/SignedCapsulePkg/SignedCapsulePkg.dec > @@ -0,0 +1,65 @@ > +## @file > +# This package provides EDKII capsule related support. > +# > +# Copyright (c) 2016, Intel Corporation. All rights reserved.
> +# This program and the accompanying materials are licensed and made avai= lable under > +# the terms and conditions of the BSD License that accompanies this dist= ribution. > +# The full text of the license may be found at > +# http://opensource.org/licenses/bsd-license.php. > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR I= MPLIED. > +# > +## > + > + > +[Defines] > + DEC_SPECIFICATION =3D 0x00010005 > + PACKAGE_NAME =3D SignedCapsulePkg > + PACKAGE_GUID =3D 75AA5D82-7BC4-44A9-82FB-0820EBC79BE= D > + PACKAGE_VERSION =3D 0.1 > + > +[Includes] > + Include > + > +[LibraryClasses] > + ## @libraryclass Provides services for EDKII system FMP capsule. > + # > + EdkiiSystemCapsuleLib|Include/Library/EdkiiSystemCapsuleLib.h > + > + ## @libraryclass Provides services to parse the INI configuration fil= e. > + # > + IniParsingLib|Include/Library/IniParsingLib.h > + > + ## @libraryclass Provides services to access flash device. > + # > + PlatformFlashAccessLib|Include/Library/PlatformFlashAccessLib.h > + > +[Guids] > + gEfiSignedCapsulePkgTokenSpaceGuid =3D { 0xe1eb612f, 0x1c6c, 0x48= 5d, { 0x9d, 0x6, > 0x65, 0x8, 0x44, 0x88, 0x15, 0x69 }} > + > + ## Include/Guid/EdkiiSystemFmpCapsule.h > + gEdkiiSystemFirmwareImageDescriptorFileGuid =3D {0x90b2b846, 0xca6d, 0= x4d6e, {0xa8, > 0xd3, 0xc1, 0x40, 0xa8, 0xe1, 0x10, 0xac}} > + gEdkiiSystemFmpCapsuleConfigFileGuid =3D {0x812136d3, 0x4d3a, 0= x433a, {0x94, > 0x18, 0x29, 0xbb, 0x9b, 0xf7, 0x8f, 0x6e}} > + gEdkiiSystemFmpCapsuleDriverFvFileGuid =3D {0xce57b167, 0xb0e4, 0= x41e8, {0xa8, > 0x97, 0x5f, 0x4f, 0xeb, 0x78, 0x1d, 0x40}} > + > +[PcdsDynamicEx] > + ## This dynamic PCD hold the EDKII system firmware image descriptor. Typo. Should be "holds" > + # This information can be used for version check in EDKII system FMP = capsule. > + # Only if the new EdkiiSystemFrimwareImageDescriptor.Version is no le= ss than Typo. Should be "not less than". > + # the current PcdEdkiiSystemFirmwareImageDescriptor.LowestSupportedVe= rsion, > + # the EDKII system FmpCapsule will be processed. > + # It must be dynamicEx, because the EDKII system firmware update modu= le may Should be "Is must be in [PcdsDynamicEx], because" > + # consume the PCD produced in current system firmware. > + # @Prompt EDKII system firwmare image descriptor. Typo. Should be "system firmware image" The name of C structure type associated with this VOID* PCD should be inclu= ded in the description so a developer knows how to fill in all the byte values. > + > gEfiSignedCapsulePkgTokenSpaceGuid.PcdEdkiiSystemFirmwareImageDescriptor|= {0}|VOID*|0x00 > 000037 Build does not work with this PCD. The value 0 is not a hex value. It mus= t be 0x0. Is the intended default value {0x0}, or is the intended default value empty= {}? > + > + ## This dynamic PCD hold the GUID of a firmware FFS which includes EDK= II > + # system firmware image. > + # An EDKII system firmware udpate module need consume this PCD to ext= ract Typos. Should be "system firmware update module consumes this PCD". > + # the EDKII system firmware from the capsule image. > + # It must be dynamicEx, because the EDKII system firmware update modu= le may Should be "It must be in [PcdsDynamicEx], because" > + # consume the PCD produced in current system firmware. > + # @Prompt EDKII system firmware image FFS GUID. > + gEfiSignedCapsulePkgTokenSpaceGuid.PcdEdkiiSystemFirmwareFileGuid|{0xb= 2, 0x9e, 0x9c, > 0xaf, 0xad, 0x12, 0x3e, 0x4d, 0xa4, 0xd4, 0x96, 0xf6, 0xc9, 0x96, 0x62, > 0x15}|VOID*|0x00001010 > + > -- > 2.7.4.windows.1