From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id DF3211A1E46 for ; Wed, 26 Oct 2016 18:27:37 -0700 (PDT) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP; 26 Oct 2016 18:27:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,551,1473145200"; d="scan'208";a="24156035" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by fmsmga005.fm.intel.com with ESMTP; 26 Oct 2016 18:27:37 -0700 Received: from orsmsx156.amr.corp.intel.com (10.22.240.22) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 26 Oct 2016 18:27:36 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.50]) by ORSMSX156.amr.corp.intel.com ([10.22.240.22]) with mapi id 14.03.0248.002; Wed, 26 Oct 2016 18:27:36 -0700 From: "Kinney, Michael D" To: "Yao, Jiewen" , "edk2-devel@lists.01.org" , "Kinney, Michael D" CC: "Tian, Feng" , "Gao, Liming" , "Zeng, Star" , "Zhang, Chao B" Thread-Topic: [edk2] [PATCH V4 1/8] QuarkPlatformPkg/dec: Add test key file guid. Thread-Index: AQHSLNWiIVWY0EGE+0+fESCSV+dhZqC7fDnw Date: Thu, 27 Oct 2016 01:27:35 +0000 Message-ID: References: <1477189908-8336-1-git-send-email-jiewen.yao@intel.com> <1477189908-8336-2-git-send-email-jiewen.yao@intel.com> In-Reply-To: <1477189908-8336-2-git-send-email-jiewen.yao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZmFlMTdlNjQtODY0My00YTljLWJlMWYtNDNkOTIyMzNhYTRiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImQxQllwMUJ3RWJiQTU3MEhiODRiWFAxbjk5S0xzSVN2ZWVwemZSV3NXNXc9In0= x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: [PATCH V4 1/8] QuarkPlatformPkg/dec: Add test key file guid. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Oct 2016 01:27:38 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jiewen, Why are these 2 PCDs added to a platform specific DEC file? The same feedback applies to the Vlv2 platform. Since we want platform agnostic detection for the use of=20 test keys, these PCDs should be added to SignedCapsulePkg. I think the best place to do the check for use of test keys and set the gEfiMdeModulePkgTokenSpaceGuid.PcdTestKeyUsed PCD=20 is in a module in SignedCapsulePkg that is required to be present and run every boot before BDS runs when recovery or capsule=20 support is enabled. In a previous feedback email I suggested that this test key=20 check be moved to BdsEntry.c, but that will not work because that module does not have access to PCDs defined in SignedCapsulePkg. Best regards, Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ji= ewen Yao > Sent: Saturday, October 22, 2016 7:32 PM > To: edk2-devel@lists.01.org > Cc: Tian, Feng ; Gao, Liming ;= Zeng, Star > ; Kinney, Michael D ; Zh= ang, Chao B > > Subject: [edk2] [PATCH V4 1/8] QuarkPlatformPkg/dec: Add test key file gu= id. >=20 > We will add PKCS7 and RSA2048SHA256 test key file to FDF, > to check if the platform is using default test key, > or different production key. >=20 > Cc: Michael D Kinney > Cc: Kelly Steele > Cc: Feng Tian > Cc: Star Zeng > Cc: Liming Gao > Cc: Chao Zhang > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jiewen Yao > --- > QuarkPlatformPkg/QuarkPlatformPkg.dec | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/QuarkPlatformPkg/QuarkPlatformPkg.dec > b/QuarkPlatformPkg/QuarkPlatformPkg.dec > index f4ab18c..fbd7987 100644 > --- a/QuarkPlatformPkg/QuarkPlatformPkg.dec > +++ b/QuarkPlatformPkg/QuarkPlatformPkg.dec > @@ -895,6 +895,9 @@ > gQuarkPlatformTokenSpaceGuid.PcdFlashFvRecoveryBase|0xFFEC0400|UINT32|= 0xA00002AB > gQuarkPlatformTokenSpaceGuid.PcdFlashFvRecoverySize|0x0003F000|UINT32|= 0xA00002AC >=20 > + gQuarkPlatformTokenSpaceGuid.PcdEdkiiRsa2048Sha256TestPublicKeyFileGui= d|{0x04, 0xe1, > 0xfe, 0xc4, 0x57, 0x66, 0x36, 0x49, 0xa6, 0x11, 0x13, 0x8d, 0xbc, 0x2a, 0= x76, > 0xad}|VOID*|0xA0010001 > + gQuarkPlatformTokenSpaceGuid.PcdEdkiiPkcs7TestPublicKeyFileGuid|{0xba,= 0xf5, 0x93, > 0xf0, 0x37, 0x6f, 0x16, 0x48, 0x9e, 0x52, 0x91, 0xbe, 0xa0, 0xf7, 0xe0, > 0xb8}|VOID*|0xA0010002 > + > [PcdsDynamic, PcdsDynamicEx] > ## Provides the ability to enable the Fast Boot feature of the BIOS. = This > # enables the system to boot faster but may only enumerate the hardwa= re > -- > 2.7.4.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel