From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AA1DD81DD4 for ; Fri, 28 Oct 2016 12:28:12 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP; 28 Oct 2016 12:28:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,411,1473145200"; d="scan'208";a="25280628" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by orsmga004.jf.intel.com with ESMTP; 28 Oct 2016 12:28:12 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.50]) by ORSMSX104.amr.corp.intel.com ([169.254.4.86]) with mapi id 14.03.0248.002; Fri, 28 Oct 2016 12:28:10 -0700 From: "Kinney, Michael D" To: "Duran, Leo" , "edk2-devel@ml01.01.org" , "Kinney, Michael D" CC: "Fan, Jeff" , "Gao, Liming" , 'Laszlo Ersek' Thread-Topic: LocalApicLib: Why two separate directories? Thread-Index: AdIxTgPHfJzAAk7nTwONwEQmJGazqwAAFg9w Date: Fri, 28 Oct 2016 19:28:10 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjI1MzA4NmQtM2FjZS00ZGYyLTljNGQtNmUwNjFjMzU5MDE5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlVjY0JpVlFSSE9qRVJCQ2pKMXJUTnRMZjQwY3JCOHpmQVlDMWpmM3h5RkE9In0= x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: LocalApicLib: Why two separate directories? X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2016 19:28:12 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Leo, Your observation is correct, but the reason not to make this change now is= =20 the DSC file changes required that would break platform builds. As Laszlo points out, it is possible to do this type of change and coordinate update to all platforms in edk2/master. However, there are many other platforms=20 that use edk2 and a change like this would break them on next pull of=20 edk2/master. I believe the original X2 APIC implementation did not have as much common code, so that was likely why it was added as a different library. I recommend we just leave them in their own directories for right now. Thanks, Mike =20 > -----Original Message----- > From: Duran, Leo [mailto:leo.duran@amd.com] > Sent: Friday, October 28, 2016 12:04 PM > To: edk2-devel@ml01.01.org > Cc: Kinney, Michael D ; Fan, Jeff ; > Gao, Liming ; 'Laszlo Ersek' > Subject: LocalApicLib: Why two separate directories? >=20 > All, > Just a quick observation to request comments: >=20 > Since a lot of the code in BaseXApicX2ApicLib.c and BaseXApicLib is the s= ame, how about > we merge the common code and build the libraries from the same directory? >=20 > UefiCpuPkg/Library/LocalApilLib/ > - LocalApicLib.c --> common code > - BaseXApicLib.c --> legacy APIC code > - BaseXApicX2ApicLib.c --> X2APIC code > - BaseXApicLib.inf -> builds from LocalApicLib.c + BaseXApicLib.c > - BaseXApicX2ApicLib.inf -> builds from LocalApicLib.c + BaseXApicX2ApicL= ib.c >=20 > Of course, doing this would require modification to existing .DSC files, = to point to > the appropriate .INF under the merged LocalApicLib directory. > Would that be too disruptive? >=20 > Leo. >=20 >=20 >=20 >=20