From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 06C3681E28 for ; Fri, 11 Nov 2016 09:41:08 -0800 (PST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP; 11 Nov 2016 09:41:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,621,1473145200"; d="scan'208";a="1058356710" Received: from orsmsx103.amr.corp.intel.com ([10.22.225.130]) by orsmga001.jf.intel.com with ESMTP; 11 Nov 2016 09:41:11 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.250]) by ORSMSX103.amr.corp.intel.com ([169.254.5.37]) with mapi id 14.03.0248.002; Fri, 11 Nov 2016 09:41:10 -0800 From: "Kinney, Michael D" To: Pete Batard , "edk2-devel@lists.01.org" , "Kinney, Michael D" Thread-Topic: [edk2] [PATCH 0/2] MdeModulePkg/EbcDxe: add EBC Debugger Thread-Index: AQHSPDN4sHW9Zse4Y0Sr/Cq47t93f6DUC/ow Date: Fri, 11 Nov 2016 17:41:09 +0000 Message-ID: References: <22709fc2-7dec-f9eb-43f7-d06405349b7e@akeo.ie> In-Reply-To: <22709fc2-7dec-f9eb-43f7-d06405349b7e@akeo.ie> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNTJkZWQzNGEtYTgwYy00MGM1LWFjNjQtZjFiOWZjYmZlZTljIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InlibSt3dzBCWDhIZ1h1b3VJQkVpc1VvT1Z5cmttd2VaY2I5UXdHNU1tS2M9In0= x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Subject: Re: [PATCH 0/2] MdeModulePkg/EbcDxe: add EBC Debugger X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Nov 2016 17:41:08 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Pete, I see the new INF files uses '..' in the [Sources] section, which is not allowed. Can we move that INF file up one directory, so it can remove use of ..? I also see that this code defined its own=20 EFI_EBC_DEBUGGER_CODE macro. Could these be changed to the standard DEBUG_CODE() macro that can be enabled and disabled with a PCD? Or do you think we should add a new Feature Flag PCD to enable/disable the EBC debugger? Thanks, Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Pe= te > Batard > Sent: Friday, November 11, 2016 7:51 AM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 0/2] MdeModulePkg/EbcDxe: add EBC Debugger >=20 > The EBC Debugger [1], which was present in Tianocore [2], is an > invaluable tool for EBC development. > This patch adds it back into the EDK2, allowing, for instance, the > compilation of an AARCH64 EBC debugger. >=20 > Note 1: The patch is split in two, so that the changes to the existing > EbcDxe code are clearer. >=20 > Note 2: The diff between the original and the new sources can be found > at [3]. Most of the changes were for whitespaces/API names/compiler > warnings, with the notable exception of: > - Bumping of the EBCdebugger version to 1.0. > - Dropping of the DebuggerConfiguration protocol (which would require > introducing a new global GUID and protocol). I didn't see it as > particularly useful to caary on and would rather see if there is actual > demand for it, before adding it back. > - Add of an EFIAPI qualifier for most of the support functions, > especially the ones dealing with VPrint() ouput. This is required to > avoid garbage text output in some instances. > - Fixing of the erroneous display of 32 and 64 bit indexes in the > disassembly. > - Replacement of one assignation with CopyMem() to avoid an intrinsic > memcpy(). >=20 > Note 3: I tested the debugger built for AARCH64 and X64 using gcc on > Linux (Debian/Sid) as well as the one built for IA32 and X64 using > VS2015 on Windows. I haven't tested an IA64 version for lack of a toolcha= in. >=20 > Regards, >=20 > /Pete >=20 > [1] http://www.uefi.org/node/550 > [2] https://github.com/tianocore/edk/tree/master/Sample/Universal/Ebc/Dxe > [3] > https://github.com/pbatard/EbcDebugger/commit/906e87ed6ceab1c361ba6f681be= f48179ba > f549e > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel