From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0BAB781EE1 for ; Fri, 11 Nov 2016 12:47:32 -0800 (PST) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP; 11 Nov 2016 12:47:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,474,1473145200"; d="scan'208";a="1067333903" Received: from orsmsx104.amr.corp.intel.com ([10.22.225.131]) by fmsmga001.fm.intel.com with ESMTP; 11 Nov 2016 12:47:35 -0800 Received: from orsmsx160.amr.corp.intel.com (10.22.226.43) by ORSMSX104.amr.corp.intel.com (10.22.225.131) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 11 Nov 2016 12:47:35 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.250]) by ORSMSX160.amr.corp.intel.com ([10.22.226.43]) with mapi id 14.03.0248.002; Fri, 11 Nov 2016 12:47:34 -0800 From: "Kinney, Michael D" To: "Gao, Liming" , "edk2-devel@lists.01.org" , "Kinney, Michael D" Thread-Topic: [Patch] MdePkg Base.h: Update field name in VERIFY_UINTXX_ENUM_SIZE to follow style Thread-Index: AQHSO8xOqf2AHNQYNEyIpfPue55096DUEK7g Date: Fri, 11 Nov 2016 20:47:33 +0000 Message-ID: References: <1478835172-32372-1-git-send-email-liming.gao@intel.com> In-Reply-To: <1478835172-32372-1-git-send-email-liming.gao@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGJmOWQ2MGMtYjc0NC00ZmJjLThmY2ItY2JjNjI0N2VlYTIyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InRXOE8zRmY4MjBXcXV2Wm1CdUpHWk5wRTZ0eWpVWkNZXC8zakF5UmF6a1RRPSJ9 x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Subject: Re: [Patch] MdePkg Base.h: Update field name in VERIFY_UINTXX_ENUM_SIZE to follow style X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Nov 2016 20:47:32 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Liming, I agree enums should start with [A-Z]. These enums are only use to verify compiler config is right and I wanted to make sure the enum names did not conflict with any other names that might be used. This is why I added '__' to the beginning of these enum names. These enums would never be used my any code after the verify=20 operation in the same .h file. I don't expect name collisions without the '__', so I am ok with this patch. But, we could also consider adding a comment that the '__' is on purpose. Mike > -----Original Message----- > From: Gao, Liming > Sent: Thursday, November 10, 2016 7:33 PM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D > Subject: [Patch] MdePkg Base.h: Update field name in VERIFY_UINTXX_ENUM_S= IZE to > follow style >=20 > For field name in structure, its first character should be upper case. >=20 > Cc: Michael Kinney > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Liming Gao > --- > MdePkg/Include/Base.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git a/MdePkg/Include/Base.h b/MdePkg/Include/Base.h > index 5e24b5d..749c275 100644 > --- a/MdePkg/Include/Base.h > +++ b/MdePkg/Include/Base.h > @@ -64,15 +64,15 @@ VERIFY_SIZE_OF (CHAR8, 1); > VERIFY_SIZE_OF (CHAR16, 2); >=20 > typedef enum { > - __VerifyUint8EnumValue =3D 0xff > + VerifyUint8EnumValue =3D 0xff > } __VERIFY_UINT8_ENUM_SIZE; >=20 > typedef enum { > - __VerifyUint16EnumValue =3D 0xffff > + VerifyUint16EnumValue =3D 0xffff > } __VERIFY_UINT16_ENUM_SIZE; >=20 > typedef enum { > - __VerifyUint32EnumValue =3D 0xffffffff > + VerifyUint32EnumValue =3D 0xffffffff > } __VERIFY_UINT32_ENUM_SIZE; >=20 > VERIFY_SIZE_OF (__VERIFY_UINT8_ENUM_SIZE, 4); > -- > 2.8.0.windows.1