Re: [PATCH v2] BaseTools gitignore: Ignore VS intermediate files *.obj and *.pdb

["Kinney, Michael D" <michael.d.kinney@intel.com>]

Liming,

I agree.  The current patch is good.

Reviewed-by: Michael Kinney <michael.d.kinney@intel.com>

Mike

From: Gao, Liming 
Sent: Tuesday, November 15, 2016 5:27 PM
To: Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel@lists.01.org
Subject: RE: [edk2] [PATCH v2] BaseTools gitignore: Ignore VS intermediate files *.obj and *.pdb

Mike:
  We don't need to add C tools .exe in edk2 git repo. All C tools .exe are in another git repo edk2-BaseTools-win32. And, Bin/Win32 directory is already in .gitignore. All exe files in Bin directory have been ignored. 

Thanks
Liming
From: Kinney, Michael D 
Sent: Wednesday, November 16, 2016 12:25 AM
To: Gao, Liming <liming.gao@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: RE: [edk2] [PATCH v2] BaseTools gitignore: Ignore VS intermediate files *.obj and *.pdb

Liming,

The current patch would ignore .exe in BaseTools/Bin

Since you had to add .exe, should this be done in .gitignore in
BaseTools/Source instead?

Thanks,

Mike

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Liming Gao
> Sent: Tuesday, November 15, 2016 2:40 AM
> To: edk2-devel@lists.01.org
> Subject: [edk2] [PATCH v2] BaseTools gitignore: Ignore VS intermediate files
> *.obj and *.pdb
> 
> In V2, ignore .exe and .ilk files
> 
> Cc: Yonghong Zhu 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Liming Gao 
> ---
> BaseTools/.gitignore | 4 ++++
> 1 file changed, 4 insertions(+)
> 
> diff --git a/BaseTools/.gitignore b/BaseTools/.gitignore
> index 5ca024c..a45689b 100644
> --- a/BaseTools/.gitignore
> +++ b/BaseTools/.gitignore
> @@ -1,5 +1,9 @@
> *.d
> *.o
> +*.obj
> +*.pdb
> +*.ilk
> +*.exe
> *.pyc
> Source/C/VfrCompile/EfiVfrParser.cpp
> Source/C/VfrCompile/EfiVfrParser.h
> --
> 2.8.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel